Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4: https://wiki.php.net/rfc/deprecate_curly_braces_array_access
$hash2{$i} should be $hash2[$i]
PHP Deprecated: Array and string offset access syntax with curly braces is deprecated in ./vendor/mediawiki/oauthclient/src/Client.php on line 414
GitHub PR by GlazerMann https://github.com/wikimedia/mediawiki-oauthclient-php/pull/7 predates task but the repo seems to be using Gerrit.
@Legoktm @Umherirrender does this look like MediaWiki-Codesniffer material?
FWIW https://gist.github.com/theodorejb/763b83a43522b0fc1755a537663b1863, https://github.com/PHPCompatibility/PHPCompatibility/pull/855
Change 537227 had a related patch set uploaded (by Reedy; owner: GlazerMann):
[mediawiki/oauthclient-php@master] Deprecated
Change 537227 merged by jenkins-bot:
[mediawiki/oauthclient-php@master] Fix code deprecated in PHP 7.4
Patches imported from github, merged on gerrit
Needs a release tagging in the library, and then bumping in MediaWiki-extensions-OAuthAuthentication (and any other usages)
@Reedy What more is remaining in this task to be done? Is this still a good first task? Please help update the task description with some clear next steps. Thank you!
I didn't add good first task ;)
https://github.com/wikimedia/mediawiki-oauthclient-php/compare/1.0.2...master suggests a release still needs tagging, and then using in MediaWiki-extensions-OAuthAuthentication
$ git push --tags Enumerating objects: 1, done. Counting objects: 100% (1/1), done. Writing objects: 100% (1/1), 300 bytes | 150.00 KiB/s, done. Total 1 (delta 0), reused 0 (delta 0) remote: Processing changes: done To ssh://gerrit.wikimedia.org:29418/mediawiki/oauthclient-php * [new tag] 1.1.0 -> 1.1.0
Change 573554 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/OAuthAuthentication@master] Bump mediawiki/oauthclient to ~1.1.0
Change 573554 merged by jenkins-bot:
[mediawiki/extensions/OAuthAuthentication@master] Bump mediawiki/oauthclient to ~1.1.0