Landing page event logging events have -1 as schema revision number.
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	AndyRussG
	Aug 28 2019, 6:20 AM

Description

It seems likely this is due to incorrect formatting in extension.json, introduced here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FundraiserLandingPage/+/508906

Seen on the eventlogging_EventError kafka stream:

{"event": {"code": "validation", "message": "Invalid revision ID -1", "rawEvent": "{\"dt\": \"2019-08-28T05:41:03Z\", \"event\": {\"country\": \"MX\", \"landingpage\": \"Special:LandingPage\", \"language\": \"en\", \"sample_rate\": 1, \"utm_campaign\": \"spontaneous\", \"utm_medium\": \"spontaneous\", \"utm_source\": \"fr-redir\"}, \"ip\": \"bla.bla.bla.bla\", \"recvFrom\": \"cp2004.codfw.wmnet\", \"revision\": -1, \"schema\": \"LandingPageImpression\", \"seqId\": 4427763, \"userAgent\": {\"browser_family\": \"Chrome\", \"browser_major\": \"70\", \"browser_minor\": \"0\", \"device_family\": \"Other\", \"is_bot\": false, \"is_mediawiki\": false, \"os_family\": \"Linux\", \"os_major\": null, \"os_minor\": null, \"wmf_app_version\": \"-\"}, \"uuid\": \"e7c2c4208391533a8276e867a8b727f2\", \"webHost\": \"donate.wikimedia.org\", \"wiki\": \"donatewiki\"}", "revision": -1, "schema": "LandingPageImpression"}, "recvFrom": "eventlog1002.eqiad.wmnet", "revision": 14035058, "schema": "EventError", "timestamp": 1566970865, "uuid": "6d641e3cc95611e987621418775b0d42", "wiki": ""}

Details

	Subject	Repo	Branch	Lines +/-
	Fix location of eventlogging schema revision in extension.json	mediawiki/extensions/FundraiserLandingPage	master	+2 -6

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T183978 [Epic] Fundraising kafkatee changes
		Resolved		AndyRussG	T231406 Landing page event logging events have -1 as schema revision number.

Event Timeline

AndyRussG created this task.Aug 28 2019, 6:20 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 28 2019, 6:20 AM

Change 532858 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/FundraiserLandingPage@master] Fix location of eventlogging schema revision in extension.json

https://gerrit.wikimedia.org/r/532858

gerritbot added a project: Patch-For-Review.Aug 28 2019, 6:33 AM

AndyRussG claimed this task.Aug 28 2019, 6:34 AM

AndyRussG added a project: Fundraising Sprint Quick and the Deadlocked.

AndyRussG moved this task from Backlog to Review on the Fundraising Sprint Quick and the Deadlocked board.

AndyRussG set the point value for this task to 1.

Change 532858 merged by jenkins-bot:
[mediawiki/extensions/FundraiserLandingPage@master] Fix location of eventlogging schema revision in extension.json

https://gerrit.wikimedia.org/r/532858

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Aug 28 2019, 2:00 PM

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Quick and the Deadlocked board.Aug 28 2019, 2:02 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 2:10 PM

AndyRussG removed a project: Epic.Aug 28 2019, 3:30 PM

Krinkle awarded a token.Aug 28 2019, 3:32 PM

• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Sep 3 2019, 4:10 PM

• DStrine added a project: Fundraising Sprint Rocky Horror Presentation Layer.Sep 3 2019, 8:23 PM

Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Rocky Horror Presentation Layer board.Sep 3 2019, 10:26 PM

AndyRussG moved this task from Pending Deployment to Deployed on the Fundraising Sprint Rocky Horror Presentation Layer board.Sep 13 2019, 2:50 PM

Verified that this is fixed!