Page MenuHomePhabricator

CI is failing, caused by Lua Tests
Closed, ResolvedPublic

Description

Please see: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/68431/consoleFull

Until it's fixed, there is no merging on gerrit (at least for bridge) possible.

Event Timeline

alaa_wmde added a subscriber: alaa_wmde.

It is blocking merges on other repos too

Further bisected that patch to arrive at this fix:

diff --git a/tests/phpunit/MediaWikiIntegrationTestCase.php b/tests/phpunit/MediaWikiIntegrationTestCase.php
index 83f27e847d..229d71a5de 100644
--- a/tests/phpunit/MediaWikiIntegrationTestCase.php
+++ b/tests/phpunit/MediaWikiIntegrationTestCase.php
@@ -1123,6 +1123,9 @@ public function setContentLang( $lang ) {
             $this->setMwGlobals( 'wgLanguageCode', $lang->getCode() );
         } else {
             $this->setMwGlobals( 'wgLanguageCode', $lang );
+            $services = MediaWikiServices::getInstance();
+            $services->resetServiceForTesting( 'ContentLanguage' );
+            $this->setMwGlobals( [ 'wgContLang' => $services->getContentLanguage() ] );
         }
     }

Will upload shortly.

It is blocking merges on other repos too

Which ones? If they’re not Wikidata-related, that’s a ci-test-error (WMF-deployed Build Failure).

Change 533510 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/core@master] Also set $wgContLang in MWITC::setContentLang()

https://gerrit.wikimedia.org/r/533510

It is blocking merges on other repos too

Which ones? If they’re not Wikidata-related, that’s a ci-test-error (WMF-deployed Build Failure).

Only saw it on this one https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikidata.org/+/532968 which is a Wikidata one

Change 533510 merged by jenkins-bot:
[mediawiki/core@master] Also set $wgContLang in MWITC::setContentLang()

https://gerrit.wikimedia.org/r/533510

DannyS712 added a subscriber: DannyS712.

[batch] remove patch for review tag from resolved tasks