Page MenuHomePhabricator

Rename cancelBanner() methods and related statuses
Open, Needs TriagePublic2 Estimated Story Points

Description

Now that we have campaign fallback, when a campaign declines to show a banner, another campaign may take the pageview and may show one. The internal API functions for this are called cancelBanner(), but this name no longer seems very clear, given the new process. Something better would be failCampaign() or cancelBannersForCampaign().

Also, the term "banner cancelled" is repeated further downstream in the data pipeline.

We should probably update the function names and terms used in the data pipeline, while maintaining backwards compatibility for both.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2019, 12:08 AM

Change 623314 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@master] WIP First attempt at fixing state and fallback

https://gerrit.wikimedia.org/r/623314

The attached patch renames methods (the first part of this task) but doesn't rename statuses (the second part).

Change 623314 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Campaign fallback follow-up: refactor data handling and some methods

https://gerrit.wikimedia.org/r/623314