Page MenuHomePhabricator
Create Task
Maniphest T232549

Start module rendering broken in Safari 10 on desktop
Closed, ResolvedPublic
Actions

Description

Looks a lot like T225668, but affects desktop instead of mobile.

Screenshot courtesy of @Etonkovidova:

Screen Shot 2019-09-10 at 3.19.19 PM.png (659×1 px, 151 KB)

Details

SubjectRepoBranchLines +/-
Homepage: Fix start module layout bugsmediawiki/extensions/GrowthExperimentswmf/1.34.0-wmf.21+1 -2
Homepage: Fix start module layout bugsmediawiki/extensions/GrowthExperimentswmf/1.34.0-wmf.22+1 -2
Homepage: Fix start module layout bugsmediawiki/extensions/GrowthExperimentsmaster+1 -2
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.Sep 10 2019, 10:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2019, 10:59 PM
Catrope claimed this task.Sep 10 2019, 11:00 PM
Catrope added projects: GrowthExperiments, Growth-Team (Sprint 0 (Growth Team)).
Catrope moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Sep 10 2019, 11:20 PM

Change 535699 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Homepage: Fix start module layout bugs

https://gerrit.wikimedia.org/r/535699

gerritbot added a project: Patch-For-Review.Sep 10 2019, 11:20 PM
Catrope moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 10 2019, 11:27 PM
Aklapper removed a project: GrowthExperiments.Sep 11 2019, 12:46 PM
gerritbot added a comment.Sep 11 2019, 12:55 PM

Change 535837 had a related patch set uploaded (by Kosta Harlan; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.22] Homepage: Fix start module layout bugs

https://gerrit.wikimedia.org/r/535837

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 11 2019, 12:58 PM
gerritbot added a comment.Sep 11 2019, 3:26 PM

Change 535699 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Homepage: Fix start module layout bugs

https://gerrit.wikimedia.org/r/535699

gerritbot added a comment.Sep 11 2019, 4:15 PM

Change 535837 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.22] Homepage: Fix start module layout bugs

https://gerrit.wikimedia.org/r/535837

Stashbot mentioned this in T230629: Start module (overlay and server-side rendered view) layout broken in Firefox.Sep 11 2019, 4:31 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-11T16:31:17Z] <urbanecm@deploy1001> Synchronized php-1.34.0-wmf.22/extensions/GrowthExperiments/modules/homepage/ext.growthExperiments.StartModule.less: SWAT: c45d6d0: Homepage: Fix start module layout bugs (T230629, T232549, T225668) (duration: 01m 03s)

Stashbot mentioned this in T225668: Homepage: start module layout on iOS Safari 10 and iOS Chrome 60.0.3112.89.Sep 11 2019, 4:31 PM
gerritbot added a comment.Sep 11 2019, 4:36 PM

Change 535887 had a related patch set uploaded (by Gergő Tisza; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.21] Homepage: Fix start module layout bugs

https://gerrit.wikimedia.org/r/535887

gerritbot added a comment.Sep 11 2019, 4:53 PM

Change 535887 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.21] Homepage: Fix start module layout bugs

https://gerrit.wikimedia.org/r/535887

Stashbot added a comment.Sep 11 2019, 4:57 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-11T16:56:59Z] <urbanecm@deploy1001> Synchronized php-1.34.0-wmf.21/extensions/GrowthExperiments/modules/homepage/ext.growthExperiments.StartModule.less: SWAT: rEGREc0fd0617ea59: Homepage: Fix start module layout bugs (T230629, T232549, T225668) (duration: 01m 02s)

Maintenance_bot removed a project: Patch-For-Review.Sep 11 2019, 5:10 PM
Etonkovidova closed this task as Resolved.Sep 11 2019, 9:39 PM

Checked the fix in betalabs - no display issues on Homepage

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits