Page MenuHomePhabricator

Graph analysis of ResourceLoader modules that can be merged to each other
Open, MediumPublic

Description

Running T232728#5495112 on enwiki startup modules yields these RL modules that can be merged (note it doesn't consider lazy loading, soft dependencies, and lots of other factors, keep it in mind the results are not 100% should result to merging these modules).

(CX is in T231326#5488932)

TimedMediaHandler


PageTriage

Graph

RevisionSlider

CodeMirror

Citoid

TemplateData

TwoColConflict

Core: Special:Block

Core: Special:Search

Collection

CentralNotice

AdvancedSearch

3D

MobileFrontend

There are way more but I stop at here

Details

Related Gerrit Patches:
mediawiki/skins/MinervaNeue : masterMerge skins.minerva.talk and skins.minerva.watchstar into skins.minerva.script
mediawiki/skins/MinervaNeue : masterRemove 3 modules from Minerva

Event Timeline

Restricted Application added a project: Performance-Team. · View Herald TranscriptSep 16 2019, 8:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Ladsgroup updated the task description. (Show Details)Sep 16 2019, 8:41 PM

@Ladsgroup note there may be a few problems in your script - in the MobileFrontend Nearby case, mobile.nearby.images cannot be merged with the parent module as it's a ResourceLoaderImageModule not a ResourceLoaderFileModule. Side note: I think if those two classes could be merged though, this and many other modules could be collapsed.

The nearby.styles module is added via addModuleStyles to avoid flashes of unstyled content. It's also specified as a dependency (possibly redundantly) but that's why it's separate.

@Ladsgroup note there may be a few problems in your script - in the MobileFrontend Nearby case, mobile.nearby.images cannot be merged with the parent module as it's a ResourceLoaderImageModule not a ResourceLoaderFileModule. Side note: I think if those two classes could be merged though, this and many other modules could be collapsed.
The nearby.styles module is added via addModuleStyles to avoid flashes of unstyled content. It's also specified as a dependency (possibly redundantly) but that's why it's separate.

Yeah, it can not distinguish these edge cases. but if I think 'mobile.nearby.images' and its parent can be merged though. Here's an example: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TemplateData/+/536391/2/extension.json I don't know exactly how though.

That example merges ext.templateDataGenerator.ui.images and ext.templateData.images. It doesn't use packageFiles.

Krinkle triaged this task as Medium priority.Sep 16 2019, 9:52 PM
Krinkle moved this task from Inbox to External on the MediaWiki-ResourceLoader board.
Krinkle removed a project: MediaWiki-ResourceLoader.

Change 537773 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Merge skins.minerva.talk and skins.minerva.watchstar into skins.minerva.script

https://gerrit.wikimedia.org/r/537773

Change 537774 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Remove 3 modules from Minerva

https://gerrit.wikimedia.org/r/537774

Change 537774 abandoned by Jdlrobson:
Remove 3 modules from Minerva

https://gerrit.wikimedia.org/r/537774

Change 537773 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Merge skins.minerva.talk and skins.minerva.watchstar into skins.minerva.script

https://gerrit.wikimedia.org/r/537773