Graph analysis of ResourceLoader modules that can be merged to each other
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ladsgroup
	Sep 16 2019, 8:07 PM

Description

Running T232728#5495112 on enwiki startup modules yields these RL modules that can be merged (note it doesn't consider lazy loading, soft dependencies, and lots of other factors, keep it in mind the results are not 100% should result to merging these modules).

(CX is in T231326#5488932)

TimedMediaHandler

PageTriage

Graph

RevisionSlider

CodeMirror

Citoid

TemplateData

TwoColConflict

Core: Special:Block

Core: Special:Search

mediawiki.special.search.png (347×409 px, 27 KB)

Collection

CentralNotice

AdvancedSearch

ext.3d.special.upload.png (251×595 px, 24 KB)

MobileFrontend

mobile.special.nearby.scripts.png (155×570 px, 19 KB)

There are way more but I stop at here

Details

	Subject	Repo	Branch	Lines +/-
	Merge skins.minerva.talk and skins.minerva.watchstar into skins.minerva.script	mediawiki/skins/MinervaNeue	master	+37 -64
	Remove 3 modules from Minerva	mediawiki/skins/MinervaNeue	master	+0 -0

Customize query in gerrit

Related Objects

Mentioned Here: T231326: Use ResourceLoader package files to reduce number of CX modules
T232728: Create a dependency graph of existing RL modules

Event Timeline

Ladsgroup created this task.Sep 16 2019, 8:07 PM

Restricted Application added a project: Performance-Team. · View Herald TranscriptSep 16 2019, 8:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Ladsgroup updated the task description. (Show Details)Sep 16 2019, 8:41 PM

@Ladsgroup note there may be a few problems in your script - in the MobileFrontend Nearby case, mobile.nearby.images cannot be merged with the parent module as it's a ResourceLoaderImageModule not a ResourceLoaderFileModule. Side note: I think if those two classes could be merged though, this and many other modules could be collapsed.

The nearby.styles module is added via addModuleStyles to avoid flashes of unstyled content. It's also specified as a dependency (possibly redundantly) but that's why it's separate.

In T233048#5497308, @Jdlrobson wrote:

@Ladsgroup note there may be a few problems in your script - in the MobileFrontend Nearby case, mobile.nearby.images cannot be merged with the parent module as it's a ResourceLoaderImageModule not a ResourceLoaderFileModule. Side note: I think if those two classes could be merged though, this and many other modules could be collapsed.

The nearby.styles module is added via addModuleStyles to avoid flashes of unstyled content. It's also specified as a dependency (possibly redundantly) but that's why it's separate.

Yeah, it can not distinguish these edge cases. but if I think 'mobile.nearby.images' and its parent can be merged though. Here's an example: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TemplateData/+/536391/2/extension.json I don't know exactly how though.

That example merges ext.templateDataGenerator.ui.images and ext.templateData.images. It doesn't use packageFiles.

Krinkle triaged this task as Medium priority.Sep 16 2019, 9:52 PM

Krinkle moved this task from Inbox to External on the MediaWiki-ResourceLoader board.

Krinkle added a project: Wikimedia-Performance-publish.

Krinkle removed a project: MediaWiki-ResourceLoader.

Krinkle moved this task from Untriaged to Ready for write-up on the Wikimedia-Performance-publish board.Sep 17 2019, 7:04 PM

Change 537773 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Merge skins.minerva.talk and skins.minerva.watchstar into skins.minerva.script

https://gerrit.wikimedia.org/r/537773

Change 537774 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Remove 3 modules from Minerva

https://gerrit.wikimedia.org/r/537774

Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.Sep 23 2019, 8:28 PM

Change 537774 abandoned by Jdlrobson:
Remove 3 modules from Minerva

https://gerrit.wikimedia.org/r/537774

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Sep 24 2019, 3:52 AM

Change 537773 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Merge skins.minerva.talk and skins.minerva.watchstar into skins.minerva.script

https://gerrit.wikimedia.org/r/537773

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.25; 2019-10-01).Sep 24 2019, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 24 2019, 10:10 PM

Krinkle closed this task as Resolved.May 28 2023, 4:10 PM

Krinkle claimed this task.

Krinkle moved this task from Ready for write-up to Misc bookmarks on the Wikimedia-Performance-publish board.

	F30374044: mobile.special.nearby.scripts.png
	Sep 16 2019, 8:07 PM

	F30373982: ext.CodeMirror.lib.mode.php.png
	Sep 16 2019, 8:07 PM

Graph analysis of ResourceLoader modules that can be merged to each otherClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Graph analysis of ResourceLoader modules that can be merged to each other
Closed, ResolvedPublic
Actions