Page MenuHomePhabricator

Replace `inline-block` on boxed messages by `block`
Closed, ResolvedPublic

Description

Message boxes in shared.css currently feature inline-block to originally provide intrinsic width boxes, coming from https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/62439/ and T35438: SpecialPreferences: <p> should not be inside <strong>.

We needed to add a general, neutral messagebox treatment, but inline-block in there collided with same class used in mbox and votearchive templates as reported by @Perhelion in T232553#5506657.

Back in 2013, the box messages were also used in special pages like Special:Preferences. This is not or only scarcely true anymore. For a box message it's intended to be a block level element by definition and inline-block should be the exceptional override if at all.

Event Timeline

Volker_E created this task.Sep 19 2019, 8:22 PM
Restricted Application added a project: UI-Standardization. · View Herald TranscriptSep 19 2019, 8:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 538109 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Remove inline-block from message boxes

https://gerrit.wikimedia.org/r/538109

Titore added a subscriber: Titore.Sep 20 2019, 8:45 AM

Change 538109 merged by jenkins-bot:
[mediawiki/core@master] Remove inline-block from message boxes

https://gerrit.wikimedia.org/r/538109

Volker_E closed this task as Resolved.Sep 20 2019, 11:22 PM
Volker_E claimed this task.
Volker_E triaged this task as High priority.
Volker_E removed a project: Patch-For-Review.

Thanks for the quick fix! Can someone deploy it on Monday (through SWAT)?