Page MenuHomePhabricator
Create Task
Maniphest T233552

MarkAsHelpful needs 'editToken' replaced with 'csrfToken'
Closed, ResolvedPublic
Actions

Description

MarkAsHelpful needs 'editToken' replaced with 'csrfToken' in modules/ext.markAsHelpful/ext.markAsHelpful.js per "everything" code search.

Details

SubjectRepoBranchLines +/-
MarkAsHelpful: Replace deprecated editToken with csrfTokenmediawiki/extensions/MarkAsHelpfulmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

TheSandDoctor triaged this task as Low priority.Sep 22 2019, 9:38 PM
TheSandDoctor created this task.
Reedy removed a project: Performance-Team.Sep 22 2019, 9:58 PM
TheSandDoctor added a project: User-TheSandDoctor.Sep 23 2019, 6:44 AM
gerritbot added a comment.Sep 23 2019, 4:19 PM

Change 538664 had a related patch set uploaded (by TheSandDoctor; owner: TheSandDoctor):
[mediawiki/extensions/MarkAsHelpful@master] MarkAsHelpful: Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/538664

gerritbot added a project: Patch-For-Review.Sep 23 2019, 4:19 PM
TheSandDoctor changed the task status from Open to Stalled.Sep 23 2019, 4:20 PM
TheSandDoctor moved this task from Backlog to git review pending on the User-TheSandDoctor board.

Pull request also made on GitHub.

Aklapper added a comment.Nov 27 2019, 10:27 PM

No need for pull requests on Github - https://github.com/wikimedia/mediawiki-extensions-MarkAsHelpful says "Github mirror of MediaWiki extension MarkAsHelpful - our actual code is hosted with Gerrit (please see https://www.mediawiki.org/wiki/Developer_access for contributing)"

I'm not sure if any of the authors listed on https://www.mediawiki.org/wiki/Extension:MarkAsHelpful are still active...

Krinkle unsubscribed.Nov 28 2019, 4:19 AM
TheSandDoctor added subscribers: Reedy, Tgr.Dec 30 2019, 5:21 AM

This was written by two former WMF staffers and an inactive contributor. Is there any way that this could be merged anyways (e.g. an override) or the extension archived if not? @Reedy @Tgr

gerritbot added a comment.Dec 30 2019, 10:16 PM

Change 538664 merged by jenkins-bot:
[mediawiki/extensions/MarkAsHelpful@master] MarkAsHelpful: Replace deprecated editToken with csrfToken

https://gerrit.wikimedia.org/r/538664

TheSandDoctor mentioned this in rEMAHdf3eecf34e8d: MarkAsHelpful: Replace deprecated editToken with csrfToken.Dec 30 2019, 10:25 PM
TheSandDoctor closed this task as Resolved.Dec 31 2019, 12:15 AM
TheSandDoctor moved this task from git review pending to merged/done on the User-TheSandDoctor board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL