WikibaseMediaInfo should not export unprefixed config/globals in JavaScript
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	Sep 24 2019, 4:22 PM

Description

maxCaptionLength

parsedMessageAnonEditWarning

userCanEdit

And as of last month, also:

protectionMsg

These are far too generic to be exported without any prefixed relating to MediaWiki, Wikibase, or WikibaseMediaInfo. This is problematic within mw.config itself, but even more so because they also become global variables.

Probably easiest to consolidate them under a single, prefixed, key, such wgWbMediaInfo or something like that.

Details

	Subject	Repo	Branch	Lines +/-
	Add extension-specific prefix to global JavaScript variables	mediawiki/extensions/WikibaseMediaInfo	master	+13 -13

Customize query in gerrit

Event Timeline

Krinkle created this task.Sep 24 2019, 4:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2019, 4:22 PM

Found via https://grafana.wikimedia.org/d/000000037/mw-js-deprecate.

Krinkle added a project: Multimedia.Sep 24 2019, 4:24 PM

• Ramsey-WMF assigned this task to AnneT.Oct 7 2019, 4:26 PM

• Ramsey-WMF triaged this task as Medium priority.

• Ramsey-WMF edited projects, added Structured-Data-Backlog (Current Work), Structured Data Engineering; removed Multimedia.

• Ramsey-WMF moved this task from To Do to Doing on the Structured Data Engineering board.

• Mholloway renamed this task from WikimediaMediaInfo should not export unprefixed config/globals in JavaScript to WikibaseMediaInfo should not export unprefixed config/globals in JavaScript.Oct 7 2019, 4:27 PM

AnneT moved this task from Incoming to Doing on the Structured-Data-Backlog (Current Work) board.Oct 8 2019, 4:49 PM

Change 541902 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Add extension-specific prefix to global JavaScript variables

https://gerrit.wikimedia.org/r/541902

gerritbot added a project: Patch-For-Review.Oct 9 2019, 7:26 PM

Change 541902 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Add extension-specific prefix to global JavaScript variables

https://gerrit.wikimedia.org/r/541902

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 9 2019, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 9 2019, 9:11 PM

matthiasmullie closed this task as Resolved.Oct 10 2019, 2:41 PM

matthiasmullie moved this task from Doing to Needs QA on the Structured-Data-Backlog (Current Work) board.