Page MenuHomePhabricator
Create Task
Maniphest T234322

Remove autojump of focus from property field to value field
Closed, ResolvedPublic
Actions

Description

Based on the discussion in T172937: Cursor jumping to next field and overlapping of menus, we have decided to remove the autojump of focus from property input field to value input field.

Acceptance Criteria
Given I am adding/editing statement on an entity
When I enter an exact property label in the property field
Then the focus should not automatically jump to the value input field

Technical Todos
The following patches also cover updating browser tests accordingly, which required a change to wdio-wikibase lib. The last patch (wikibase one) can be reviewed for the context of this change first, if needed, but the patches will need to be merged in the given order.

Details

SubjectRepoBranchLines +/-
entity selector: Remove autojump of focus from property field to value fieldmediawiki/extensions/Wikibasemaster+26 -77
Select suggested property explicitlymediawiki/extensions/WikibaseLexememaster+7 -4
Customize query in gerrit

Related Objects

Event Timeline

• alaa_wmde created this task.Oct 1 2019, 11:48 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2019, 11:48 AM
• alaa_wmde triaged this task as Medium priority.Oct 1 2019, 11:48 AM
• alaa_wmde mentioned this in T172937: Cursor jumping to next field and overlapping of menus.
• alaa_wmde moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Envlh claimed this task.Oct 1 2019, 4:49 PM
Envlh added subscribers: Seb35, Envlh.

Started to work on this with @Seb35. I should be able to deliver a merge request on Saturday or Sunday.

Lydia_Pintscher subscribed.Oct 1 2019, 4:53 PM

\o/

Lea_Lacroix_WMDE subscribed.Oct 2 2019, 7:56 AM
gerritbot added a comment.Oct 6 2019, 2:07 PM

Change 541081 had a related patch set uploaded (by Envlh; owner: Envlh):
[mediawiki/extensions/Wikibase@master] entity selector: Remove autojump of focus from property field to value field

https://gerrit.wikimedia.org/r/541081

gerritbot added a project: Patch-For-Review.Oct 6 2019, 2:07 PM
Lydia_Pintscher edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Oct 6 2019, 3:44 PM

Thank you! :)

Lydia_Pintscher moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 6 2019, 3:45 PM
• alaa_wmde moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 7 2019, 1:13 PM

On its way to beta for testing

• alaa_wmde moved this task from Test (Verification) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 7 2019, 6:17 PM

Some browser tests need fixing after this change (failed CI)

• alaa_wmde claimed this task.Oct 7 2019, 8:14 PM
• alaa_wmde added a comment.Oct 7 2019, 8:32 PM

Another patch for review this depends on:

https://github.com/wmde/wdio-wikibase/pull/11

• alaa_wmde moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 7 2019, 8:32 PM
• alaa_wmde updated the task description. (Show Details)Oct 7 2019, 8:50 PM
gerritbot added a comment.Oct 7 2019, 9:43 PM

Change 541379 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/extensions/WikibaseLexeme@master] [DNM] Select suggested property explicitly

https://gerrit.wikimedia.org/r/541379

• alaa_wmde updated the task description. (Show Details)Oct 7 2019, 9:52 PM
• alaa_wmde updated the task description. (Show Details)Oct 7 2019, 9:54 PM
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Oct 10 2019, 12:29 PM
Addshore subscribed.Oct 28 2019, 1:10 PM

I have just merged https://github.com/wmde/wdio-wikibase/pull/11

• alaa_wmde updated the task description. (Show Details)Oct 29 2019, 5:56 PM
• alaa_wmde updated the task description. (Show Details)
• alaa_wmde updated the task description. (Show Details)Oct 30 2019, 10:31 AM
• alaa_wmde moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 30 2019, 10:36 AM
• alaa_wmde moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 30 2019, 10:45 AM
gerritbot added a comment.Nov 7 2019, 9:32 AM

Change 541379 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Select suggested property explicitly

https://gerrit.wikimedia.org/r/541379

gerritbot added a comment.Nov 7 2019, 9:32 AM

Change 541081 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] entity selector: Remove autojump of focus from property field to value field

https://gerrit.wikimedia.org/r/541081

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 7 2019, 10:00 AM
• alaa_wmde updated the task description. (Show Details)Nov 7 2019, 10:33 AM
• alaa_wmde moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Woohoo finally this can be tested on beta

• alaa_wmde removed • alaa_wmde as the assignee of this task.Nov 12 2019, 2:46 PM
Lydia_Pintscher closed this task as Resolved.Nov 12 2019, 9:30 PM
Lydia_Pintscher claimed this task.
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

\o/

Lea_Lacroix_WMDE moved this task from Done to Needs Announcement on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 14 2019, 10:58 AM

I'll make an announcement for this, to make sure that people currently working with the autojump understand why we did this.
When will it be deployed live?

Lydia_Pintscher added a comment.Nov 16 2019, 2:43 PM

Should be on Wednesday.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL