WANObjectCache fails to store the `null` value
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	Oct 4 2019, 12:50 AM

Description

Noticed this in a tightening of PHPUnit strictness that the test case for set('x', null) actually fails. It was passing previously by accident due to loose comparisons tolerating the returned false value as being "similar enough".

The bottom value for object cache is false, but null is generally allowed.

The tests fails when using WANObjectCache wrapping HashBagOStuff, but pass in isolation with just HashBagOStuff.

Details

	Subject	Repo	Branch	Lines +/-
	objectcache: fix storage of null values in WANObjectCache	mediawiki/core	master	+7 -4

Customize query in gerrit

Event Timeline

Krinkle created this task.Oct 4 2019, 12:50 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2019, 12:50 AM

Found via https://gerrit.wikimedia.org/r/#/c/540735/.

Krinkle moved this task from General to libs/objectcache on the MediaWiki-libs-BagOStuff board.Oct 9 2019, 7:42 PM

Tagging CPT as this would is a fairly small bug that makes a good example to use to get familiar with WANCache internals, transferring knowledge, and pair programming.

Anomie moved this task from Inbox to Triage Meeting Inbox on the Platform Engineering board.Nov 26 2019, 9:26 PM

@WDoranWMF please decide if you would like somebody on the team to participate in this knowledge transfer.

Change 562656 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] objectcache: fix storage of null values in WANObjectCache

https://gerrit.wikimedia.org/r/562656

gerritbot added a project: Patch-For-Review.Jan 7 2020, 11:54 PM

Krinkle assigned this task to aaron.Jan 24 2020, 10:49 PM

Krinkle edited projects, added Performance-Team; removed Platform Engineering.

Krinkle moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.

Change 562656 merged by jenkins-bot:
[mediawiki/core@master] objectcache: fix storage of null values in WANObjectCache

https://gerrit.wikimedia.org/r/562656

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 29 2020, 5:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 29 2020, 5:10 AM

Krinkle closed this task as Resolved.Jan 29 2020, 4:18 PM