Titles with non-DB-normalised keys are not recognised
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Seb35
	Oct 5 2019, 8:35 PM

Description

In extension Nuke, the pattern field must be currently written with the DB-normalised key (as found in the recentchanges table) in the SQL LIKE mini-language.

For instance:

"spam %" will never catch any title, it can be "Spam\_%" or "Spam\__" (with default MW settings, specifically the first-letter capitalisation) to catch titles like "Spam 1" but not "SpamT1"
"Spam_%" catches titles "Spam 1", "SpamT1", "Spam1"

It would be easier to use MediaWiki-displayed titles instead of MediaWiki-DB-encoded titles, by using MediaWiki title normalisation, but still use the two SQL wildcard "%" and "_". In particular, it would be easier to differentiate the space (encoded as "_" by MediaWiki and encoded as "\_" in SQL LIKE) and the SQL 1-character wildcard (encoded as "_" in SQL LIKE).

See also T7835 (the original feature request) and T37783.

Details

	Subject	Repo	Branch	Lines +/-
	Cleanup code comment on Special:Nuke	mediawiki/extensions/Nuke	master	+0 -2
	Permit spaces in the SQL LIKE pattern	mediawiki/extensions/Nuke	master	+84 -4

Customize query in gerrit

Related Objects

Mentioned In: T68447: Allow providing a (manual) list of titles to delete on [[Special:Nuke]]
T361258: [Hackathon 2024] Improve the Nuke extension
Mentioned Here: T364144: Replace SQL LIKE matching for Nuke
T7835: Remove articles matching SQL LIKE pattern
T37783: "Pattern" field is too user unfriendly

Event Timeline

Seb35 created this task.Oct 5 2019, 8:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2019, 8:35 PM

Change 541077 had a related patch set uploaded (by Seb35; owner: Seb35):
[mediawiki/extensions/Nuke@master] Use MediaWiki’s Title class to parse and normalise the SQL LIKE pattern

https://gerrit.wikimedia.org/r/541077

gerritbot added a project: Patch-For-Review.Oct 6 2019, 11:38 AM

Issue raised multiple times on the talk page:

Using wildcard search (January 2015),
How does it work? (January 2017),
Issues with spaces in page name pattern (June 2018).

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Sep 17 2023, 2:50 PM

@Seb35: Per emails from Sep18 and Oct20 and https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup , I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action... → Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

• Samwalton9-WMF mentioned this in T361258: [Hackathon 2024] Improve the Nuke extension.May 3 2024, 5:24 AM

Chlod claimed this task.May 3 2024, 1:48 PM

Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptMay 3 2024, 1:48 PM

I've got the previous patch working on the latest commit of Nuke (as part of Wikimedia-Hackathon-2024), i.e. converted it to use the new QueryBuilder system. Lots of reusable stuff, so might as well just improve that patch rather than create a new one. Uploaded it under the same patch (541077).

Got this checked by a DBA to make sure it's safe, see T364144 for the general sentiment.

@Ladsgroup Per the above do you think this ticket should be declined outright in favour of T364144: Replace SQL LIKE matching for Nuke?

In T234726#9768165, @Samwalton9-WMF wrote:

@Ladsgroup Per the above do you think this ticket should be declined outright in favour of T364144: Replace SQL LIKE matching for Nuke?

They are not really mutually exclusive. Both should be done ^_^

Bad news: the way the filter works is inherently incompatible with QueryBuilder.

Without mucking around with internal methods, there's no way to properly handle the "pattern" without escaping the percent (which would mean % is matched literally) or not escaping _ (which would mean spaces won't work anyway). The tests also checked if one can input \% to match % literally in page title, which assumes that the escape character is \, but it's actually a backtick. To my knowledge (and the knowledge of the people beside me on the Hackathon desk), there's no way to insert raw SQL which could do a LIKE without the ESCAPE clause.

Giving up on this in favor of T364144. @Zabe restored patchset 8 at my request to restore the patch to its former condition.

Found a temporary solution. This should work for now until T364144 finally gets worked on.

In T234726#9770836, @Chlod wrote:

Found a temporary solution. This should work for now until T364144 finally gets worked on.

I tested the new patch in a bunch of different ways and it behaves in the way I expect!

Scardenasmolinar edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.May 4 2024, 2:44 PM

Scardenasmolinar moved this task from Ready to Done on the Moderator-Tools-Team (Kanban) board.

Change #541077 merged by jenkins-bot:

[mediawiki/extensions/Nuke@master] Permit spaces in the SQL LIKE pattern

https://gerrit.wikimedia.org/r/541077

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).May 4 2024, 4:00 PM

Change #1027220 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/Nuke@master] Cleanup code comment on Special:Nuke

https://gerrit.wikimedia.org/r/1027220

gerritbot added a project: Patch-For-Review.May 4 2024, 5:08 PM

Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptMay 4 2024, 5:08 PM

• Samwalton9-WMF mentioned this in T68447: Allow providing a (manual) list of titles to delete on [[Special:Nuke]].May 5 2024, 8:56 AM

Change #1027220 merged by jenkins-bot: