Page MenuHomePhabricator
Create Task
Maniphest T235023

Selenium test "User should be able to log in @daily" fails with Quibble 0.0.37
Closed, ResolvedPublic
Actions

Description

Quibble 0.0.37 changed some MediaWiki settings, notably setting $wgSecretKey.

The Selenium test User should be able to log in @daily now fails. After login and heading back to the Main_Page, the user is not logged in.

Can't call getText on element with selector "#pt-userpage" because element wasn't found

Can be reproduced with docker-registry.wikimedia.org/releng/quibble-stretch-php72:0.0.37 --run=selenium. And I have the same issue when running Quibble directly.

The test is straight forward:

tests/selenium/specs/user.js

it( 'should be able to log in @daily', function () {
    // create
    browser.call( async () => {
        await Api.createAccount( bot, username, password );
    } );

    // log in
    UserLoginPage.login( username, password );

    // check
    assert.strictEqual( UserLoginPage.userPage.getText(), username );
} );

I suspect it is related to the introduction of $wgSecretKey :-\

Details

SubjectRepoBranchLines +/-
Release Quibble 0.0.39integration/quibblemaster+8 -2
docker: bump quibble to 0.0.38integration/configmaster+48 -0
Fix $wgServer to match MW_SERVERintegration/quibblemaster+8 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Oct 9 2019, 9:14 AM
hashar added a comment.Oct 9 2019, 9:23 AM

To track the root cause I have setup a dummy environment:

quibble --skip=all

Then deleted specs in tests/selenium/specs and amending user.js to just keep the failing test. I then ran git bisect against 0.0.35..0.037 using:

rm src/LocalSettings.php; quibble --skip-zuul --skip-deps --run=selenium

Which eventually leads to 2fbe953ef071885084d40104624e3f4cfb05c81b for T233140

2fbe953ef071885084d40104624e3f4cfb05c81b is the first bad commit
commit 2fbe953ef071885084d40104624e3f4cfb05c81b
Author: Antoine Musso <hashar@free.fr>
Date:   Mon Sep 23 11:33:01 2019 +0200

    Set $wgServer when installing
    
    CLI can not automatically detect the port the server listens on and thus
    need to be hinted by setting $wgServer. MediaWiki is also going to drop
    support for run-time detection of $wgServer (T232931).
    
    install.php is a maintenance script and as such supports '--server'
    which is then recognized to set $wgServer in the generated
    LocalSettings.php (confirmed up to REL1_31).
    
    Bug: T233140
    Change-Id: I5a3388cf8092d2a9baebfada813340cb99fc499d
hashar added a comment.Oct 9 2019, 9:52 AM

Grabbed the mw-debug-www.log for two sessions, I have edited them to remove some variance making diffs slightly easier.

Good:

mw-debug-www.log149 KBDownload

Bad:
mw-debug-www-bad.log144 KBDownload

The Start request POST /index.php/Special:UserLogin are identical with:

HOST: 127.0.0.1:9412
ORIGIN: http://127.0.0.1:9412

With session cookie etc.

Then the test heads back to the Main_Page which is where we have a difference:

--- log/mw-debug-www.log
+++ log-bad/mw-debug-www.log
 Start request GET /index.php/Main_Page
 HTTP HEADERS:
-HOST: 127.0.0.1:9412
+HOST: localhost:9412
 CONNECTION: keep-alive
 CACHE-CONTROL: max-age=0
 UPGRADE-INSECURE-REQUESTS: 1
 USER-AGENT: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.100 Safari/537.36
 SEC-FETCH-MODE: navigate
 SEC-FETCH-USER: ?1
 ACCEPT: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3
-SEC-FETCH-SITE: same-origin
+SEC-FETCH-SITE: cross-site
 REFERER: http://127.0.0.1:9412//index.php?title=Special%3AUserLogin
 ACCEPT-ENCODING: gzip, deflate, br
 ACCEPT-LANGUAGE: en-US,en;q=0.9
-COOKIE: wikidb_session=SESSION_5; wikidbUserID=2; wikidbUserName=User-0.11630502306183077-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n
 [localisation] LocalisationCache: using store LCStoreStaticArray
+[session] SessionBackend "ggjb0m8ithihk6q8tf5kf7r4peo90fqe" is unsaved, marking dirty in constructor
+[session] SessionBackend "ggjb0m8ithihk6q8tf5kf7r4peo90fqe" save: dataDirty=1 metaDirty=1 forcePersist=0
+[cookie] already deleted setcookie: "wikidb_session", "", "1539077208", "/", "", "", "1"
+[cookie] already deleted setcookie: "wikidbUserID", "", "1539077208", "/", "", "", "1"
+[cookie] already deleted setcookie: "wikidbToken", "", "1539077208", "/", "", "", "1"
+[cookie] already deleted setcookie: "forceHTTPS", "", "1539077208", "/", "", "", "1"

In both logs, the requests are made to 127.0.0.1:9412. But in the bad case, $wgServer is set to localhos tand Special:UserLogin redirects the user to localhost:9412. sec-fetch-site thus change from same-origin to cross-site, the cookie that has been set for 127.0.0.1 is not recognized on localhost and a new session (anonymous) is created.

That is caused by install.php being invoked with: --server=http://localhost:9412 and the test suite being pointed to 127.0.0.1 by MW_SERVER=127.0.0.1:9412.

Thus Quibble should constantly use the same server.

hashar mentioned this in T233140: Quibble should not rely on dynamically detecting the value of $wgServer.Oct 9 2019, 9:53 AM
hashar added a parent task: T233140: Quibble should not rely on dynamically detecting the value of $wgServer.
gerritbot added a comment.Oct 9 2019, 9:59 AM

Change 541769 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/quibble@master] Fix $wgServer to match MW_SERVER

https://gerrit.wikimedia.org/r/541769

gerritbot added a project: Patch-For-Review.Oct 9 2019, 9:59 AM
gerritbot added a comment.Oct 9 2019, 10:09 AM

Change 541769 merged by jenkins-bot:
[integration/quibble@master] Fix $wgServer to match MW_SERVER

https://gerrit.wikimedia.org/r/541769

Maintenance_bot removed a project: Patch-For-Review.Oct 9 2019, 10:10 AM
gerritbot added a comment.Oct 9 2019, 1:01 PM

Change 541811 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] docker: bump quibble to 0.0.38

https://gerrit.wikimedia.org/r/541811

gerritbot added a project: Patch-For-Review.Oct 9 2019, 1:01 PM
hashar closed this task as Resolved.Oct 9 2019, 1:02 PM
hashar claimed this task.

Fixed in Quibble 0.0.38.

gerritbot added a comment.Oct 9 2019, 1:03 PM

Change 541811 merged by jenkins-bot:
[integration/config@master] docker: bump quibble to 0.0.38

https://gerrit.wikimedia.org/r/541811

Maintenance_bot removed a project: Patch-For-Review.Oct 9 2019, 1:10 PM
Stashbot added a comment.Oct 9 2019, 5:52 PM

Mentioned in SAL (#wikimedia-releng) [2019-10-09T17:52:12Z] <hashar> Tagged Quibble 0.0.38 @ d22e0f55b earlier today to fix $wgServer # T235023

hashar mentioned this in T235118: Create an integration test running Quibble with mediawiki/core.Oct 9 2019, 5:55 PM
gerritbot added a comment.Oct 18 2019, 1:28 PM

Change 544192 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/quibble@master] Release Quibble 0.0.39

https://gerrit.wikimedia.org/r/544192

gerritbot added a project: Patch-For-Review.Oct 18 2019, 1:28 PM
gerritbot added a comment.Oct 18 2019, 1:38 PM

Change 544192 merged by jenkins-bot:
[integration/quibble@master] Release Quibble 0.0.39

https://gerrit.wikimedia.org/r/544192

Stashbot added a comment.Oct 18 2019, 1:44 PM

Mentioned in SAL (#wikimedia-releng) [2019-10-18T13:44:15Z] <hashar> Tag Quibble 0.0.39 @ a1e0b85 # T235023 T235564

Stashbot mentioned this in T235564: Implement Integration Tests for Existing iOS Endpoints.Oct 18 2019, 1:44 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 18 2019, 2:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits