Add dirty state getter to store
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Oct 9 2019, 10:44 AM

Description

A getter that compares the current state against the “shadow state” (T235052).

Details

	Subject	Repo	Branch	Lines +/-
	bridge: Add dirty state getter	mediawiki/extensions/Wikibase	master	+1 K -91

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lydia_Pintscher	T230342 enable/disable save button depending on Bridge state
		Resolved		• Matthias_Geisler_WMDE	T235054 Add dirty state getter to store

Event Timeline

Lucas_Werkmeister_WMDE created this task.Oct 9 2019, 10:44 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2019, 10:44 AM

Lucas_Werkmeister_WMDE mentioned this in T235056: Make app change button attributes depending on dirty state of store.Oct 9 2019, 10:44 AM

• Matthias_Geisler_WMDE claimed this task.Oct 16 2019, 4:21 PM

• Matthias_Geisler_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-7 board.Oct 16 2019, 4:53 PM

Change 543498 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Add dirty state getter

https://gerrit.wikimedia.org/r/543498

gerritbot added a project: Patch-For-Review.Oct 16 2019, 4:55 PM

• Matthias_Geisler_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-7 board.Oct 16 2019, 5:03 PM

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Oct 18 2019, 5:29 PM

@Lucas_Werkmeister_WMDE figured out that the order of the index is not preserved, therefore the patch using now a deep compare.

• Matthias_Geisler_WMDE mentioned this in T235052: Save original revision data in store.Oct 21 2019, 10:24 AM

Change 543498 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Add dirty state getter

https://gerrit.wikimedia.org/r/543498

Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 21 2019, 4:38 PM

Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-7 board.

Maintenance_bot removed a project: Patch-For-Review.Oct 21 2019, 5:10 PM