Using the getter from T235054.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Lydia_Pintscher | T230342 enable/disable save button depending on Bridge state | |||
| Resolved | Michael | T235056 Make app change button attributes depending on dirty state of store |
Event Timeline
Comment Actions
I have to leave now, but the core of this task is pretty simple:
diff --git a/client/data-bridge/src/presentation/App.vue b/client/data-bridge/src/presentation/App.vue index abb3f9225..828c208f4 100644 --- a/client/data-bridge/src/presentation/App.vue +++ b/client/data-bridge/src/presentation/App.vue @@ -7,6 +7,7 @@ type="primaryProgressive" :squary="true" @click="saveAndClose" + :disabled="!isTargetPropertyModified" /> </template> <template v-slot:safeAction> @@ -55,6 +56,9 @@ export default class App extends Vue { @Getter( 'applicationStatus' ) public applicationStatus!: ApplicationStatus; + @Getter( 'isTargetPropertyModified' ) + public isTargetPropertyModified!: boolean; + public get isInit() { return this.applicationStatus === ApplicationStatus.READY; }
(Though isTargetPropertyModified will probably be renamed.) Feel free to steal the task from me and continue working on it.
Comment Actions
Change 545292 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: wire up initially disabled save button
Comment Actions
Change 545433 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: extend e2e in terms of disabled
Comment Actions
Change 545292 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: wire up initially disabled save button
Comment Actions
Change 545433 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: extend e2e in terms of disabled