Page MenuHomePhabricator

[Bug] File Page statement panels are not behaving properly in master branch and production
Closed, ResolvedPublicBUG REPORT

Description

User story: N/A

We have this:

In the current master branch and on production, the “edit state” has no qualifier link when editing a statement that currently has no qualifiers:

also, the "read" state has a qualifier link that does not work (easy to reproduce this behavior by canceling an edit).

Also, panels that have existing statements with qualifiers, in read mode, have enabled trash icons for some statements, but not others

We want this:

Screenshots (if possible):
see above

Acceptance Criteria:

  • Statement panels have working Add Qualifier links in edit mode
  • Statement panels don't have Add Qualifier links in read mode
  • Statement panels don't have trash can icons in read mode

During development, please test the following:

  • Test this feature while logged in AND logged out
  • Test this feature on at least one mobile browser
  • Test that this feature works on the file page AND the Add Data step on UploadWizard (if applicable, some features only exist on one or the other)

Details

Related Gerrit Patches:
mediawiki/extensions/WikibaseMediaInfo : wmf/1.35.0-wmf.2Keep track of assigned nodes in both old & new DOM
mediawiki/extensions/WikibaseMediaInfo : masterKeep track of assigned nodes in both old & new DOM

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2019, 12:22 AM
Ramsey-WMF triaged this task as High priority.Oct 11 2019, 12:23 AM
Ramsey-WMF added subscribers: matthiasmullie, egardner.

Additional info:

matthiasmullie added a subscriber: Cparle.

Change 542565 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Keep track of assigned nodes in both old & new DOM

https://gerrit.wikimedia.org/r/542565

Change 542565 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Keep track of assigned nodes in both old & new DOM

https://gerrit.wikimedia.org/r/542565

Change 543458 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.35.0-wmf.2] Keep track of assigned nodes in both old & new DOM

https://gerrit.wikimedia.org/r/543458

Change 543458 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.35.0-wmf.2] Keep track of assigned nodes in both old & new DOM

https://gerrit.wikimedia.org/r/543458

Mentioned in SAL (#wikimedia-operations) [2019-10-17T11:08:03Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.2/extensions/WikibaseMediaInfo: SWAT: 5a67011: Keep track of assigned nodes in both old & new DOM (T235236) (duration: 01m 03s)

Ramsey-WMF closed this task as Resolved.Wed, Oct 23, 11:30 PM

Tested on production and works as normal once again.