Page MenuHomePhabricator
Create Task
Maniphest T235681

[AMC] Toolbar on User talk page should match toolbar on User page
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
• nray
Authored By
• alexhollender_WMF
Oct 16 2019, 5:20 PM
Tags
Referenced Files
F31467998: en.m.wikipedia.org_wiki_User_Inimesh(iPhone 6_7_8).png
Dec 10 2019, 11:34 PM
F31467997: en.m.wikipedia.org_wiki_User_talk_Inimesh(iPhone 6_7_8).png
Dec 10 2019, 11:34 PM
F30764670: en.m.wikipedia.org_wiki_User_Red_Director(iPhone 6_7_8).png
Oct 16 2019, 5:20 PM
F30764669: en.m.wikipedia.org_wiki_User_talk_Red_Director(iPhone 6_7_8).png
Oct 16 2019, 5:20 PM
Subscribers
Aklapper
• alexhollender_WMF
Edtadros
Jdlrobson
Masumrezarock100
• nray
ovasileva
Tokens
"Love" token, awarded by Masumrezarock100.

Description

Description

As pointed out in this comment currently the toolbar on a User talk page does not match the toolbar on the User page. The toolbar should be the same in both cases (including the contents of the overflow menu).

user pageuser talk page
en.m.wikipedia.org_wiki_User_Inimesh(iPhone 6_7_8).png (1×750 px, 186 KB)
en.m.wikipedia.org_wiki_User_talk_Inimesh(iPhone 6_7_8).png (1×750 px, 123 KB)

Changes needed to the toolbar on the User talk page:

  • move Language icon into overflow menu
  • add Contributions icon to Toolbar
  • add User Groups and Logs to overflow menu

Developer notes

Code for the UserNamespaceOverflowBuilder is invoked when $userPageHelper->isUserPage() is true. It will also need to kick in for talk pages:

https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/includes/ServiceWiring.php#L96

In theory nothing else should be needed but if any URLs are derived from the title this line here will need to call ->getSubjectPage( $title ) to convert a talk page title to a little:
https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/includes/ServiceWiring.php#L98

Details

SubjectRepoBranchLines +/-
Resemble AMC mode for all users on user pages & user talk pagesmediawiki/skins/MinervaNeuemaster+61 -94
Make toolbar on user talk page match toolbar on user pagemediawiki/skins/MinervaNeuemaster+31 -17
Remove $userPageHelper param from UserNamespaceOverflowBuildermediawiki/skins/MinervaNeuemaster+0 -11
Customize query in gerrit

Related Objects

Event Timeline

• alexhollender_WMF created this task.Oct 16 2019, 5:20 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptOct 16 2019, 5:20 PM
ovasileva triaged this task as Medium priority.Oct 21 2019, 10:30 AM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-2019-20-Q2); removed Web-Team-Backlog.
Masumrezarock100 moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 21 2019, 10:57 AM
Jdlrobson moved this task from Upcoming to Needs Analysis on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 21 2019, 5:32 PM
Jdlrobson subscribed.

@Masumrezarock100 I've moved this task back to needs analysis as no analysis has been done yet.

To explain our process a little more - "needs analysis" means a developer in our team needs to analyse a task to uncover risk. We update the task with "developer notes" to explain. If a task is in the sprint board the team is committed to working on the task so moving to upcoming won't make it done any quicker (in fact might slow it down as we might estimate it/work on it prematurely without knowing its risks!).

FYI https://www.mediawiki.org/wiki/Reading/Web/Phabricator#Sprint_columns explains the columns and how we use them. Let me know if anything is not clear or there is anything we can do to improve discovery of that page! Thanks for caring!

Masumrezarock100 added a comment.EditedOct 21 2019, 6:13 PM

@Jdlrobson Your explanations make sense to me. I thought this task didn't need any analysis and thanks for the link, it is very helpful. :) Sorry for the trouble I have caused.

Jdlrobson added a comment.Oct 21 2019, 6:26 PM
In T235681#5592695, @Masumrezarock100 wrote:

@Jdlrobson Your explanations make sense to me. I thought this task didn't need any analysis and thanks for the link, it is very helpful. :) Sorry for the trouble I have caused.

No trouble. I really appreciate having your voice on Phabricator and representing editors!

Jdlrobson updated the task description. (Show Details)Oct 22 2019, 9:43 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.
Masumrezarock100 awarded a token.EditedOct 22 2019, 9:58 PM
Masumrezarock100 rescinded a token.
Masumrezarock100 awarded a token.
Masumrezarock100 rescinded a token.
Masumrezarock100 awarded a token.

Just wanted to aware a love token.:) But for some reason, I kept clicking on the wrong icon.

ovasileva set the point value for this task to 3.Oct 23 2019, 4:30 PM
ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Nov 5 2019, 7:50 PM
• nray mentioned this in T232653: Updates to user pages for all users.Dec 10 2019, 9:20 PM
• alexhollender_WMF updated the task description. (Show Details)Dec 10 2019, 11:34 PM
• alexhollender_WMF added a subscriber: • nray.

as @nray pointed out it might make sense to fix this as part of T232653.

• alexhollender_WMF updated the task description. (Show Details)Dec 10 2019, 11:35 PM
gerritbot added a comment.Dec 10 2019, 11:51 PM

Change 556294 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/skins/MinervaNeue@master] Make toolbar on user talk page match toolbar on user page

https://gerrit.wikimedia.org/r/556294

gerritbot added a project: Patch-For-Review.Dec 10 2019, 11:51 PM
• nray claimed this task.Dec 10 2019, 11:53 PM
• nray moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.
• nray added a comment.Dec 10 2019, 11:56 PM

I've moved this ticket to doing as the work for T232653 is closely related to this work considering the contributions icon should be part of the toolbar on both user pages and user talk pages for logged in users (https://phabricator.wikimedia.org/T232653#5730229)

gerritbot added a comment.Dec 12 2019, 12:34 AM

Change 556508 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/skins/MinervaNeue@master] Remove $userPageHelper param from UserNamespaceOverflowBuilder

https://gerrit.wikimedia.org/r/556508

• nray moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Dec 12 2019, 12:35 AM
gerritbot added a comment.Dec 12 2019, 11:26 PM

Change 556223 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/skins/MinervaNeue@master] Resemble AMC mode for all users on user pages & user talk pages

https://gerrit.wikimedia.org/r/556223

gerritbot added a comment.Dec 13 2019, 12:31 AM

Change 556294 abandoned by Nray:
Make toolbar on user talk page match toolbar on user page

Reason:
This has been merged into I940e5cf7638ff38686eeca3d41554b8a22d35615 to reflect the new AC with that ticket

https://gerrit.wikimedia.org/r/556294

gerritbot added a comment.Dec 13 2019, 12:31 AM

Change 556508 abandoned by Nray:
Remove $userPageHelper param from UserNamespaceOverflowBuilder

Reason:
Squashed into I940e5cf7638ff38686eeca3d41554b8a22d35615

https://gerrit.wikimedia.org/r/556508

gerritbot added a comment.Dec 13 2019, 10:48 PM

Change 556223 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Resemble AMC mode for all users on user pages & user talk pages

https://gerrit.wikimedia.org/r/556223

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.11; 2019-12-17).Dec 13 2019, 11:00 PM
Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Dec 13 2019, 11:15 PM
• nray added a comment.EditedDec 16 2019, 5:57 PM

Given that the AC listed in this ticket is part of T232653 (which also has the necessary QA steps), I propose we close out this ticket

Update: In standup, it was proposed to close this one out when T232653 is closed out. @Edtadros there are no qa steps for this ticket. The QA steps from T232653 will cover this ticket.

• nray added a subscriber: Edtadros.Dec 16 2019, 6:20 PM
Jdlrobson moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Dec 16 2019, 7:08 PM
ovasileva closed this task as Resolved.Dec 18 2019, 10:26 AM
ovasileva subscribed.

Resolving, confirmed this works in T232653#5747275

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL