Description
On user pages all users will see the "User page" and "Talk" tabs, and the Contributions icon will be part of the toolbar. Also, the toolbar on the User talk page should match the toolbar on the User page. The Uploads link is no longer available as a result of T233985.
Designs
| current non-AMC (for reference) | updated (all users) | updated user talk (all users) |
 |  |  |
Acceptance Criteria
- AMC user pages remains as is
- All users on user pages/user talk pages see contributions icon in toolbar and "User page" and "Talk" tabs
- The toolbar on the User talk page matches the toolbar on the User page
Developer notes
Our configuration flags don't seem to work here to make this a simple change unfortunately.
The tabs feature (wgMinervaTalkAtTop) cannot be turned on on just one page - it has to be turned on everywhere. We already do this for special pages though so editing logic should be straight forward.
/**
* @param bool $hasPageActions
* @param SkinOptions $skinOptions
* @return bool
*/
private function showTalkTabs( $hasPageActions, SkinOptions $skinOptions ) {
$hasTalkTabs = $hasPageActions && !$this->isMainPageTalk;
if ( !$hasTalkTabs && $this->isSpecialPage &&
$skinOptions->get( SkinOptions::TABS_ON_SPECIALS ) ) {
$hasTalkTabs = true;
}
return $hasTalkTabs;
}Note: The upload link will be dropped. That's okay.
The contributions link is added (I think?) inside includes/menu/PageActions/ToolbarBuilder.php and possibly tied to the overflow mode.
if ( $userPageWithOveflowMode ) {
// User links are hidden when Overflow menu is visible. We want to show Contributions
// link on toolbar only when overflow is visible
$group->insertEntry( $this->createContributionsPageAction() );
}QA Steps
General Steps
- Ensure that the following items are in both toolbars and that they link to the right place:
User page:
- Watch =>
- when anon: a toast prompting you to login should appear;
- when logged in or amc: should toggle the star color
- History =>
- when anon or logged in: /wiki/Special:History/User:OVasileva_(WMF)
- when amc: /w/index.php?title=User:OVasileva_(WMF)&action=history
- Contributions => /wiki/Special:Contributions/OVasileva_(WMF);
- Edit => in all cases editor overlay should open (in anon it will warn you that you are not logged in)
- Overflow menu
- Languages button
- when testing mediawiki.org, the language button will be absent due to 'wgMinervaAlwaysShowLanguageButton` config
- User groups => /wiki/Special:UserRights/OVasileva_(WMF)
- Logs => /wiki/Special:Log/OVasileva_(WMF)
- Page information => /w/index.php?title=User:OVasileva_(WMF)&action=info
- Permanent Link => /w/index.php?title=User:OVasileva_(WMF)&oldid=2708261
- What links here => /wiki/Special:WhatLinksHere/User:OVasileva_(WMF)
- Languages button
User talk page:
- Watch =>
- when anon: a toast prompting you to login should appear;
- when logged in or amc: should toggle the star color
- History =>
- when anon or logged in: /wiki/Special:History/User_Talk:OVasileva_(WMF)
- when amc: /w/index.php?title=User_talk:OVasileva_(WMF)&action=history
- Contributions => /wiki/Special:Contributions/OVasileva_(WMF)
- Edit => in all cases editor overlay should open (in anon it will warn you that you are not logged in)
- Overflow menu
- Languages button
- when testing mediawiki.org, the language button will be absent due to 'wgMinervaAlwaysShowLanguageButton` config
- User groups => /wiki/Special:UserRights/OVasileva_(WMF)
- Logs => /wiki/Special:Log/OVasileva_(WMF)
- Page information => /w/index.php?title=User_talk:OVasileva_(WMF)&action=info
- Permanent Link => /w/index.php?title=User_talk:OVasileva_(WMF)&oldid=3555778
- What links here => /wiki/Special:WhatLinksHere/User_talk:OVasileva_(WMF)
- Languages button
When Anon
- Log out and visit https://m.mediawiki.org/wiki/User:OVasileva_(WMF) in a new tab
- Open up another tab and visit https://m.mediawiki.org/wiki/User_talk:OVasileva_(WMF)
- Do general Steps
When logged in
- Log in with AMC off and visit https://m.mediawiki.org/wiki/User:OVasileva_(WMF) in a new tab
- Open up another tab and visit https://m.mediawiki.org/wiki/User_talk:OVasileva_(WMF)
- Do general Steps
When AMC turned on
- Log in with AMC on and visit https://m.mediawiki.org/wiki/User:OVasileva_(WMF) in a new tab
- Open up another tab and visit https://m.mediawiki.org/wiki/User_talk:OVasileva_(WMF)
- Do general Steps
QA results
- Beta cluster - ✅ PASS - T232653#5747275
- Production mediawiki - ✅ PASS - T232653#5749979
- Production hewiki - ✅ PASS - T232653#5753038
- Production enwiki - ✅ PASS - T232653#5755178
