Page MenuHomePhabricator

Add article and discussion tabs to all logged-in users on mobile
Closed, ResolvedPublic2 Estimated Story Points

Assigned To
Authored By
ovasileva
Sep 11 2019, 11:09 AM
Referenced Files
F31483003: T232594-2ben.png
Dec 19 2019, 8:29 PM
F31482993: T232594-1en.png
Dec 19 2019, 8:29 PM
F31483014: T232594-4en.png
Dec 19 2019, 8:29 PM
F31482998: T232594-3en.png
Dec 19 2019, 8:29 PM
F31482996: T232594-2en.png
Dec 19 2019, 8:29 PM
F31480067: T232594-5.png
Dec 18 2019, 6:55 AM
F31480080: T232594-1.png
Dec 18 2019, 6:55 AM
F31480092: T232594-3.png
Dec 18 2019, 6:55 AM

Description

User Story

As a new editor, I would like easy access to the talk pages of articles (and pages in other namespaces) so that I can enter into discussions on the details of the article

Acceptance criteria

  • Add talk tabs for all logged-in users

Developer notes

We cannot enable this using a config change to wgMinervaTalkAtTop in current form.
We have talked about making the FeatureManager accept a loggedin state to make these changes easier in future.

Otherwise we can simply update the setMinervaSkinOption to make use of the User on the skin instance.

				SkinOptions::TALK_AT_TOP => $featureManager->isFeatureAvailableForCurrentUser(
					'MinervaTalkAtTop'
				) || $skin->getUser()->isLoggedIn(),

QA Steps

  1. go to beta cluster as anon user
  2. go to any article page and check that the talk/discussion tabs are not visible
  3. log in as test user
  4. redo step two, but this time verify that talk/discussion tabs are visible
  5. verify that opting into AMC mode keeps tabs visible

QA Results

QA results

Event Timeline

ovasileva set the point value for this task to 2.Oct 1 2019, 4:22 PM

Change 540378 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Introduce new 'loggedin' mode

https://gerrit.wikimedia.org/r/540378

Change 549190 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Provide an AudienceMode to limit certain features to given audience

https://gerrit.wikimedia.org/r/549190

@ovasileva just to confirm, we want to enable both this task and T232652: Add History to article toolbar for all logged-in users on all wikis/projects. We're trying to decide on the best direction and we're considering two options:

  • adding a loggedin mode, then these feature will be available to all logged_in users
  • remove the feature flags, and make those two features an integral part of the MobileFrontend/Minerva.

If we decide to go with the latter, it means there will be no possibility to remove history link/tabs on some wikis. All wikis/projects gets the same treatment.

@ovasileva just to confirm, we want to enable both this task and T232652: Add History to article toolbar for all logged-in users on all wikis/projects. We're trying to decide on the best direction and we're considering two options:

  • adding a loggedin mode, then these feature will be available to all logged_in users
  • remove the feature flags, and make those two features an integral part of the MobileFrontend/Minerva.

If we decide to go with the latter, it means there will be no possibility to remove history link/tabs on some wikis. All wikis/projects gets the same treatment.

To confirm - the latter would still mean that only logged-in users would view the changes? If so, that's fine - we don't plan on having separate configurations per wiki

To confirm - the latter would still mean that only logged-in users would view the changes? If so, that's fine - we don't plan on having separate configurations per wiki

Yes, only logged-in users will see the changes.

ovasileva raised the priority of this task from Medium to High.Dec 10 2019, 1:33 PM

Change 549190 abandoned by Pmiazga:
Provide an AudienceMode to limit certain features to given audience

Reason:
it was POC, we don't need it now, there is no need to go that direction yet

https://gerrit.wikimedia.org/r/549190

Change 540378 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Introduce new 'loggedin' mode

https://gerrit.wikimedia.org/r/540378

Change 556439 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[operations/mediawiki-config@master] Enable Article and Discussion tabs for all logged-in users

https://gerrit.wikimedia.org/r/556439

Change 556439 abandoned by Pmiazga:
Enable Article and Discussion tabs for all logged-in users

Reason:
decided to update the skin.json to keep the experience consistent between 3rd party installs and prod config.

https://gerrit.wikimedia.org/r/556439

Change 557100 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/skins/MinervaNeue@master] Add History icon and Article/Talk tabs to default loggedin experience

https://gerrit.wikimedia.org/r/557100

Change 557100 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Add History icon and Article/Talk tabs to default loggedin experience

https://gerrit.wikimedia.org/r/557100

pmiazga updated the task description. (Show Details)
QA Results - beta cluster - passed

tested on: chrome desktop 79.0.3945.79, chrome mobile 78.0.3904.108 Android 9

  1. go to beta cluster as anon user
  2. go to any article page and check that the talk/discussion tabs are not visible

Screen Shot 2019-12-17 at 11.38.59 AM.png (954×2 px, 210 KB)

Screenshot_2019-12-17-11-42-27-503_com.android.chrome.jpg (2×1 px, 235 KB)

  1. log in as test user
  2. redo step two, but this time verify that talk/discussion tabs are visible

Screen Shot 2019-12-17 at 11.40.09 AM.png (1×2 px, 233 KB)

Screenshot_2019-12-17-11-43-42-834_com.android.chrome.jpg (2×1 px, 233 KB)

  1. verify that the talk page opens

Screenshot_2019-12-17-12-00-54-160_com.android.chrome.jpg (2×1 px, 106 KB)

  1. verify that opting into AMC mode keeps tabs visible

Screen Shot 2019-12-17 at 11.40.58 AM.png (740×2 px, 216 KB)

Screenshot_2019-12-17-11-43-19-307_com.android.chrome.jpg (2×1 px, 226 KB)

  1. verify that the talk page opens

Screenshot_2019-12-17-12-00-54-160_com.android.chrome.jpg (2×1 px, 106 KB)

ovasileva updated the task description. (Show Details)
ovasileva updated the task description. (Show Details)
QA Results - Production Mediawiki - ✅ PASS

tested on: chrome desktop 79.0.3945.79, iPhone x emulated

  1. go to beta cluster as anon user

✅2. go to any article page and check that the talk/discussion tabs are not visible

T232594-5.png (2×1 px, 248 KB)

  1. log in as test user

✅4. redo step two, but this time verify that talk/discussion tabs are visible

T232594-1.png (2×1 px, 262 KB)

✅5. verify that the talk page opens

T232594-2.png (2×1 px, 85 KB)

✅6. verify that opting into AMC mode keeps tabs visible

T232594-3.png (2×1 px, 254 KB)

✅7. verify that the talk page opens

T232594-3.png (2×1 px, 87 KB)

looks good on hewiki, see T232652#5753647 for screenshots

Edtadros subscribed.
QA Results - Production English Wikipedia - ✅ PASS

tested on: chrome desktop 79.0.3945.79, iPhone x emulated

  1. go to beta cluster as anon user

✅2. go to any article page and check that the talk/discussion tabs are not visible

T232594-1en.png (2×1 px, 388 KB)

  1. log in as test user

✅4. redo step two, but this time verify that talk/discussion tabs are visible

T232594-2en.png (2×1 px, 500 KB)

✅5. verify that the talk page opens

T232594-2ben.png (2×1 px, 186 KB)

✅6. verify that opting into AMC mode keeps tabs visible

T232594-3en.png (2×1 px, 227 KB)

✅7. verify that the talk page opens

T232594-4en.png (2×1 px, 195 KB)

Edtadros updated the task description. (Show Details)
Edtadros updated the task description. (Show Details)
ovasileva updated the task description. (Show Details)