Add article and discussion tabs to all logged-in users on mobile
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	ovasileva
	Sep 11 2019, 11:09 AM

Description

User Story

As a new editor, I would like easy access to the talk pages of articles (and pages in other namespaces) so that I can enter into discussions on the details of the article

Acceptance criteria

Add talk tabs for all logged-in users

Developer notes

We cannot enable this using a config change to wgMinervaTalkAtTop in current form.
We have talked about making the FeatureManager accept a loggedin state to make these changes easier in future.

Otherwise we can simply update the setMinervaSkinOption to make use of the User on the skin instance.

				SkinOptions::TALK_AT_TOP => $featureManager->isFeatureAvailableForCurrentUser(
					'MinervaTalkAtTop'
				) || $skin->getUser()->isLoggedIn(),

QA Steps

go to beta cluster as anon user
go to any article page and check that the talk/discussion tabs are not visible
log in as test user
redo step two, but this time verify that talk/discussion tabs are visible
verify that opting into AMC mode keeps tabs visible

QA Results

QA results

Beta cluster - ✅ PASS - T232594#5747220
Production mediawiki - ✅ PASS - T232594#5750253
Production hewiki - ✅ PASS - T232652#5753647
Production enwiki - ✅ PASS - T232594#5755253

Details

Subject	Repo	Branch	Lines +/-
Add History icon and Article/Talk tabs to default loggedin experience	mediawiki/skins/MinervaNeue	master	+13 -55
Enable Article and Discussion tabs for all logged-in users	operations/mediawiki-config	master	+8 -1
Introduce new 'loggedin' mode	mediawiki/extensions/MobileFrontend	master	+50 -0
Provide an AudienceMode to limit certain features to given audience	mediawiki/extensions/MobileFrontend	master	+100 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		ovasileva	T232593 [EPIC] Transfer certain AMC functionality to all logged-in users
Resolved		ovasileva	T232594 Add article and discussion tabs to all logged-in users on mobile
Resolved		Jdlrobson	T230695 Render talk page as a tab (rather than a modal)
Resolved	BUG REPORT	ovasileva	T238474 Add discussion button appears in talk pages which does not have wikitext content model
Declined		Shubham656jain	T240254 Talk page as tab, small layout fixes
Resolved		ovasileva	T243650 Regression: Mobile talk page shows links in overlay header
Resolved		• ppelberg	T278590 Review outstanding mobile talk page bugs
Declined	BUG REPORT	None	T298393 No warning about exposing IP address when using mobile "Add discussion" button

Event Timeline

ovasileva triaged this task as Medium priority.Sep 11 2019, 11:09 AM

ovasileva created this task.

ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1).

ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

ovasileva added a subtask: T230695: Render talk page as a tab (rather than a modal).

• alexhollender_WMF updated the task description. (Show Details)Sep 11 2019, 3:06 PM

ovasileva updated the task description. (Show Details)Sep 11 2019, 3:23 PM

Masumrezarock100 moved this task from Backlog to Triaged on the Advanced Mobile Contributions board.Sep 21 2019, 1:39 PM

ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1); removed Web-Team-Backlog.Sep 26 2019, 9:20 AM

Jdlrobson updated the task description. (Show Details)Sep 26 2019, 5:18 PM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

MBinder_WMF edited projects, added Web-Team-Backlog (Kanbanana-2019-20-Q2); removed Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1).Sep 30 2019, 5:20 PM

MBinder_WMF moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Sep 30 2019, 5:22 PM

ovasileva set the point value for this task to 2.Oct 1 2019, 4:22 PM

Jdlrobson moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 1 2019, 5:01 PM

ovasileva moved this task from Ready for Development to Upcoming on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 1 2019, 5:06 PM

Change 540378 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Introduce new 'loggedin' mode

https://gerrit.wikimedia.org/r/540378

gerritbot added a project: Patch-For-Review.Oct 2 2019, 11:04 AM

Jdlrobson mentioned this in T214432: It should be possible to get from user talk/uploads page to the user page.Oct 3 2019, 4:38 PM

ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Nov 6 2019, 9:55 AM

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptNov 6 2019, 9:55 AM

Change 549190 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Provide an AudienceMode to limit certain features to given audience

https://gerrit.wikimedia.org/r/549190

@ovasileva just to confirm, we want to enable both this task and T232652: Add History to article toolbar for all logged-in users on all wikis/projects. We're trying to decide on the best direction and we're considering two options:

adding a loggedin mode, then these feature will be available to all logged_in users
remove the feature flags, and make those two features an integral part of the MobileFrontend/Minerva.

If we decide to go with the latter, it means there will be no possibility to remove history link/tabs on some wikis. All wikis/projects gets the same treatment.

In T232594#5709957, @pmiazga wrote:

@ovasileva just to confirm, we want to enable both this task and T232652: Add History to article toolbar for all logged-in users on all wikis/projects. We're trying to decide on the best direction and we're considering two options:

adding a loggedin mode, then these feature will be available to all logged_in users

remove the feature flags, and make those two features an integral part of the MobileFrontend/Minerva.

If we decide to go with the latter, it means there will be no possibility to remove history link/tabs on some wikis. All wikis/projects gets the same treatment.

To confirm - the latter would still mean that only logged-in users would view the changes? If so, that's fine - we don't plan on having separate configurations per wiki

In T232594#5711599, @ovasileva wrote:

To confirm - the latter would still mean that only logged-in users would view the changes? If so, that's fine - we don't plan on having separate configurations per wiki

Yes, only logged-in users will see the changes.

ovasileva moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Dec 9 2019, 6:23 PM

pmiazga claimed this task.Dec 9 2019, 6:23 PM

ovasileva closed subtask T230695: Render talk page as a tab (rather than a modal) as Resolved.Dec 9 2019, 6:44 PM

• alexhollender_WMF mentioned this in T193044: Provide access to talk page for logged-out users on mobile web.Dec 9 2019, 8:28 PM

ovasileva raised the priority of this task from Medium to High.Dec 10 2019, 1:33 PM

Change 549190 abandoned by Pmiazga:
Provide an AudienceMode to limit certain features to given audience

Reason:
it was POC, we don't need it now, there is no need to go that direction yet

https://gerrit.wikimedia.org/r/549190

Change 540378 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Introduce new 'loggedin' mode

https://gerrit.wikimedia.org/r/540378

Maintenance_bot removed a project: Patch-For-Review.Dec 11 2019, 2:10 AM

Change 556439 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[operations/mediawiki-config@master] Enable Article and Discussion tabs for all logged-in users

https://gerrit.wikimedia.org/r/556439

gerritbot added a project: Patch-For-Review.Dec 11 2019, 6:15 PM

ovasileva mentioned this in T232653: Updates to user pages for all users.Dec 12 2019, 9:55 AM

Change 556439 abandoned by Pmiazga:
Enable Article and Discussion tabs for all logged-in users

Reason:
decided to update the skin.json to keep the experience consistent between 3rd party installs and prod config.

https://gerrit.wikimedia.org/r/556439

Change 557100 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/skins/MinervaNeue@master] Add History icon and Article/Talk tabs to default loggedin experience

https://gerrit.wikimedia.org/r/557100

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Dec 13 2019, 8:00 PM

Change 557100 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Add History icon and Article/Talk tabs to default loggedin experience

https://gerrit.wikimedia.org/r/557100

Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Dec 13 2019, 9:20 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2019, 10:10 PM

pmiazga reassigned this task from pmiazga to Edtadros.Dec 16 2019, 7:53 PM

pmiazga updated the task description. (Show Details)