Page MenuHomePhabricator

Talk page as tab, small layout fixes
Open, MediumPublic3 Estimated Story Points

Description

Description

Currently the page layout feels a bit crowded when there are no, or only one or two, "discussions". I think some small tweaks would go a long way.

currentlyupdatedupdated (empty state)
AMC-on
AMC-off

Acceptance criteria

  • add margins as in the mock above

Developer notes

Enable the talk tabs locally for development by adding to your LocalSettings.php:

$wgMinervaTalkAtTop = [ 'stable' => true ];

Event Timeline

alexhollender updated the task description. (Show Details)Dec 9 2019, 7:35 PM

Talk page messages without a section header are not shown. Are you going to address that issue too?

Talk page messages without a section header are not shown. Are you going to address that issue too?

I believe that is a separate (and more difficult) issue. Tracked here: T229725.

ovasileva triaged this task as Medium priority.Dec 11 2019, 5:13 PM
Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.
ovasileva removed ovasileva as the assignee of this task.Dec 11 2019, 5:56 PM
ovasileva added a subscriber: ovasileva.

Margin changes should be straightforward to take care of.

ovasileva updated the task description. (Show Details)Dec 11 2019, 6:25 PM
ovasileva set the point value for this task to 3.Dec 11 2019, 6:29 PM
alexhollender updated the task description. (Show Details)Jan 6 2020, 4:04 PM

Moving back to triaged but future for the time being to help focus on desktop improvements

Abhir-24 added a subscriber: Abhir-24.EditedJun 14 2020, 2:12 PM

Can anyone tell me where can I find the code files to solve the given good first task.

@Abhir-24: Hi and welcome! Good question... Advanced Mobile Contributions is listed under "Tags". The description of that tag links to https://www.mediawiki.org/wiki/Reading/Web/Advanced_mobile_contributions which has no link to any codebase (and looks quite outdated).

@Jdlrobson: Such tickets should not be tagged as good first task if tickets lack clear information where to do what, hence removing that tag for the time being.

Demian added a subscriber: Demian.EditedJun 14 2020, 5:27 PM

@Abhir-24 This is the Minerva skin with "Advanced mode" enabled in settings.
See it in operation: https://en.m.wikipedia.org/wiki/Talk:Kelenna_Azubuike
Or: https://m.mediawiki.org/wiki/Project_talk:Sandbox

The code for the skin is hosted at: https://gerrit.wikimedia.org/g/mediawiki/skins/MinervaNeue
The related HTML is #page-secondary-actions and the parent #content: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/skins/MinervaNeue/+/master/includes/Skins/skin.mustache#63
Styles in the '/resources' folder. Note these are .less files, compiled to CSS by https://github.com/wikimedia/less.php, a PHP port of http://lesscss.org

How to set up git + gerrit to download the code and contribute: https://www.mediawiki.org/wiki/Gerrit/Tutorial/tl;dr
See also: https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker
Good luck.

@akalpper @Abhir-24 this is about the MinervaNeue skin and wasn't tagged accordingly. I've fixed that now. AdvancedMobileContributions is an internal WMF tag. Sorry about that.

To reveal the tabs you'll need to add the following config to LocalSettings.php
`wgMinervaTalkAtTop = [ 'stable' => true ];

Jdlrobson updated the task description. (Show Details)Jun 14 2020, 5:35 PM

I cloned the less.php file but when I am trying to clone the code for the skin given at the link https://gerrit.wikimedia.org/g/mediawiki/skins/MinervaNeue then it is showing permission denied. I am not able to find a way to clone it so may I know how can I proceed?

Soda added a subscriber: Soda.EditedJun 15 2020, 3:06 PM

@Abhir-24 , you need to use git clone https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue. The command at the url doesn't work sometimes since it depends on the computer being set up a particular way. :)

Demian added a comment.EditedJun 16 2020, 10:33 AM

I cloned the less.php file

You won't need to clone that, it's just a tool that's installed in the '<mediawiki>/vendor/wikimedia/less.php' folder and used by mediawiki. I'm sorry for misleading you with too much detail.

[... gerrit ...] it is showing permission denied

Gerrit is difficult to use, but favored by the developers. They'll be happy to help you set up authentication for it.
@Aklapper - AFAICT you're quite familiar with gerrit and this issue (T189182#6226830) and prefer to use it. Could you please help Abhir-24 with onboarding?

Aklapper added a comment.EditedJun 16 2020, 12:19 PM

@Demian: See the links I already posted. They explain where to find documentation and where to best ask questions. Thanks!

I was following the tutorial link to learn about gerrit. I did all steps as mentioned in the tutorial but in the last step it showed that I lack 'forge committer' permission. Can anyone tell me how can I fix this step as I think it is the main step to work on gerrit.

@Abhir-24: Setting up Gerrit is off-topic in this task. This task is about "Talk page as tab, small layout fixes". Please read T240254#6227091. Thank you! :)

@Abhir-24: Setting up Gerrit is off-topic in this task. This task is about "Talk page as tab, small layout fixes". Please read T240254#6227091. Thank you! :)

It would be more helpful in avoiding off-topic and more friendly to give Abhir direct help as I've asked in T240254#6227593. I'd help him, but unfortunately I can't recall what I did in those few hours it took me to get it working. To my best knowledge you're proficient with gerrit and favor it. It would be beneficial to you as well to learn about onboarding difficulties of newcomers.

Aklapper added a comment.EditedJun 16 2020, 5:42 PM

I'd be very happy to be a person to help in a Gerrit support place, but as I have explained numerous times now:
The stuff which you can find at https://phabricator.wikimedia.org/T240254 is not a Gerrit support place. :) (And it's unclear to me what "favor" is supposed to mean, or how that's relevant.)

Soda added a comment.EditedJun 16 2020, 5:46 PM

@Abhir-24 Check the output of git config -l --global. You've probably set the user.email as abhir.raj2410gmail.com (without the @) which is probably conflicting with the email you've set for your gerrit account. You need to set that that properly using git config --global user.email <email>

For general doubts regarding setting up Gerrit etc you can hop on the #mediawiki IRC channel. :)

Apologies to @Aklapper for asking off-topic question. Won't happen again : )

Thanks @Soda it worked!

Is there any way to get the output when the changes are made in any file and also how to determine which .less file belongs to #page-secondary-actions and the parent #content part in file skin.mustache since there are a lot of folders containing the styling files?

Demian added a comment.EditedJun 18 2020, 3:54 PM

Note: we should conduct development help discussions in a separate place, not on the ticket.
I've created a topic for onboarding on the mediawiki discourse and answered your question there. Unfortunately it's unlikely you'll meet the developers of Minerva there.

You can also occasionally reach me and some volunteers on the MediaWiki discord.
Employees inhabit IRC (note that your IP address will be leaked).