Page MenuHomePhabricator

Impossible to uncollapose termbox
Closed, ResolvedPublic

Description

Steps to reprodue:

Expected result:

  • You should be able to see the number of the devil in lots of languages

Actual result:

  • Nothing happens

Debug info:
I get this in my console when I load the page:

HierarchyRequestError: Node cannot be inserted at the specified point in the hierarchy

And this when I click on collapsing: TypeError: "e is undefined"

I think there's nothing we can do here, it's the devil not letting us see his number in more languages :(

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterIncrement TermboxView::CACHE_VERSION

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Oct 28, 12:04 PM
Pablo-WMDE added a comment.EditedMon, Oct 28, 12:11 PM

In my case (logged in)

HierarchyRequestError: Node cannot be inserted at the specified point in the hierarchy

happens right after page load
and

TypeError: "e is undefined"

upon click on "in more languages".

I can not observe an error (neither on load nor on click) on the respective actual mobile page.

Reminds me of T235429: Mismatched frontend JS and backend DOM should not be shipped & T235192: Bump up Termbox Cache version

Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.EditedMon, Oct 28, 1:03 PM

Thanks for the comments @Pablo-WMDE
I think this needs to be investigated further on the camp

Pablo-WMDE triaged this task as High priority.Mon, Oct 28, 2:11 PM

Talked with product and this was considered as High priority, leaning towards UBN looking at the behavior I experienced (error right on load).

My suspicion is that this is exactly the same problem that we had a few weeks ago (no ticket, yay) and opened T235261 for. This patch changes the markup and is part of the termbox pin bump that got deployed last week. I suspect that deploying the latest termbox version to the SSR fixes the problem when purging the page.

Change 546899 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Increment TermboxView::CACHE_VERSION

https://gerrit.wikimedia.org/r/546899

This is now deployed on prod. Entity pages should be fine after purge, e.g. https://www.wikidata.org/wiki/Q666?useformat=mobile

https://gerrit.wikimedia.org/r/546899 needs to be merged (and SWATted or just let it roll in with the train?), then this should be as fixed as it gets for now.

Change 546899 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Increment TermboxView::CACHE_VERSION

https://gerrit.wikimedia.org/r/546899

Lydia_Pintscher closed this task as Resolved.Tue, Oct 29, 7:32 PM

\o/
Thanks for fixing it quickly.