Impossible to uncollapose termbox
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ladsgroup
	Oct 28 2019, 12:04 PM

Description

Steps to reprodue:

Go to https://www.wikidata.org/wiki/Q666?useformat=mobile
Click on "In More Languages" to collapse it
Click on it again to uncollapse it.

Expected result:

You should be able to see the number of the devil in lots of languages

Actual result:

Nothing happens

Debug info:
I get this in my console when I load the page:

HierarchyRequestError: Node cannot be inserted at the specified point in the hierarchy

And this when I click on collapsing: TypeError: "e is undefined"

I think there's nothing we can do here, it's the devil not letting us see his number in more languages :(

Details

	Subject	Repo	Branch	Lines +/-
	Increment TermboxView::CACHE_VERSION	mediawiki/extensions/Wikibase	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T236709: Error when executing helmfile commands for the termbox service
Mentioned Here: T236709: Error when executing helmfile commands for the termbox service
T235261: Investigate why Termbox CSR failed to override mismatching SSR markup
T235192: Bump up Termbox Cache version
T235429: Mismatched frontend JS and backend DOM should not be shipped

Event Timeline

Ladsgroup created this task.Oct 28 2019, 12:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2019, 12:04 PM

In my case (logged in)

HierarchyRequestError: Node cannot be inserted at the specified point in the hierarchy

happens right after page load
and

TypeError: "e is undefined"

upon click on "in more languages".

Bildschirmfoto von 2019-10-28 13-08-57.png (624×694 px, 88 KB)

Bildschirmfoto von 2019-10-28 13-09-11.png (624×694 px, 87 KB)

I can not observe an error (neither on load nor on click) on the respective actual mobile page.

Reminds me of T235429: Mismatched frontend JS and backend DOM should not be shipped & T235192: Bump up Termbox Cache version

Thanks for the comments @Pablo-WMDE
I think this needs to be investigated further on the camp

Talked with product and this was considered as High priority, leaning towards UBN looking at the behavior I experienced (error right on load).

My suspicion is that this is exactly the same problem that we had a few weeks ago (no ticket, yay) and opened T235261 for. This patch changes the markup and is part of the termbox pin bump that got deployed last week. I suspect that deploying the latest termbox version to the SSR fixes the problem when purging the page.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Oct 28 2019, 3:15 PM

Blocked on T236709

• Pablo-WMDE mentioned this in T236709: Error when executing helmfile commands for the termbox service.Oct 29 2019, 10:17 AM

Change 546899 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Increment TermboxView::CACHE_VERSION

https://gerrit.wikimedia.org/r/546899

gerritbot added a project: Patch-For-Review.Oct 29 2019, 10:53 AM

This is now deployed on prod. Entity pages should be fine after purge, e.g. https://www.wikidata.org/wiki/Q666?useformat=mobile

https://gerrit.wikimedia.org/r/546899 needs to be merged (and SWATted or just let it roll in with the train?), then this should be as fixed as it gets for now.

Change 546899 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Increment TermboxView::CACHE_VERSION

https://gerrit.wikimedia.org/r/546899

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 29 2019, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 29 2019, 12:10 PM

Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 29 2019, 1:43 PM