Page MenuHomePhabricator

The ext.wikimediaBadges module should set the RL targets property
Closed, ResolvedPublic

Description

When a module is added to the page via OutputPage it must have a targets property set. If not it will throw a warning (soon to be error). In a 4hr period this led to 807,320 warnings.

This will lead to the module loading on mobile skins including the skin Minerva which is doesn't support, however this is fine, given the module is empty for the Minerva skin.

Acceptance criteria

Event Timeline

Change 547288 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/WikimediaBadges@master] Set targets on ext.wikimediaBadges module

https://gerrit.wikimedia.org/r/547288

Volker_E removed a subscriber: Volker_E.Oct 30 2019, 8:14 PM

Change 547288 merged by jenkins-bot:
[mediawiki/extensions/WikimediaBadges@master] Set targets on ext.wikimediaBadges module

https://gerrit.wikimedia.org/r/547288