Page MenuHomePhabricator

Newcomer tasks module setup is not complete for kowiki betalabs
Closed, ResolvedPublic

Description

On kowiki betalabs the activated Newcomer tasks module (Suggested edits) on Special:Homepage is presented blank and the Console error is displayed:

Screen Shot 2019-11-01 at 4.16.26 PM.png (494×441 px, 23 KB)

1[Xby53qwQBHcAAAvDEkkAAAAS] /w/load.php?lang=en&modules=startup&only=scripts&raw=1&safemode=1&skin=vector Wikimedia\Assert\ParameterAssertionException from line 63 of /srv/mediawiki/php-master/vendor/wikimedia/assert/src/Assert.php: Bad value for parameter $title: should not be empty unless namespace is main
2Backtrace:
3#0 /srv/mediawiki/php-master/includes/title/TitleValue.php(135): Wikimedia\Assert\Assert::parameter(boolean, string, string)
4#1 /srv/mediawiki/php-master/includes/title/TitleValue.php(89): TitleValue::assertValidSpec(integer, string, string, string)
5#2 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/ConfigurationLoader/RemotePageConfigurationLoader.php(146): TitleValue->__construct(integer, string)
6#3 [internal function]: GrowthExperiments\NewcomerTasks\ConfigurationLoader\RemotePageConfigurationLoader->GrowthExperiments\NewcomerTasks\ConfigurationLoader\{closure}(string)
7#4 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/ConfigurationLoader/RemotePageConfigurationLoader.php(147): array_map(Closure, array)
8#5 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/ConfigurationLoader/RemotePageConfigurationLoader.php(94): GrowthExperiments\NewcomerTasks\ConfigurationLoader\RemotePageConfigurationLoader->parseTaskTypesFromConfig(array)
9#6 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/HomepageHooks.php(569): GrowthExperiments\NewcomerTasks\ConfigurationLoader\RemotePageConfigurationLoader->loadTaskTypes()
10#7 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderFileModule.php(1181): GrowthExperiments\HomepageHooks::getTaskTypesJson(ResourceLoaderContext, GlobalVarConfig, NULL)
11#8 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderFileModule.php(617): ResourceLoaderFileModule->expandPackageFiles(ResourceLoaderContext)
12#9 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderModule.php(819): ResourceLoaderFileModule->getDefinitionSummary(ResourceLoaderContext)
13#10 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderStartUpModule.php(300): ResourceLoaderModule->getVersionHash(ResourceLoaderContext)
14#11 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderStartUpModule.php(484): ResourceLoaderStartUpModule->getModuleRegistrations(ResourceLoaderContext)
15#12 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderModule.php(713): ResourceLoaderStartUpModule->getScript(ResourceLoaderContext)
16#13 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderModule.php(681): ResourceLoaderModule->buildContent(ResourceLoaderContext)
17#14 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoaderModule.php(816): ResourceLoaderModule->getModuleContent(ResourceLoaderContext)
18#15 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoader.php(665): ResourceLoaderModule->getVersionHash(ResourceLoaderContext)
19#16 [internal function]: ResourceLoader->{closure}(string)
20#17 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoader.php(677): array_map(Closure, array)
21#18 /srv/mediawiki/php-master/includes/resourceloader/ResourceLoader.php(764): ResourceLoader->getCombinedVersion(ResourceLoaderContext, array)
22#19 /srv/mediawiki/php-master/load.php(48): ResourceLoader->respond(ResourceLoaderContext)
23#20 /srv/mediawiki/w/load.php(3): require(string)
24#21 {main}

Event Timeline

The config validator should handle this more gracefully. I added a note to T235717: Newcomer tasks: non-HTTP-based ConfigurationLoader and TaskSuggester which is the most closely related task.

Tgr assigned this task to Catrope.

Should be fixed now.

Pageview counts are not displayed, even though that should work in theory. Something to look into eventually, but very minor.