Page MenuHomePhabricator
Create Task
Maniphest T237463

Resolve all PORT-FIXMEs
Open, MediumPublic
Actions

Description

During porting, we left behind PORT-FIXMEs in a number of places. These were to address gaps, differences in JS/PHP, unresolved issues, etc. Now that we are close to being done with the porting, we should resolve all the remaining PORT-FIXMEs in one of the following ways:

  • Remove as invalid
  • Fix the issue identified
  • Convert to a regular FIXME that can be fixed at a later time (while filing phab tasks where appropriate)

Details

SubjectRepoBranchLines +/-
Stop creating dynamic properties in SerializerStatemediawiki/services/parsoidREL1_39+49 -49
Stop creating dynamic properties in SerializerStatemediawiki/services/parsoidREL1_40+49 -49
Bump wikimedia/parsoid to 0.18.0-a26mediawiki/vendormaster+542 -1 K
Stop creating dynamic properties in SerializerStatemediawiki/services/parsoidmaster+49 -49
Bump parsoid to 0.16.0-a8mediawiki/vendormaster+1 K -664
Resolve linter test port-fixmemediawiki/services/parsoidmaster+30 -25
Resolve some PORT-FIXMEsmediawiki/services/parsoidmaster+10 -12
Customize query in gerrit

Related Objects

Event Timeline

ssastry triaged this task as Medium priority.Nov 5 2019, 9:14 PM
ssastry created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 5 2019, 9:14 PM
ssastry moved this task from Backlog to Porting on the Parsoid-PHP board.Nov 5 2019, 9:14 PM
Arlolra claimed this task.Nov 8 2019, 10:29 PM
gerritbot added a comment.Nov 14 2019, 9:59 PM

Change 550953 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] [WIP] Resolve some PORT-FIXMEs

https://gerrit.wikimedia.org/r/550953

gerritbot added a project: Patch-For-Review.Nov 14 2019, 9:59 PM
gerritbot added a comment.Nov 15 2019, 11:02 PM

Change 550953 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Resolve some PORT-FIXMEs

https://gerrit.wikimedia.org/r/550953

Maintenance_bot removed a project: Patch-For-Review.Nov 15 2019, 11:10 PM
Stashbot mentioned this in T237886: Argument 1 passed to Parsoid\Utils\PHPUtils::encodeURIComponent() must be of the type string, integer given.Nov 18 2019, 9:56 PM
Stashbot mentioned this in T237103: PHP Notice: Undefined offset: 2.
Stashbot mentioned this in T236864: Call to a member function getArticleID() on null.
Stashbot mentioned this in T237569: Linter extension is currently incompatible with Parsoid/PHP.
Stashbot mentioned this in T236930: API Developer supports different request media types.

Mentioned in SAL (#wikimedia-operations) [2019-11-18T21:56:52Z] <arlolra> Upgraded Parsoid to 2245b8f (T237886, T237103, T236864, T237569, T236930, T237463, T236867, T234266)

Stashbot mentioned this in T236867: PHP Notice: Trying to get property 'parsoid' of non-object.Nov 18 2019, 9:57 PM
Stashbot mentioned this in T234266: Cannot read property 'stored' of undefined.
Arlolra removed Arlolra as the assignee of this task.Dec 6 2019, 8:15 PM
Arlolra subscribed.
Aklapper edited projects, added Parsoid; removed Parsoid-PHP.Apr 10 2020, 4:27 PM
ssastry moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.Apr 10 2020, 5:00 PM
gerritbot added a comment.Apr 29 2022, 8:05 PM

Change 787822 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Resolve linter test port-fixme

https://gerrit.wikimedia.org/r/787822

gerritbot added a project: Patch-For-Review.Apr 29 2022, 8:05 PM
gerritbot added a comment.May 11 2022, 2:54 AM

Change 787822 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Resolve linter test port-fixme

https://gerrit.wikimedia.org/r/787822

Maintenance_bot removed a project: Patch-For-Review.May 11 2022, 3:31 AM
gerritbot added a comment.May 16 2022, 4:06 PM

Change 792236 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump parsoid to 0.16.0-a8

https://gerrit.wikimedia.org/r/792236

gerritbot added a project: Patch-For-Review.May 16 2022, 4:06 PM
gerritbot added a comment.May 16 2022, 6:27 PM

Change 792236 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.16.0-a8

https://gerrit.wikimedia.org/r/792236

Maintenance_bot removed a project: Patch-For-Review.May 16 2022, 6:32 PM
gerritbot added a comment.Sep 21 2023, 11:48 PM

Change 932334 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Stop creating dynamic properties in SerializerState

https://gerrit.wikimedia.org/r/932334

gerritbot added a project: Patch-For-Review.Sep 21 2023, 11:48 PM
gerritbot added a comment.Sep 27 2023, 3:26 PM

Change 932334 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Stop creating dynamic properties in SerializerState

https://gerrit.wikimedia.org/r/932334

Maintenance_bot removed a project: Patch-For-Review.Sep 27 2023, 3:34 PM
gerritbot added a comment.Oct 2 2023, 9:11 PM

Change 962706 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.18.0-a26

https://gerrit.wikimedia.org/r/962706

gerritbot added a project: Patch-For-Review.Oct 2 2023, 9:11 PM
gerritbot added a comment.Oct 2 2023, 10:27 PM

Change 962706 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.18.0-a26

https://gerrit.wikimedia.org/r/962706

Maintenance_bot removed a project: Patch-For-Review.Oct 2 2023, 10:33 PM
Nikerabbit added a project: PHP 8.2 support.Nov 26 2023, 6:25 PM
Nikerabbit subscribed.

It seems rGPAR9e27846a8841: Stop creating dynamic properties in SerializerState was not backported to MW 1.40.

gerritbot added a comment.Dec 18 2023, 7:13 PM

Change 983910 had a related patch set uploaded (by Paladox; author: Arlolra):

[mediawiki/services/parsoid@REL1_40] Stop creating dynamic properties in SerializerState

https://gerrit.wikimedia.org/r/983910

gerritbot added a project: Patch-For-Review.Dec 18 2023, 7:13 PM
gerritbot added a comment.Dec 19 2023, 4:44 PM

Change 984179 had a related patch set uploaded (by Reedy; author: Arlolra):

[mediawiki/services/parsoid@REL1_39] Stop creating dynamic properties in SerializerState

https://gerrit.wikimedia.org/r/984179

gerritbot added a comment.Jan 4 2024, 9:41 PM

Change 983910 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_40] Stop creating dynamic properties in SerializerState

https://gerrit.wikimedia.org/r/983910

gerritbot added a comment.Jan 8 2024, 11:42 PM

Change 984179 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_39] Stop creating dynamic properties in SerializerState

https://gerrit.wikimedia.org/r/984179

Maintenance_bot removed a project: Patch-For-Review.Jan 9 2024, 12:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL