@eprodromou This is a potential blocker for enabling use of VisualEditor with Parsoid/PHP on private wikis that don't use RESTBase. So, officewiki, wikitech, and other private wikis. Is this something your team can look at in the coming week?

In T236930#5621053, @ssastry wrote:

@eprodromou This is a potential blocker for enabling use of VisualEditor with Parsoid/PHP on private wikis that don't use RESTBase. So, officewiki, wikitech, and other private wikis. Is this something your team can look at in the coming week?

I didn't even know this was a goal. Honestly, I think this is an AMAZING possibility. I think this would be something we could start next week, and could be complete for a two-week sprint. Does that fit in for your timeframe?

If this works... it would be amazing. What a huge leap forward for the usability of MW!

In T236930#5641157, @eprodromou wrote:

In T236930#5621053, @ssastry wrote:

@eprodromou This is a potential blocker for enabling use of VisualEditor with Parsoid/PHP on private wikis that don't use RESTBase. So, officewiki, wikitech, and other private wikis. Is this something your team can look at in the coming week?

I didn't even know this was a goal.

Sorry yes. We didn't discover this till we tried out VE locally without RESTBase

Honestly, I think this is an AMAZING possibility. I think this would be something we could start next week, and could be complete for a two-week sprint. Does that fit in for your timeframe?

Yes, we can just leave the private wikis on Parsoid/JS till then.

(deleted dupe)

...

I changed the description to fit in with our user story format. Hope that's not too disruptive.

Should we consider deprecating sending non-json input?

In T236930#5642666, @Pchelolo wrote:

Should we consider deprecating sending non-json input?

That is a MediaWiki-as-a-product decision. I don't have a strong opinion. If that makes sense for MediaWiki as a product, we should get clients to move over to JSON input as part of the Parsoid-PHP switchover.

In T236930#5642666, @Pchelolo wrote:

Should we consider deprecating sending non-json input?

So, product-wise, I think not. We're going to be handling binary data for file uploads, so while I think we'll be predominately JSON-only, we should support non-JSON input data for selected endpoints.

I believe that only supporting non-JSON input when it's explicitly declared for the endpoint should be sufficient.

The core REST API doesn't have a policy on the content type of the request body. ParsoidHandler is the thing assuming JSON input, core does not do content type validation. The idea was that handlers would be responsible checking the content-type and responding with a 415 if necessary. Maybe some of the logic could be factored out into a helper provided by core, but I don't think the Router should be validating the request content type before it executes the handler. We talked about that in T221177 and concluded that it opens a big can of worms.

You say that the three formats you want are application/json, application/x-www-form-urlencoded, and multipart/form-data. For the latter two formats, these are parsed by PHP prior to request execution, and we provide access to the parsed array via the $_POST wrapper RequestInterface::getPostParams(). So all you really need is something like:

function getParsedBody() {
    $request = $this->getRequest();
    $contentType = $request->getHeader( 'Content-Type' )[0] ?? '';
    switch ( $contentType ) {
        case 'application/x-www-form-urlencoded':
        case 'multipart/form-data':
            return $request->getPostParams();
        case 'application/json':
            return json_decode( $request->getBody()->getContents(), true );
        default:
            throw new HttpException( 'Unsupported Media Type', 415 );
    }
}

Please let me know if you need any more help with this.

Change 551240 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Support for other content encodings in the REST API

https://gerrit.wikimedia.org/r/551240

Change 551240 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Support for other content encodings in the REST API

https://gerrit.wikimedia.org/r/551240

Mentioned in SAL (#wikimedia-operations) [2019-11-18T21:56:52Z] <arlolra> Upgraded Parsoid to 2245b8f (T237886, T237103, T236864, T237569, T236930, T237463, T236867, T234266)