Page MenuHomePhabricator

Special:SuggestedTags loads stale suggestions on back-navigation
Closed, InvalidPublicBUG REPORT

Description

It appears that we need an update to ensure that fresh suggestions are loaded when the user navigates back to Special:SuggestedTags, rather than the same suggestions being loaded from cache.

Steps to Reproduce:

  1. Visit Special:SuggestedTags
  2. Vote on tags for one or more images
  3. Click the "terms of use" link in the page footer
  4. Click back to return to Special:SuggestedTags

Actual Results:

Suggestions already voted on are reloaded

Expected Results:

Fresh suggestions are loaded

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I cannot reproduce this, so I'll give it up to others to try. For the record, I tried locally, on test-commons, and on production Commons with Chromium 78.0.3904.70 and Firefox 70.0.1 on Ubuntu 18.04.

@Ramsey-WMF is reportedly seeing this with Google Chrome 78.0.3904.87 on Windows.

I can't reproduce this in terms of seeing images I've already tagged. I can confirm the following in Firefox:

  1. In firefox, while logged into Commons, go to https://commons.wikimedia.org/wiki/Special:SuggestedTags
  2. Add tags to an image, publish, and confirm them
  3. Take note of the image you see afterward
  4. Click on "terms of use" below the images
  5. Navigate back to SuggestedTags via the browser back button
  6. You'll see the image that you saw after you published tags for the previous image.

Basically, in FF, when you go back to the page the app doesn't seem to reload, it's present in the state it was before and shows you the batch of images that was fetched previously. But, I never saw any images that I had previously confirmed tags for.

Basically, in FF, when you go back to the page the app doesn't seem to reload, it's present in the state it was before and shows you the batch of images that was fetched previously. But, I never saw any images that I had previously confirmed tags for.

This is consistent with my testing as well. In FF, the page returns to its exact previous state, and in Chromium, the API is re-queried. In neither case do I see images for which I've already voted.

Mholloway raised the priority of this task from High to Needs Triage.Nov 18 2019, 4:30 PM

De-prioritizing and moving to the PI backlog until this can be reproduced.

Please reopen if repro steps are found.