Page MenuHomePhabricator

Remove (slow) Cite parser tests that aren't needed any more
Open, Needs TriagePublic1 Estimated Story Points

Description

We started writing PHPUnit tests for the Cite extension (some being integration test with MediaWiki, some being pure unit tests). Before, the extension was exclusively tested with parser tests.

At the end of this project, we would like to review the parser tests and:

  • Delete duplicates that actually test the exact same code paths.
  • Delete (slow) parser tests for code that is sufficiently covered by PHPUnit tests.

Event Timeline

Change 552482 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Cite@master] Add missing test cases for follow="…"

https://gerrit.wikimedia.org/r/552482

Change 552482 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Add missing test cases for follow="…"

https://gerrit.wikimedia.org/r/552482

Change 920308 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Improve performance of extreme parser test with 1000 references

https://gerrit.wikimedia.org/r/920308

Change 920308 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/Cite@master] Improve performance of extreme parser test with 1000 references

Reason:

Superseded by https://gerrit.wikimedia.org/r/941428

https://gerrit.wikimedia.org/r/920308

Change 941428 had a related patch set uploaded (by Bartosz Dziewoński; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Replace extremely slow parser test with fast unit tests

https://gerrit.wikimedia.org/r/941428

Change 941428 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Replace extremely slow parser test with fast unit tests

https://gerrit.wikimedia.org/r/941428