Page MenuHomePhabricator
Create Task
Maniphest T238456

Missing implementation to post Parsoid/PHP lints to production database
Closed, ResolvedPublic
Actions

Description

https://codesearch.wmflabs.org/search/?q=ParsoidLogLinterData&i=nope&files=&repos= shows that the only reference to the ParsoidLogLinterData hook is in the Parsoid codebase. We had all along assumed that this was actually implemented somewhere.

So, for now, perhaps, we should simply do a UDP post of lints to the Linter API just like Parsoid/JS does.

We should concurrently explore the implement of this hook in the Linter extension to support direct writes to the production db.

Details

SubjectRepoBranchLines +/-
Revert "Revert "Implement ParserLogLinterData hook""mediawiki/extensions/Linterwmf/1.35.0-wmf.8+68 -48
Revert "Revert "Implement ParserLogLinterData hook""mediawiki/extensions/Linterwmf/1.35.0-wmf.5+68 -48
Implement ParserLogLinterData hookmediawiki/extensions/Linterwmf/1.35.0-wmf.8+68 -48
Implement ParserLogLinterData hookmediawiki/extensions/Linterwmf/1.35.0-wmf.5+68 -48
Implement ParserLogLinterData hookmediawiki/extensions/Lintermaster+68 -48
Use the ParserLogLinterData hookmediawiki/services/parsoidmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

ssastry triaged this task as High priority.Nov 15 2019, 10:33 PM
ssastry created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2019, 10:33 PM
ssastry added a parent task: T237326: Make Parsoid/PHP cluster read-write to ensure lints discovered by Parsoid/PHP are stored in the DB.Nov 15 2019, 10:33 PM
ssastry added a project: MediaWiki-extensions-Linter.
ssastry added subscribers: Anomie, Legoktm.
ssastry moved this task from Backlog to Porting on the Parsoid-PHP board.Nov 15 2019, 11:29 PM
ssastry mentioned this in T237326: Make Parsoid/PHP cluster read-write to ensure lints discovered by Parsoid/PHP are stored in the DB.Nov 20 2019, 12:45 AM
ssastry edited parent tasks, added: T229015: Tracking: Direct live production traffic at Parsoid/PHP; removed: T237326: Make Parsoid/PHP cluster read-write to ensure lints discovered by Parsoid/PHP are stored in the DB.
Arlolra claimed this task.Nov 22 2019, 10:28 PM
gerritbot added a comment.Nov 26 2019, 1:03 AM

Change 552938 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/extensions/Linter@master] [WIP] Implement ParsoidLogLinterData hook

https://gerrit.wikimedia.org/r/552938

gerritbot added a project: Patch-For-Review.Nov 26 2019, 1:03 AM
gerritbot added a comment.Nov 26 2019, 1:31 AM

Change 552941 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Use the ParsoidLogLinterData hook

https://gerrit.wikimedia.org/r/552941

gerritbot added a comment.Dec 4 2019, 4:18 AM

Change 552938 merged by jenkins-bot:
[mediawiki/extensions/Linter@master] Implement ParserLogLinterData hook

https://gerrit.wikimedia.org/r/552938

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 4 2019, 5:00 AM
gerritbot added a comment.Dec 4 2019, 5:20 PM

Change 552941 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Use the ParserLogLinterData hook

https://gerrit.wikimedia.org/r/552941

Arlolra closed this task as Resolved.Dec 4 2019, 5:23 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 4 2019, 6:10 PM
Stashbot mentioned this in T239643: Bugs in PHP port of LanguageConverter.Dec 4 2019, 6:45 PM
Stashbot mentioned this in T239830: Add metrics for startup time for language variant code.

Mentioned in SAL (#wikimedia-operations) [2019-12-04T18:45:12Z] <arlolra> Updated Parsoid to b81bbf4 (T239643, T239830, T238456, T239841)

Stashbot mentioned this in T239841: Parsoid resource limits and metrics use mb_strlen, which is (a) inconsistent w/ Parser.php and (b) slow.Dec 4 2019, 6:45 PM
gerritbot added a comment.Dec 5 2019, 5:52 PM

Change 554921 had a related patch set uploaded (by C. Scott Ananian; owner: Arlolra):
[mediawiki/extensions/Linter@wmf/1.35.0-wmf.5] Implement ParserLogLinterData hook

https://gerrit.wikimedia.org/r/554921

gerritbot added a project: Patch-For-Review.Dec 5 2019, 5:52 PM

Change 554923 had a related patch set uploaded (by C. Scott Ananian; owner: Arlolra):
[mediawiki/extensions/Linter@wmf/1.35.0-wmf.8] Implement ParserLogLinterData hook

https://gerrit.wikimedia.org/r/554923

gerritbot added a comment.Dec 5 2019, 7:06 PM

Change 554921 merged by jenkins-bot:
[mediawiki/extensions/Linter@wmf/1.35.0-wmf.5] Implement ParserLogLinterData hook

https://gerrit.wikimedia.org/r/554921

gerritbot added a comment.Dec 5 2019, 7:06 PM

Change 554923 merged by jenkins-bot:
[mediawiki/extensions/Linter@wmf/1.35.0-wmf.8] Implement ParserLogLinterData hook

https://gerrit.wikimedia.org/r/554923

Maintenance_bot removed a project: Patch-For-Review.Dec 5 2019, 7:10 PM
Stashbot added a comment.Dec 5 2019, 7:14 PM

Mentioned in SAL (#wikimedia-operations) [2019-12-05T19:14:11Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.8/extensions/Linter: SWAT: 839c383: Implement ParserLogLinterData hook (T238456) (duration: 01m 02s)

gerritbot added a comment.Dec 5 2019, 7:32 PM

Change 554931 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/Linter@wmf/1.35.0-wmf.5] Revert "Revert "Implement ParserLogLinterData hook""

https://gerrit.wikimedia.org/r/554931

gerritbot added a project: Patch-For-Review.Dec 5 2019, 7:32 PM

Change 554932 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/Linter@wmf/1.35.0-wmf.8] Revert "Revert "Implement ParserLogLinterData hook""

https://gerrit.wikimedia.org/r/554932

gerritbot added a comment.Dec 5 2019, 7:35 PM

Change 554931 merged by jenkins-bot:
[mediawiki/extensions/Linter@wmf/1.35.0-wmf.5] Revert "Revert "Implement ParserLogLinterData hook""

https://gerrit.wikimedia.org/r/554931

gerritbot added a comment.Dec 5 2019, 7:35 PM

Change 554932 merged by jenkins-bot:
[mediawiki/extensions/Linter@wmf/1.35.0-wmf.8] Revert "Revert "Implement ParserLogLinterData hook""

https://gerrit.wikimedia.org/r/554932

Stashbot added a comment.Dec 5 2019, 7:37 PM

Mentioned in SAL (#wikimedia-operations) [2019-12-05T19:37:43Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/Linter/includes/Hooks.php: SWAT: 7b7f326: Implement ParserLogLinterData hook (1/3, T238456) (duration: 01m 09s)

Stashbot added a comment.Dec 5 2019, 7:39 PM

Mentioned in SAL (#wikimedia-operations) [2019-12-05T19:39:12Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/Linter/extension.json: SWAT: 7b7f326: Implement ParserLogLinterData hook (2/3, T238456) (duration: 01m 05s)

Stashbot added a comment.Dec 5 2019, 7:41 PM

Mentioned in SAL (#wikimedia-operations) [2019-12-05T19:41:58Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/Linter/includes/ApiRecordLint.php: SWAT: 7b7f326: Implement ParserLogLinterData hook (3/3, T238456) (duration: 01m 04s)

Stashbot added a comment.Dec 5 2019, 7:44 PM

Mentioned in SAL (#wikimedia-operations) [2019-12-05T19:44:32Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.8/extensions/Linter/includes/Hooks.php: SWAT: afcfdce: Revert "Revert "Implement ParserLogLinterData hook"" (1/3, T238456) (duration: 01m 11s)

Stashbot added a comment.Dec 5 2019, 7:46 PM

Mentioned in SAL (#wikimedia-operations) [2019-12-05T19:46:22Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.8/extensions/Linter/includes/ApiRecordLint.php: SWAT: afcfdce: Revert "Revert "Implement ParserLogLinterData hook"" (2/3, T238456) (duration: 01m 09s)

Stashbot added a comment.Dec 5 2019, 7:47 PM

Mentioned in SAL (#wikimedia-operations) [2019-12-05T19:47:36Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.8/extensions/Linter/extension.json: SWAT: afcfdce: Revert "Revert "Implement ParserLogLinterData hook"" (3/3, T238456) (duration: 01m 00s)

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.8; 2019-11-26); removed MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 5 2019, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 5 2019, 8:10 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL