CiteThisPage should not show error message before I do anything
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Ammarpad
	Nov 16 2019, 6:23 AM

Description

Open https://en.wikipedia.org/wiki/Special:CiteThisPage or similar special page on a wiki where CiteThisPage extension is enabled.

Observe two error messages saying there are problems with your input. But I did not not input anything for the form to validate.

Expected

The form should not show any error message until if I click the submit button without supplying the required values

Details

	Subject	Repo	Branch	Lines +/-
	Add setFormIdentifier to prevent validation errors	mediawiki/extensions/CiteThisPage	master	+4 -3

Customize query in gerrit

Related Objects

Mentioned Here: T238486: Special:ContentModel should not show errors before input.

Event Timeline

Ammarpad created this task.Nov 16 2019, 6:23 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2019, 6:23 AM

Ammarpad updated the task description. (Show Details)Nov 16 2019, 6:24 AM

Masumrezarock100 added a project: good first task.Nov 16 2019, 10:51 AM

Masumrezarock100 changed the subtype of this task from "Task" to "Bug Report".

Masumrezarock100 added a project: MediaWiki-Special-pages.

Change 551316 had a related patch set uploaded (by Sohom Datta; owner: Sohom Datta):
[mediawiki/extensions/CiteThisPage@master] Stopped form from showing errors without input

https://gerrit.wikimedia.org/r/551316

gerritbot added a project: Patch-For-Review.Nov 16 2019, 5:53 PM

Soda claimed this task.Nov 16 2019, 5:53 PM

Okay, same sort of bug also happens at Special:ChangeContentModel.

Screenshot from 2019-11-17 10-53-55.png (768×1 px, 67 KB)

Edit : Reported the bug in T238486

matmarex merged a task: T213317: CiteThisPage's empty form always prompts the user with to fill in content before they've done anything.Nov 17 2019, 6:03 AM

matmarex added subscribers: Jdforrester-WMF, Raymond, matmarex.

1997kB moved this task from To triage to Special:Contributions / Special:DeletedContributions on the MediaWiki-Special-pages board.Dec 24 2019, 2:02 PM

1997kB moved this task from Special:Contributions / Special:DeletedContributions to To triage on the MediaWiki-Special-pages board.Dec 24 2019, 2:20 PM

Error messages are still shown on wikipedias: https://en.wikipedia.org/wiki/Special:CiteThisPage

In T238467#5930831, @Framawiki wrote:

Error messages are still shown on wikipedias: https://en.wikipedia.org/wiki/Special:CiteThisPage

@Framawiki Patch isn't merged still.

Change 551316 merged by jenkins-bot:
[mediawiki/extensions/CiteThisPage@master] Add setFormIdentifier to prevent validation errors

https://gerrit.wikimedia.org/r/551316

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2020, 9:10 PM

Thanks! Sorry I didn't look at the patch earlier.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 3 2020, 10:00 PM

Jdforrester-WMF edited projects, added MW-1.35-notes (1.35.0-wmf.23; 2020-03-10); removed MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 5 2020, 3:00 PM

	F31095210: Screenshot from 2019-11-17 10-53-55.png
	Nov 17 2019, 5:24 AM

CiteThisPage should not show error message before I do anythingClosed, ResolvedPublicBUG REPORTActions