Page MenuHomePhabricator

Automatically add tasks in some Wikispeech projects to column of another Wikispeech project
Closed, ResolvedPublic4 Estimated Story Points

Description

We want to have a Herald rule that adds any task that is added to either Wikispeech-Text-to-Speech or Wikispeech-Speech-Data-Collector to Wikispeech-Jobrunner, except if it's added to the "Future development" column.

This will have to be created by someone with the appropriate permissions, see https://www.mediawiki.org/wiki/Phabricator/Help/Herald_Rules#Global_Herald_rules.

Event Timeline

DannyS712 added subscribers: Ladsgroup, DannyS712.

Herald rules cannot take into account columns. Perhaps a job for @Ladsgroup's bot?

Might be a use case for column triggers - T227300

See screenshot on https://www.mediawiki.org/wiki/Phabricator/Help/Herald_Rules - nothing related to columns...

Aklapper renamed this task from Add Herald rule for Wikispeech projects to Automatically add tasks in some Wikispeech projects to column of another Wikispeech project.Nov 28 2019, 12:25 PM

I seem to recall that that only works if you move a task on the workboard and not if you change column by editing the task. I can't remember where I read that though, so I might be wrong.

I think that for now, having a rule that automatically adds the project regardless of columns is better than nothing. If we notice that it becomes a problem that Wikispeech-Jobrunner isn't removed when a task is moved to "Future development", we can look into solutions for that (e.g. a bot).

@Aklapper, could you please add a Herald rule that adds Wikispeech-Jobrunner to any task created in Wikispeech-Text-to-Speech or Wikispeech-Speech-Data-Collector?

@Aklapper, could you (or anyone else with the needed permissions) create the Herald rule above?

The rule adds Wikispeech-Jobrunner even if a task is created in a subproject of it (in this case the milestone Wikispeech-jobrunner(Sprint)). This is not ideal since it removes the subproject. Is there a way have the rule not do this?

One example of confusing bot behavour in the screenshot below. The task was created within the jobrunner sprint. Immediately after I created it, it was removed from the sprint and as a consequence, it ended up in Incoming on the Jobrunner workboard (although I explicitly added it to the sprint).

image.png (623×907 px, 78 KB)

Another example below. This ticket was in the sprint. It was manually moved from In progress to Done earlier today (during the sprint meeting). When this was done, it was also automatically added to the jobrunner workboard, and as a consqeuence, removed from the sprint.

So in the end, moving it from In progress to Done in the sprint, caused this task to end up in Incoming in the jobrunner workboard.

image.png (669×863 px, 112 KB)

Meh, sorry. I now added a second condition to that Herald rule, wondering if that might work?

Any feedback on my previous comment, please? :)

Yes, it looks like it's working now. Thanks, @Aklapper.

@Aklapper, is there any way to have this only trigger when there is a change in the projects and not for other things. For example this changed the subscribers and that triggered the rule: T192433#6850156?