Page MenuHomePhabricator

🎬 desktop-de-16 | Increased banner size for bigger viewports – ⏰ 04.12.
Closed, ResolvedPublic

Description

The banners are based on the var banner of desktop-de-14.

Acceptance Criteria

Control and Variant

  • Two options are added to the payment interval radio button group in both the control and the variant banner:
    • quartely ("vierteljährlich") sets the value 3
    • semi-yearly ("halbjährlich") sets the value 6.
  • Two payment interval options are displayed per row. The last row contains a single option.

Variant only

Viewport width of 1580px and above

Banner text

  • there is a break after the first part of the headline ("Liebe Leserinnen und Leser,").
  • a padding of 1.2em is added to the blue text box.
  • the triangular pointer on the left is repositioned to level out the changed padding.
  • the line height is increased to 1.5em.
  • the sentence "Das Herzstück..." is not displayed.

Progress bar

  • the height of the progress bar is increased to 2.2em.
  • the font size of elements inside the progress bar is increased to 1.2em.

Form

  • the font size of the form labels is increased to 1.2em.
  • the spacing between button groups is increased to 1em.
  • the form width is increased to 24em.
  • the font size of the form labels is increased to 1.2em.
  • the top padding of radio button groups is increased to 1em.
  • the height of radio button labels is increased to 35px.
  • the top and button padding of the submit button is increased to 0.4em.

Other

  • the font-size of the close button is increased to 35px.
  • the close button is repositioned to level out the increased font size.
  • the font size of the footer line is increased to 1em.

Viewport width of 1900px and above

Banner text

  • the sentence "Das Herzstück..." is displayed.

Layout changes in 1580+ pixels

screenshot-de.wikipedia.org-2019.12.04-13-50-53.png (490×1 px, 191 KB)

Notes
Depending on the outcome of viewport size data analysis, there might be changes to the breakpoint settings.

Event Timeline

@Tim_WMDE We introduced increasing the font size in $breakpoint_s already. Turned out it has a negative effect. Can you move that back to $breakpoint_m?

@Tim_WMDE Thank you for interpreting correctly what I meant by saying "the font size of the footer line is increased to 0em".

There are some minor issues:

  • The text inside the progress bar should be vertically centered.
  • The radio buttons do not align well with their labels.

Two more things that just came up:

  • The font size of the banner text should be increased to 1.1em in viewport widths between 1024 and 1089 pixels.
  • The form width is already increased in viewport widths >1300px. This should only happen at >1580px.

check the banners again @kai.nissen @tmletzko

  • both banners now have 1.1em font size at 1024-1089px viewport ✓
  • VAR form only gets wider at >1580px, not already at >1300px ✓

Sorry @CorinnaHillebrand_WMDE, I mixed that up when I wrote my previous comment already.

  • The control banner should increase the font size in $breakpoint_s to 18px (like the variant of desktop-de-14).
  • The variant banner should increase the font size to 1.1em.
tmletzko moved this task from Doing to Done on the WMDE-FUN-Funban-2019 board.
tmletzko added a subscriber: Tim_WMDE.
kai.nissen claimed this task.