Page MenuHomePhabricator
Create Task
Maniphest T239653

Use px units instead of ems in LESS for most values
Closed, ResolvedPublic
Actions

Description

Per T220671, px units should be used for most values excepting those that need to use relative units to enable users to change their default font-size in modern browsers (font-size, icon sizes, some heights/widths).

Details

Related Gerrit Patches:
mediawiki/extensions/MachineVision : masterUse px units for most values in LESS files

Related Objects

Event Timeline

AnneT created this task.Dec 2 2019, 7:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2019, 7:45 PM
gerritbot added a comment.Dec 2 2019, 7:56 PM

Change 554137 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/MachineVision@master] Use px units for most values in LESS files

https://gerrit.wikimedia.org/r/554137

AnneT moved this task from To Do to Current Work on the Structured-Data-Backlog board.Dec 2 2019, 8:27 PM
AnneT edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.
AnneT moved this task from Backlog to In development on the MachineVision board.
AnneT moved this task from To Do to Code Review on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Dec 4 2019, 8:32 PM

Change 554137 merged by jenkins-bot:
[mediawiki/extensions/MachineVision@master] Use px units for most values in LESS files

https://gerrit.wikimedia.org/r/554137

Mholloway moved this task from In development to Done on the MachineVision board.Dec 9 2019, 7:07 PM
Ramsey-WMF reassigned this task from AnneT to egardner.Dec 16 2019, 5:38 PM
Ramsey-WMF moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.
Ramsey-WMF added a subscriber: Ramsey-WMF.

Eric will look at it and see if anything looks amiss.

egardner added a comment.Dec 16 2019, 5:42 PM

Everything here looks good.

egardner closed this task as Resolved.Dec 16 2019, 5:43 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL