54) WikibaseQuality\ConstraintReport\Tests\Checker\AllowedUnitsCheckerTest::testAllowedUnitsConstraint_UnknownValue === Logs generated by test case [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"} === Array and string offset access syntax with curly braces is deprecated /workspace/src/extensions/Wikibase/lib/includes/Units/UnitConverter.php:91 /workspace/src/includes/AutoLoader.php:109 /workspace/src/includes/AutoLoader.php:109 /workspace/src/extensions/WikibaseQualityConstraints/tests/phpunit/Checker/AllowedUnitsCheckerTest.php:40 /workspace/src/extensions/WikibaseQualityConstraints/tests/phpunit/Checker/AllowedUnitsCheckerTest.php:48 /workspace/src/maintenance/doMaintenance.php:99 55) WikibaseQuality\ConstraintReport\Tests\Checker\AllowedUnitsCheckerTest::testAllowedUnitsConstraint_SomeUnit_AllowedWithValueConversion === Logs generated by test case [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"} === Trying to access array offset on value of type int /workspace/src/extensions/Wikibase/lib/includes/Units/UnitConverter.php:91 /workspace/src/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/AllowedUnitsChecker.php:171 /workspace/src/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/AllowedUnitsChecker.php:106 /workspace/src/extensions/WikibaseQualityConstraints/tests/phpunit/Checker/AllowedUnitsCheckerTest.php:127 /workspace/src/maintenance/doMaintenance.php:99 56) WikibaseQuality\ConstraintReport\Tests\Checker\AllowedUnitsCheckerTest::testAllowedUnitsConstraint_SomeUnit_AllowedWithConstraintConversion === Logs generated by test case [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"} === Trying to access array offset on value of type int /workspace/src/extensions/Wikibase/lib/includes/Units/UnitConverter.php:91 /workspace/src/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/AllowedUnitsChecker.php:171 /workspace/src/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/AllowedUnitsChecker.php:108 /workspace/src/extensions/WikibaseQualityConstraints/tests/phpunit/Checker/AllowedUnitsCheckerTest.php:143 /workspace/src/maintenance/doMaintenance.php:99 57) WikibaseQuality\ConstraintReport\Tests\Checker\AllowedUnitsCheckerTest::testAllowedUnitsConstraint_SomeUnit_AllowedWithDoubleConversion === Logs generated by test case [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/127.0.0.1:9412\/entity\/'"} === Trying to access array offset on value of type int /workspace/src/extensions/Wikibase/lib/includes/Units/UnitConverter.php:91 /workspace/src/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/AllowedUnitsChecker.php:171 /workspace/src/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/AllowedUnitsChecker.php:106 /workspace/src/extensions/WikibaseQualityConstraints/tests/phpunit/Checker/AllowedUnitsCheckerTest.php:162 /workspace/src/maintenance/doMaintenance.php:99
Description
Details
Related Objects
- Mentioned In
- T233012: Make MediaWiki core compatible with PHP 7.4
- Mentioned Here
- T239761: Wikibase is not compatible with PHP7.4
Event Timeline
Trying to access array offset on value of type int /workspace/src/extensions/Wikibase/lib/includes/Units/UnitConverter.php:91 /workspace/src/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/AllowedUnitsChecker.php:171 /workspace/src/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/AllowedUnitsChecker.php:106 /workspace/src/extensions/WikibaseQualityConstraints/tests/phpunit/Checker/AllowedUnitsCheckerTest.php:127 /workspace/src/maintenance/doMaintenance.php:99
That’s an error in Wikibase code, it just happens to be called from WikibaseQualityConstraints. (We don’t seem to have a #mediawiki-extensions-wikibaselib project/tag yet.)
Change 554491 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix deprecated array offset syntax
Ah, but a “check experimental” on Wikibase is going to fail even after this fix, due to T239761. I’ll upload a noop WBQC change to test this.
Change 554494 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] DNM: no-op to test CI
Meh, that doesn’t make a difference when WikibaseQualityConstraints includes the Wikibase tests ^^
Change 554491 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix deprecated array offset syntax