Make MediaWiki core compatible with PHP 7.4
Closed, ResolvedPublic
Actions

Description

Since PHP 7.4.0 has been released, we can start thinking about the compatibility.

The following is the problems from phpunit unit test:

ReflectionType::__toString() is deprecated -- T192167 (php-7.4.0RC1 note)

Function ReflectionType::__toString() is deprecated

tests/phpunit/unit/includes/watcheditem/NoWriteWatchedItemStoreUnitTest.php:225
tests/phpunit/MediaWikiUnitTestCase.php:110
maintenance/doMaintenance.php:99

Cannot use "parent" when current class scope has no parent (php-7.4.0RC1 note)

Deprecated: Array and string offset access syntax with curly braces is deprecated in avro-php lib. (php-7.4.0RC1 note)

MWExceptionHandlerTest::testGetRedactedTrace: The stacktrace must have a function having an object has parameter; Failed asserting that false is true.

Details

Subject	Repo	Branch	Lines +/-
SectionProfiler: Do not attempt to use null values as arrays	mediawiki/core	REL1_31	+9 -3
Fix PHP 7.4 compatibility	mediawiki/extensions/TextExtracts	master	+4 -2
layout: [extensions] Add PHP74 tests as voting for master only	integration/config	master	+1 -1
resourceloader: Error in FileModule if provided path is a directory	mediawiki/core	master	+4 -2
layout: [MediaWiki] Add PHP74 tests as voting for master	integration/config	master	+3 -3
SectionProfiler: Do not attempt to use null values as arrays	mediawiki/core	master	+9 -3
UnregisteredLocalFile: fix PHP 7.4 warnings	mediawiki/core	master	+2 -2
layout: [skins] Add PHP74 tests as voting for master	integration/config	master	+2 -1
Fix MWExceptionHandlerTest on PHP 7.4	mediawiki/core	master	+16 -2
PHP 7.4 fixes	mediawiki/core	master	+14 -10
Travis: test on PHP 7.4, allowing failures	mediawiki/core	master	+4 -1
Update remex-html library to 2.1.0	mediawiki/core	master	+2 -2
Update remex-html to 2.1.0	mediawiki/vendor	master	+531 -56
services: Do not use deprecated ReflectionType::__toString() in tests	mediawiki/core	master	+10 -1
protocol: Fix compatibility with PHP 7.4	avro-php	master	+4 -4

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdforrester-WMF	T247658 Make Wikimedia Production MediaWiki compatible with PHP 7.4
Resolved	Jdforrester-WMF	T233012 Make MediaWiki core compatible with PHP 7.4
Resolved	cscott	T233062 Tag new release of remex-html
Resolved	Reedy	T233165 Tag a new release of avro-php
Resolved	None	T192167 Upgrade PHPUnit from 4/6 to 8
Resolved	Daimona	T234597 Phase out PHPUnit expected exception annotations from tests
Resolved	Jdforrester-WMF	T192166 Drop HHVM support from MediaWiki
Resolved	Jdforrester-WMF	T234062 ci-src-setup job (used by mediawiki-core-php72-phan-docker) is still running on PHP 7.0.33
Resolved	Jdforrester-WMF	T234384 Drop HHVM from CI
Resolved	jijiki	T229792 Remove HHVM from production
Resolved	awight	T236019 Remove HHVM support from Quibble
Resolved	jijiki	T239054 Reimage all mediawiki servers
Resolved	Michael	T237164 Wikibase's cache/integration-tests incompatible with PHPUnit 8
Resolved	Rosalie_WMDE	T260915 Move DataValues away from “withered” PHPUnit 4
Resolved	Jdforrester-WMF	T236132 Provide CI testing for PHP 7.4
Resolved	Reedy	T242980 implode() the wrong way round in lightncandy
Resolved	Jdforrester-WMF	T247214 Re-enable PHP74 in gate for skin-quibble

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

RazeSoldier updated the task description. (Show Details)Sep 16 2019, 2:28 PM

Change 537139 had a related patch set uploaded (by TK-999; owner: TK-999):
[avro-php@master] protocol: Fix compatibility with PHP 7.4

https://gerrit.wikimedia.org/r/537139

gerritbot added a project: Patch-For-Review.Sep 16 2019, 3:18 PM

The issue in the RemexHTML lib seems to have been fixed in https://gerrit.wikimedia.org/r/c/mediawiki/libs/RemexHtml/+/531022.

In T233012#5496253, @TK-999 wrote:

The issue in the RemexHTML lib seems to have been fixed in https://gerrit.wikimedia.org/r/c/mediawiki/libs/RemexHtml/+/531022.

Yep, but MW is still using the old version. May need update dependence.

Change 537181 had a related patch set uploaded (by TK-999; owner: TK-999):
[mediawiki/core@master] services: Do not use deprecated ReflectionType::__toString() in tests

https://gerrit.wikimedia.org/r/537181

Change 537188 had a related patch set uploaded (by TK-999; owner: TK-999):
[mediawiki/core@master] SectionProfiler: Do not attempt to use null values as arrays

https://gerrit.wikimedia.org/r/537188

Change 537139 merged by jenkins-bot:
[avro-php@master] protocol: Fix compatibility with PHP 7.4

https://gerrit.wikimedia.org/r/537139

Change 537188 merged by jenkins-bot:
[mediawiki/core@master] SectionProfiler: Do not attempt to use null values as arrays

https://gerrit.wikimedia.org/r/537188

Reedy triaged this task as Low priority.Sep 16 2019, 11:42 PM

Reedy added a project: MediaWiki-General.

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.23; 2019-09-17).Sep 17 2019, 12:00 AM

Reedy mentioned this in T233062: Tag new release of remex-html.Sep 17 2019, 12:11 AM

Change 537181 merged by jenkins-bot:
[mediawiki/core@master] services: Do not use deprecated ReflectionType::__toString() in tests

https://gerrit.wikimedia.org/r/537181

Daimona subscribed.Sep 17 2019, 10:12 AM

TK-999 added a subtask: T233165: Tag a new release of avro-php.Sep 17 2019, 9:53 PM

cscott closed subtask T233062: Tag new release of remex-html as Resolved.Sep 18 2019, 4:16 PM

Change 537685 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Update remex-html library to 2.1.0

https://gerrit.wikimedia.org/r/537685

Change 537779 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@master] Update remex-html to 2.1.0

https://gerrit.wikimedia.org/r/537779

Change 537779 merged by jenkins-bot:
[mediawiki/vendor@master] Update remex-html to 2.1.0

https://gerrit.wikimedia.org/r/537779

Change 537685 merged by jenkins-bot:
[mediawiki/core@master] Update remex-html library to 2.1.0

https://gerrit.wikimedia.org/r/537685

I think we can announce support for PHP 7.4 in MediaWiki 1.35 release.

RazeSoldier added a subtask: T192167: Upgrade PHPUnit from 4/6 to 8.Sep 20 2019, 5:11 PM

Reedy updated the task description. (Show Details)Sep 20 2019, 5:50 PM

Ricordisamoa subscribed.Sep 21 2019, 5:55 AM

TK-999 closed subtask T233165: Tag a new release of avro-php as Resolved.Sep 25 2019, 4:55 PM

TK-999 reopened subtask T233165: Tag a new release of avro-php as Open.

Tagging MW-1.35-release, make this ticket as a MW 1.35 release blocker.

There are enough reasons to think that the next version (1.35) supports PHP 7.4 is a good choice.

MaxSem changed the status of subtask T192167: Upgrade PHPUnit from 4/6 to 8 from Stalled to Open.Oct 4 2019, 6:16 AM

Change 541657 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] Travis: test on PHP 7.4, allowing failures

https://gerrit.wikimedia.org/r/541657

Reedy closed subtask T233165: Tag a new release of avro-php as Resolved.Oct 8 2019, 11:50 PM

Reedy updated the task description. (Show Details)Oct 8 2019, 11:52 PM

Change 541657 merged by jenkins-bot:
[mediawiki/core@master] Travis: test on PHP 7.4, allowing failures

https://gerrit.wikimedia.org/r/541657

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 9 2019, 1:00 AM

Jdforrester-WMF changed the status of subtask T236132: Provide CI testing for PHP 7.4 from Open to Stalled.Oct 30 2019, 3:33 PM

Change 552394 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] PHP 7.4 fixes

https://gerrit.wikimedia.org/r/552394

Change 552394 merged by jenkins-bot:
[mediawiki/core@master] PHP 7.4 fixes

https://gerrit.wikimedia.org/r/552394

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.8; 2019-11-26); removed MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Nov 22 2019, 3:00 PM

Jdforrester-WMF changed the status of subtask T236132: Provide CI testing for PHP 7.4 from Stalled to Open.Dec 2 2019, 5:05 PM

Jdforrester-WMF closed subtask T236132: Provide CI testing for PHP 7.4 as Resolved.Dec 2 2019, 5:40 PM

Updated with result from 7.4.0 (final) test run on master: https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php74-docker/1/console

In T233012#5705981, @Jdforrester-WMF wrote:

Updated with result from 7.4.0 (final) test run on master: https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php74-docker/1/console

Weird. I skimmed through PHP 7.4 UPGRADING, and couldn't find anything interesting. I've also tested the faulty code on 3v4l (I still have to install PHP 7.4 locally), but the trace seems to have an object there.

Change 554202 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] WIP: fix PHP 7.4 error

https://gerrit.wikimedia.org/r/554202

In T233012#5706137, @Daimona wrote:

Weird. I skimmed through PHP 7.4 UPGRADING, and couldn't find anything interesting. I've also tested the faulty code on 3v4l (I still have to install PHP 7.4 locally), but the trace seems to have an object there.

Here:

zend.exception_ignore_args is a new INI directive for including or excluding arguments from stack traces generated from exceptions.

And of course, it's not documented in https://www.php.net/manual/en/ini.list.php.

https://gerrit.wikimedia.org/r/554202 fixes it.

Change 554202 merged by jenkins-bot:
[mediawiki/core@master] Fix MWExceptionHandlerTest on PHP 7.4

https://gerrit.wikimedia.org/r/554202

Jdforrester-WMF updated the task description. (Show Details)Dec 3 2019, 4:19 PM

Change 554326 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [mediawiki/core] Test with PHP74 for master

https://gerrit.wikimedia.org/r/554326

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.10; 2019-12-10); removed MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Dec 3 2019, 5:00 PM

In T233012#5707710, @MaxSem wrote:

Here:

zend.exception_ignore_args is a new INI directive for including or excluding arguments from stack traces generated from exceptions.

Ah, nice catch. Sometimes it's surpsising to see how well the human brain can skip the exact section of a document that you're looking for.

Change 554368 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [skins] Add PHP74 tests as voting for master

https://gerrit.wikimedia.org/r/554368

Change 554368 merged by jenkins-bot:
[integration/config@master] layout: [skins] Add PHP74 tests as voting for master

https://gerrit.wikimedia.org/r/554368

Mentioned in SAL (#wikimedia-releng) [2019-12-03T21:24:16Z] <James_F> Enabling PHP74 tests as voting for MW skins T233012

SitRep:

Core itself works, but I'm not sure about all tarball extensions yet, so won't enable this there.

Skins were all working except Minerva, now fixed in T239727: MinervaNeue is not compatible with PHP7.4, so that's enabled.

Extensions found broken so far are T239726: ConfirmEdit is not compatible with PHP7.4, T239757: CirrusSearch is not compatible with PHP7.4, T239759: TimedMediaHandler is not compatible with PHP7.4, T239760: WikibaseLib is not compatible with PHP7.4, T239761: Wikibase is not compatible with PHP7.4.

Change 554669 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] UnregisteredLocalFile: fix PHP 7.4 warnings

https://gerrit.wikimedia.org/r/554669

Change 554669 merged by jenkins-bot:
[mediawiki/core@master] UnregisteredLocalFile: fix PHP 7.4 warnings

https://gerrit.wikimedia.org/r/554669

In T233012#5710545, @Jdforrester-WMF wrote:

SitRep:

Core itself works, but I'm not sure about all tarball extensions yet, so won't enable this there.

Skins were all working except Minerva, now fixed in T239727: MinervaNeue is not compatible with PHP7.4, so that's enabled.

Extensions found broken so far are T239726: ConfirmEdit is not compatible with PHP7.4, T239757: CirrusSearch is not compatible with PHP7.4, T239759: TimedMediaHandler is not compatible with PHP7.4, T239760: WikibaseLib is not compatible with PHP7.4, T239761: Wikibase is not compatible with PHP7.4.

Skins are now un-enabled because of T242980. Fun.

Jdforrester-WMF closed subtask T192167: Upgrade PHPUnit from 4/6 to 8 as Resolved.Jan 23 2020, 4:17 PM

In as much as anyone owns this, I do.

Jdforrester-WMF raised the priority of this task from Low to High.Feb 26 2020, 6:24 PM

Jdforrester-WMF moved this task from INBOX to New Work on the Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)) board.

Reedy closed subtask T242980: implode() the wrong way round in lightncandy as Resolved.Mar 8 2020, 11:14 PM

Reedy added a subtask: T247214: Re-enable PHP74 in gate for skin-quibble.Mar 8 2020, 11:25 PM

Jdforrester-WMF closed subtask T247214: Re-enable PHP74 in gate for skin-quibble as Resolved.Mar 11 2020, 6:55 PM

Change 579039 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] ResourceLoaderFileModule: Error if provided file is actually a directory

https://gerrit.wikimedia.org/r/579039

Change 554326 merged by jenkins-bot:
[integration/config@master] layout: [MediaWiki] Add PHP74 tests as voting for master

https://gerrit.wikimedia.org/r/554326

Mentioned in SAL (#wikimedia-releng) [2020-03-11T22:23:52Z] <James_F> Zuul: [MediaWiki] Add PHP74 tests as voting for master T233012

Change 579076 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [extensions] Add PHP74 tests as voting for master only

https://gerrit.wikimedia.org/r/579076

Change 579039 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Error in FileModule if provided path is a directory

https://gerrit.wikimedia.org/r/579039

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.24; 2020-03-17); removed MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Mar 12 2020, 2:00 AM

Change 579076 merged by jenkins-bot:
[integration/config@master] layout: [extensions] Add PHP74 tests as voting for master only

https://gerrit.wikimedia.org/r/579076

Mentioned in SAL (#wikimedia-releng) [2020-03-12T16:59:40Z] <James_F> Zuul: Make PHP74 tests voting for extensions T233012

Mentioned in SAL (#wikimedia-releng) [2020-03-12T17:21:15Z] <James_F> Zuul: Make PHP74 tests voting for almost everything T233012

Change 579583 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TextExtracts@master] Fix PHP 7.4 compatibility

https://gerrit.wikimedia.org/r/579583

Change 579583 merged by jenkins-bot:
[mediawiki/extensions/TextExtracts@master] Fix PHP 7.4 compatibility

https://gerrit.wikimedia.org/r/579583

Krinkle added a subtask: T247637: OAuth PHP 7.4 failures.Mar 13 2020, 10:57 PM

Reedy closed subtask T247637: OAuth PHP 7.4 failures as Resolved.Mar 13 2020, 11:06 PM

Reedy mentioned this in T247658: Make Wikimedia Production MediaWiki compatible with PHP 7.4.Mar 14 2020, 11:31 AM

Reedy removed a subtask: T247637: OAuth PHP 7.4 failures.

Reedy added a parent task: T247658: Make Wikimedia Production MediaWiki compatible with PHP 7.4.

Jdforrester-WMF closed this task as Resolved.Mar 16 2020, 6:57 PM

Can we announce that MW 1.35 supports PHP 7.4?

I was waiting for extension support to be good enough, but we didn't reach the threshold where I was comfortable enforcing it, sadly. :-(

Examples of what needs to be fixed?

Don't remember off-hand; I think Scribunto and Wikibase had issues, but it was months ago. :-( Will re-check.

Change 644651 had a related patch set uploaded (by Reedy; owner: TK-999):
[mediawiki/core@REL1_31] SectionProfiler: Do not attempt to use null values as arrays

https://gerrit.wikimedia.org/r/644651

Change 644651 merged by jenkins-bot:
[mediawiki/core@REL1_31] SectionProfiler: Do not attempt to use null values as arrays

https://gerrit.wikimedia.org/r/644651

ReleaseTaggerBot added a project: MW-1.31-release-notes.Dec 2 2020, 3:00 AM