Page MenuHomePhabricator
Create Task
Maniphest T192166

Drop HHVM support from MediaWiki
Closed, ResolvedPublic
Actions

Description

Not soon, and definitely after these have been completed first:

Some things to search for: 'HHVM' (case-insensitive), '\bhph', 'register_postsend_function'

Details

SubjectRepoBranchLines +/-
Drop HHVM support from MediaWikimediawiki/coremaster+7 -26
mediawiki: remove the PHP/HHVM conditionals from the codeoperations/puppetproduction+13 -136
PHPVersionCheck: Simplify warning as part of dropping HHVM supportmediawiki/coremaster+17 -48
Drop HHVM supportmediawiki/vagrantmaster+26 -373
Hard-deprecate wfIsHHVM()mediawiki/coremaster+1 -1
Drop HHVM support from MediaWikimediawiki/coreREL1_34+7 -26
Remove HHVM checkmediawiki/extensions/wikihieromaster+4 -28
WIP: kill HHVM specific hacksmediawiki/coremaster+40 -339
Drop HHVM supportmediawiki/php/wikidiff2master+0 -138
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedJdforrester-WMFT247658 Make Wikimedia Production MediaWiki compatible with PHP 7.4
 ResolvedJdforrester-WMFT233012 Make MediaWiki core compatible with PHP 7.4
 ResolvedMaxSemT216734 Drop devDependency on phpunit-mock-objects, which is abandoned and warns against use
 ResolvedNoneT192167 Upgrade PHPUnit from 4/6 to 8
 ResolvedReedyT196206 Bump symfony libraries when we no longer need hhvm support
 ResolvedDaimonaT220589 Support phan in MediaWiki's default composer.json
 ResolvedDaimonaT231710 Recommend PHP7-only features after dropping HHVM support
 ResolvedaaronT232128 Make MultiHttpClient use CURLMOPT_MAX_HOST_CONNECTIONS and reuse connections
 ResolvedMaxSemT234236 Drop HHVM support from MediaWiki-Vagrant
 ResolvedReedyT227242 Deploy WebAuthn to Wikimedia Wikis
 ResolvedDaimonaT231636 Butcher the list of phan suppressions in MW core
 ResolvedReedyT235266 Composer Library Updates, late 2019/early 2020 edition
 ResolvedReedyT235233 Stop using PHP5 versions of ruflin/elastica and elasticsearch/elasticsearch
 ResolvedJdforrester-WMFT234512 Archive HHVM Phabricator project
 ResolvedKrinkleT235160 Decide whether extensions should set a PHP version requirement in composer.json
 ResolvedKrinkleT235142 Clean up mediawiki-config from HHVM-related configuration
 ResolvedJdforrester-WMFT192166 Drop HHVM support from MediaWiki
 ResolvedJdforrester-WMFT234062 ci-src-setup job (used by mediawiki-core-php72-phan-docker) is still running on PHP 7.0.33
 ResolvedJdforrester-WMFT234384 Drop HHVM from CI
 ResolvedjijikiT229792 Remove HHVM from production
 ResolvedawightT236019 Remove HHVM support from Quibble
 ResolvedjijikiT239054 Reimage all mediawiki servers

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Krinkle added a comment.Oct 12 2018, 6:45 PM

While we'll have to drop HHVM support soon, we're migrating to PHP 7 even sooner. So this isn't currently blocking PHP 7.0 support.

Per T176370, the initial production roll-out will likely use PHP 7.2, or maybe PHP 7.3 even (we're currently evaluating the viability of fast-tracking that and do the gradual roll-out straight from HHVM to PHP 7.3 for user traffic). More details and question at T176370, but it does mean we won't drop HHVM until after PHP 7.3 support is finalised.

Jdforrester-WMF added a subtask: T176370: Migrate to PHP 7 in WMF production.Oct 12 2018, 6:49 PM
cscott added a parent task: T204945: Deprecate one of the Preprocessor implementations for 1.34.Oct 18 2018, 6:37 PM
• GTirloni unsubscribed.Dec 20 2018, 6:46 PM
Reedy mentioned this in T212642: Quiz extension incompatibility with HHVM: RuntimeException: Requested template, Quiz, is not callable.Dec 28 2018, 6:15 PM
Krinkle removed a parent task: T204945: Deprecate one of the Preprocessor implementations for 1.34.Feb 5 2019, 12:00 AM
Anomie mentioned this in T216102: Determine which PHP version to target with Parsoid.Feb 14 2019, 4:45 PM
Jdforrester-WMF added a parent task: T220589: Support phan in MediaWiki's default composer.json.Apr 11 2019, 12:14 AM
gerritbot added a comment.Jun 11 2019, 12:37 AM

Change 434973 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] [DNM][WIP][GOSH] Drop HHVM support from MediaWiki

https://gerrit.wikimedia.org/r/434973

Jdforrester-WMF mentioned this in T216165: Drop PHP 7.0 support from MediaWiki.Jul 6 2019, 12:44 AM
Krinkle mentioned this in T119818: hhvm unable to stat files.Jul 11 2019, 10:45 PM
Michael mentioned this in T228855: Fix broken WikibaseQualityConstraints tests.Jul 24 2019, 4:19 PM
cscott mentioned this in T213494: Installing composer modules for deployment.Jul 31 2019, 9:34 PM
Dzahn subscribed.Aug 5 2019, 9:34 PM

There is now the Hiera key profile::mediawiki::install_hhvm that let's us remove HHVM entirely from appservers individually.

Simetrical mentioned this in T228342: Define criteria for setting explicit PHP support target for MediaWiki.Aug 13 2019, 11:16 AM
abi_ mentioned this in T231270: Failing build process: Variadic params with type constraints are not supported in non-Hack files.Aug 27 2019, 7:15 AM
Daimona mentioned this in T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min.Aug 29 2019, 6:09 PM
Daimona added a parent task: T231710: Recommend PHP7-only features after dropping HHVM support.Aug 31 2019, 8:28 AM
Daimona added a parent task: T231636: Butcher the list of phan suppressions in MW core.Sep 3 2019, 4:45 PM
gerritbot added a comment.Sep 4 2019, 8:01 PM

Change 534521 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] [DNM] layout: Drop HHVM testing from all quibble jobs

https://gerrit.wikimedia.org/r/534521

Reedy added a parent task: T232128: Make MultiHttpClient use CURLMOPT_MAX_HOST_CONNECTIONS and reuse connections.Sep 10 2019, 3:22 PM
kostajh subscribed.Sep 24 2019, 11:07 AM
Daimona subscribed.Sep 24 2019, 4:47 PM

Will this happen in 1.35?

Krinkle added a comment.Sep 24 2019, 4:50 PM

I think we're trying to make it happen as part of 1.34, might need to be backported at the last minute.

Even we don't make it, what will happen is that we drop support in documentation, but that it might (accidentally) work during the first .0 release, but we have no intention of supporting it officially. Once WMF has migrated away, all testing on master and REL1_34+ will cease, possibly for older branches as well (to be determined).

Daimona added a comment.Sep 24 2019, 4:56 PM
In T192166#5520176, @Krinkle wrote:

I think we're trying to make it happen as part of 1.34, might need to be backported at the last minute.

Huh, that soon? I thought we would deprecate HHVM support in 1.34, and remove it in 1.35.

Even we don't make it, what will happen is that we drop support in documentation, but that it might (accidentally) work during the first .0 release, but we have no intention of supporting it officially. Once WMF has migrated away, all testing on master and REL1_34+ will cease, possibly for older branches as well (to be determined).

Good, thanks. So, basically, we can update the docs and unblock these patches as soon as 1.34 is cut?

Krinkle added a comment.Sep 24 2019, 5:41 PM

Once HHVM is completely and disabled from WMF production servers relating to MediaWiki and e.g. 1-2 weeks have passed, then we can immediately remove support for it in master.

For documentation it is fine to already remove it. It has been stated for several releases already that HHVM only works for WMF and will be removed as soon as the migration is completed. We will not be supporting HHVM for the full 1.34 release cycle.

Krinkle added a project: TechCom.Sep 25 2019, 8:10 PM
Krinkle moved this task from Inbox to Watching on the TechCom board.
Daimona added a comment.Sep 26 2019, 9:56 AM

Not HHVM-related, but posting here before I forget: https://codesearch.wmflabs.org/search/?q=void%20PHP%20*7.%2Barning&i=nope&files=&repos= can also be cleaned up.

gerritbot added a comment.Sep 26 2019, 12:32 PM

Change 539326 had a related patch set uploaded (by Giuseppe Lavagetto; owner: Giuseppe Lavagetto):
[operations/puppet@production] mediawiki: remove the PHP/HHVM conditionals from the code

https://gerrit.wikimedia.org/r/539326

Jdforrester-WMF added a comment.Sep 26 2019, 3:08 PM
In T192166#5520214, @Daimona wrote:
In T192166#5520176, @Krinkle wrote:

I think we're trying to make it happen as part of 1.34, might need to be backported at the last minute.

Huh, that soon? I thought we would deprecate HHVM support in 1.34, and remove it in 1.35.

It was never really supported, and deprecated in 1.31. It's only dragged on for so long because of Wikimedia production.

Good, thanks. So, basically, we can update the docs and unblock these patches as soon as 1.34 is cut?

No.

Daimona added a subtask: T234062: ci-src-setup job (used by mediawiki-core-php72-phan-docker) is still running on PHP 7.0.33.Sep 27 2019, 5:57 PM
Lucas_Werkmeister_WMDE subscribed.Sep 30 2019, 2:48 PM
Mainframe98 mentioned this in T234236: Drop HHVM support from MediaWiki-Vagrant.Sep 30 2019, 3:54 PM
Mainframe98 added a parent task: T234236: Drop HHVM support from MediaWiki-Vagrant.
Jdforrester-WMF added a subtask: T234384: Drop HHVM from CI.Oct 1 2019, 9:45 PM
Jdforrester-WMF changed the status of subtask T234384: Drop HHVM from CI from Open to Stalled.
Jdforrester-WMF changed the status of subtask T234384: Drop HHVM from CI from Stalled to Open.Oct 2 2019, 6:52 PM
gerritbot added a comment.Oct 2 2019, 9:33 PM

Change 540488 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Drop HHVM support from MediaWiki

https://gerrit.wikimedia.org/r/540488

gerritbot added a comment.Oct 2 2019, 10:23 PM

Change 540488 merged by jenkins-bot:
[mediawiki/core@master] Drop HHVM support from MediaWiki

https://gerrit.wikimedia.org/r/540488

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 2 2019, 11:00 PM
gerritbot added a comment.Oct 2 2019, 11:15 PM

Change 540502 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/vagrant@master] Drop HHVM support

https://gerrit.wikimedia.org/r/540502

Krinkle mentioned this in T207523: JsonContent incorrectly reports invalid JSON is valid, only on HHVM.Oct 3 2019, 2:32 AM
Krinkle mentioned this in T76831: HHVM's xhprof_frame_begin() calls from XhprofFrame constructor closed too soon.Oct 3 2019, 3:23 AM
Krinkle mentioned this in T133674: HHVM is leaking memory on the API appservers.
Krinkle mentioned this in T91056: Some letters (initial characters of page titles) not being correctly capitalised.Oct 3 2019, 3:27 AM
Krinkle mentioned this in T229379: On zh.wikipedia.org, MediaWiki wrongly interprets an article about main pages as the wiki's main page.
Krinkle mentioned this in T178242: On HHVM, "CACHE_MEMCACHED" shortcut should select native client (default PHP implementation has issues).Oct 3 2019, 3:30 AM
Krinkle mentioned this in T157213: HHVM and PHP handle non-static input to call_user_func_array() different.
Krinkle mentioned this in T153881: Don't require eval() (via TemplateParser) to run MediaWiki.
Krinkle mentioned this in T78558: HHVM segfault when not passing parameter by reference when required.Oct 3 2019, 3:32 AM
Krinkle mentioned this in T126473: CI slaves should have HHVM call the exception user handler so we have useful stack trace on fatal errors.
Krinkle mentioned this in T115781: Grep for func_get_arg()/func_get_args() and fix an HHVM reference bugs.Oct 3 2019, 3:38 AM
Bugreporter mentioned this in T234512: Archive HHVM Phabricator project.Oct 3 2019, 8:32 AM
Peachey88 added a subtask: T234512: Archive HHVM Phabricator project.Oct 3 2019, 9:23 AM
gerritbot added a comment.Oct 4 2019, 7:10 AM

Change 540767 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/php/wikidiff2@master] Drop HHVM support

https://gerrit.wikimedia.org/r/540767

gerritbot added a comment.Oct 4 2019, 8:18 AM

Change 540767 merged by jenkins-bot:
[mediawiki/php/wikidiff2@master] Drop HHVM support

https://gerrit.wikimedia.org/r/540767

Daimona updated the task description. (Show Details)Oct 6 2019, 8:38 AM
gerritbot added a comment.Oct 7 2019, 5:42 AM

Change 541141 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/wikihiero@master] Remove HHVM check

https://gerrit.wikimedia.org/r/541141

gerritbot added a comment.Oct 7 2019, 5:46 AM

Change 541143 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] Hard-deprecate wfIsHHVM()

https://gerrit.wikimedia.org/r/541143

gerritbot added a comment.Oct 7 2019, 5:57 AM

Change 426165 abandoned by MaxSem:
WIP: kill HHVM specific hacks

https://gerrit.wikimedia.org/r/426165

gerritbot added a comment.Oct 7 2019, 2:01 PM

Change 541141 merged by jenkins-bot:
[mediawiki/extensions/wikihiero@master] Remove HHVM check

https://gerrit.wikimedia.org/r/541141

MaxSem mentioned this in rEHIEdc5dda074699: Remove HHVM check.Oct 7 2019, 2:11 PM
gerritbot added a comment.Oct 7 2019, 2:33 PM

Change 541266 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@REL1_34] Drop HHVM support from MediaWiki

https://gerrit.wikimedia.org/r/541266

gerritbot added a comment.Oct 7 2019, 2:44 PM

Change 541266 merged by jenkins-bot:
[mediawiki/core@REL1_34] Drop HHVM support from MediaWiki

https://gerrit.wikimedia.org/r/541266

ReleaseTaggerBot added a project: MW-1.34-notes.Oct 7 2019, 3:00 PM
gerritbot added a comment.Oct 7 2019, 3:28 PM

Change 541143 merged by jenkins-bot:
[mediawiki/core@master] Hard-deprecate wfIsHHVM()

https://gerrit.wikimedia.org/r/541143

Jdforrester-WMF closed this task as Resolved.Oct 7 2019, 5:28 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF closed subtask T234384: Drop HHVM from CI as Resolved.

I'm declaring this Resolved.

daniel subscribed.Oct 7 2019, 5:33 PM
In T192166#5552909, @Jdforrester-WMF wrote:

I'm declaring this Resolved.

Macro itshappening:

Ladsgroup changed the status of subtask T234512: Archive HHVM Phabricator project from Stalled to Open.Oct 7 2019, 8:03 PM
gerritbot added a comment.Oct 10 2019, 4:28 AM

Change 540502 merged by jenkins-bot:
[mediawiki/vagrant@master] Drop HHVM support

https://gerrit.wikimedia.org/r/540502

Jdforrester-WMF closed subtask T234062: ci-src-setup job (used by mediawiki-core-php72-phan-docker) is still running on PHP 7.0.33 as Resolved.Oct 10 2019, 6:54 PM
Reedy added a parent task: T235233: Stop using PHP5 versions of ruflin/elastica and elasticsearch/elasticsearch.Oct 10 2019, 11:34 PM
gerritbot added a comment.Oct 11 2019, 1:36 AM

Change 434973 merged by jenkins-bot:
[mediawiki/core@master] PHPVersionCheck: Simplify warning as part of dropping HHVM support

https://gerrit.wikimedia.org/r/434973

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.2; 2019-10-15); removed MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 11 2019, 2:00 AM
Krinkle removed a parent task: T192167: Upgrade PHPUnit from 4/6 to 8.Oct 11 2019, 5:56 PM
Krinkle removed a parent task: T231636: Butcher the list of phan suppressions in MW core.Oct 12 2019, 4:51 PM
Krinkle mentioned this in T231636: Butcher the list of phan suppressions in MW core.
Krinkle mentioned this in T235266: Composer Library Updates, late 2019/early 2020 edition.Oct 12 2019, 4:53 PM
Krinkle mentioned this in T227242: Deploy WebAuthn to Wikimedia Wikis.
Krinkle added a parent task: T227242: Deploy WebAuthn to Wikimedia Wikis.
Krinkle removed a subtask: T176370: Migrate to PHP 7 in WMF production.Oct 12 2019, 4:55 PM

Drawing the line between "stuff that happens post-HHVM" and "stuff required for WMF to start using PHP7" at this task. It's useful to track al the things the migration unblocked, so I've re-added them as parent tasks here (sorry about the noise), and instead broke the link with T176370 in order to keep the tree somewhat sane.

Krinkle added a parent task: T192167: Upgrade PHPUnit from 4/6 to 8.Oct 12 2019, 4:57 PM
Krinkle added a parent task: T231636: Butcher the list of phan suppressions in MW core.
Krinkle added a parent task: T235266: Composer Library Updates, late 2019/early 2020 edition.
Krinkle removed a subtask: T234512: Archive HHVM Phabricator project.Oct 12 2019, 5:00 PM
Krinkle added a parent task: T234512: Archive HHVM Phabricator project.
gerritbot added a comment.Oct 14 2019, 1:31 PM

Change 539326 merged by Effie Mouzeli:
[operations/puppet@production] mediawiki: remove the PHP/HHVM conditionals from the code

https://gerrit.wikimedia.org/r/539326

Jdforrester-WMF removed a subtask: T235160: Decide whether extensions should set a PHP version requirement in composer.json.Oct 15 2019, 3:17 PM
Jdforrester-WMF added a parent task: T235160: Decide whether extensions should set a PHP version requirement in composer.json.
Krinkle added a parent task: T235142: Clean up mediawiki-config from HHVM-related configuration.Oct 16 2019, 4:57 PM
Aklapper mentioned this in T262477: Convert EnhanceContactForm to use extension registration.Sep 24 2020, 9:27 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL