In T196206#5550248, @Reedy wrote:

https://github.com/symfony/symfony/blob/4.0/composer.json and https://github.com/symfony/symfony/blob/4.4/composer.json have ^7.1.3

https://github.com/symfony/symfony/blob/master/composer.json (to be 5.0 I guess) has ^7.2.9

https://github.com/symfony/symfony/commit/d94d9d792c445240cbaf80c7b413795b71aff718 - I wonder if there's any specific reason to select 7.2.9 as the min supported PHP 7.2, that dates to 16 Aug 2018, well before that commit in May

Something for us to bare in mind when we come to bumping to PHP 7.2

On https://github.com/symfony/symfony/blob/3.4/composer.json#L19 we're good with ^5.5.9|>=7.0.8

But of course, we only require PHP 7.0.0. I suspect most people will have a newer point release... But it does mean our require-dev symfony/yaml will conflict

Filing a separate task

Re-stalling as we have nothing to do until we bump to 7.2 (do we have a task for that to bump this against)

Didn't we already do that with T216166: Drop PHP 7.1 support from MediaWiki?

In T196206#5550256, @Mainframe98 wrote:

In T196206#5550248, @Reedy wrote:

https://github.com/symfony/symfony/blob/4.0/composer.json and https://github.com/symfony/symfony/blob/4.4/composer.json have ^7.1.3

https://github.com/symfony/symfony/blob/master/composer.json (to be 5.0 I guess) has ^7.2.9

https://github.com/symfony/symfony/commit/d94d9d792c445240cbaf80c7b413795b71aff718 - I wonder if there's any specific reason to select 7.2.9 as the min supported PHP 7.2, that dates to 16 Aug 2018, well before that commit in May

Something for us to bare in mind when we come to bumping to PHP 7.2

On https://github.com/symfony/symfony/blob/3.4/composer.json#L19 we're good with ^5.5.9|>=7.0.8

But of course, we only require PHP 7.0.0. I suspect most people will have a newer point release... But it does mean our require-dev symfony/yaml will conflict

Filing a separate task

Re-stalling as we have nothing to do until we bump to 7.2 (do we have a task for that to bump this against)

Didn't we already do that with T216166: Drop PHP 7.1 support from MediaWiki?

Not quite

https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/516829/

Why this missed composer.json?

Because at that point we still had to support HHVM, also one Docker image used during build is still running 7.0, James is working on bumping it.

Just need to wait for that to be done

Change 541103 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@master] symfony 3.4.31 => 4.3.4

https://gerrit.wikimedia.org/r/541103

Change 541105 had a related patch set uploaded (by Jforrester; owner: Reedy):
[mediawiki/core@master] Upgrade symfony/yaml from 3.4.31 to 4.3.4

https://gerrit.wikimedia.org/r/541105

Change 541103 merged by jenkins-bot:
[mediawiki/vendor@master] Upgrade symfony/* from 3.4.31 to 4.3.4

https://gerrit.wikimedia.org/r/541103

Change 541105 merged by jenkins-bot:
[mediawiki/core@master] Upgrade symfony/yaml from 3.4.31 to 4.3.4

https://gerrit.wikimedia.org/r/541105