Page MenuHomePhabricator
Create Task
Maniphest T235142

Clean up mediawiki-config from HHVM-related configuration
Closed, ResolvedPublic
Actions

Description

Currently, there are quite a lot of special cases that are not needed anymore.

Status as of 2019-12-05:

Code search results

  • Mention in composer.lock from sebastian/environment which should go away in future when we bump PHPUnit.
  • Mentions in the upstream mongofill package used by Performance.
  • Documentation mention in 404.php and README which can be updated (but to what?).
  • Documentation mention in ServiceConfig.php of hhvm-fatal-error.php which has been… removed now?
  • Used in arclamp.php which presumably is also used by PHP72?
  • Documention mention in profiler.php abouse historical uses, and can stay.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

MaxSem created this task.Oct 10 2019, 3:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2019, 3:38 AM
MaxSem added a parent task: T176370: Migrate to PHP 7 in WMF production.Oct 10 2019, 3:38 AM
gerritbot added a comment.Oct 10 2019, 5:19 PM

Change 542178 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] tests: Declare strict types for the static test now HHVM is gone

https://gerrit.wikimedia.org/r/542178

gerritbot added a project: Patch-For-Review.Oct 10 2019, 5:19 PM

Change 542179 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Wikibase: Don't check to shard wmgWBSharedCacheKey for HHVM any more

https://gerrit.wikimedia.org/r/542179

gerritbot added a comment.Oct 10 2019, 5:19 PM

Change 542180 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Don't check to shard static config cache for HHVM any more

https://gerrit.wikimedia.org/r/542180

gerritbot added a comment.Oct 10 2019, 5:19 PM

Change 542181 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Drop HHVM special-case for SVG converter, no longer used

https://gerrit.wikimedia.org/r/542181

gerritbot added a comment.Oct 10 2019, 5:19 PM

Change 542182 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Drop special-case for PHP7 in PHPAutoPrepend, now always used

https://gerrit.wikimedia.org/r/542182

gerritbot added a comment.Oct 10 2019, 5:19 PM

Change 542183 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Drop nutcracker indirection for HHVM servers, just point to localhost

https://gerrit.wikimedia.org/r/542183

gerritbot added a comment.Oct 10 2019, 5:20 PM

Change 542184 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Drop HHVMRequestInit, never called

https://gerrit.wikimedia.org/r/542184

gerritbot added a comment.Oct 10 2019, 5:20 PM

Change 542185 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Drop HHVM XHProf and Arclamp code, no longer called

https://gerrit.wikimedia.org/r/542185

gerritbot added a comment.Oct 10 2019, 5:41 PM

Change 542178 merged by jenkins-bot:
[operations/mediawiki-config@master] tests: Declare strict types for the static test now HHVM is gone

https://gerrit.wikimedia.org/r/542178

Krinkle mentioned this in T235216: Consider socket files for MW-to-mcrouter connection.Oct 10 2019, 8:21 PM
gerritbot added a comment.Oct 10 2019, 9:46 PM

Change 542179 merged by jenkins-bot:
[operations/mediawiki-config@master] Wikibase: Don't check to shard wmgWBSharedCacheKey for HHVM any more

https://gerrit.wikimedia.org/r/542179

gerritbot added a comment.Oct 10 2019, 9:48 PM

Change 542180 merged by jenkins-bot:
[operations/mediawiki-config@master] Don't check to shard static config cache for HHVM any more

https://gerrit.wikimedia.org/r/542180

gerritbot added a comment.Oct 10 2019, 9:53 PM

Change 542181 merged by jenkins-bot:
[operations/mediawiki-config@master] Drop HHVM special-case for SVG converter, no longer used

https://gerrit.wikimedia.org/r/542181

gerritbot added a comment.Oct 10 2019, 9:56 PM

Change 542182 merged by jenkins-bot:
[operations/mediawiki-config@master] Drop special-case for PHP7 in PHPAutoPrepend, now always used

https://gerrit.wikimedia.org/r/542182

gerritbot added a comment.Oct 10 2019, 10:00 PM

Change 542183 merged by jenkins-bot:
[operations/mediawiki-config@master] Drop nutcracker indirection for HHVM servers, just point to localhost

https://gerrit.wikimedia.org/r/542183

gerritbot added a comment.Oct 12 2019, 4:27 AM

Change 542185 merged by jenkins-bot:
[operations/mediawiki-config@master] Drop HHVM XHProf and Arclamp code, no longer called

https://gerrit.wikimedia.org/r/542185

Krinkle added a subtask: T192166: Drop HHVM support from MediaWiki.Oct 16 2019, 4:57 PM
Krinkle removed a parent task: T176370: Migrate to PHP 7 in WMF production.
Krinkle subscribed.

Moving from tracked under "Stuff part of deploying PHP 7 properly" to instead above "Stuff unblocked by not having HHVM".

Krinkle unsubscribed.Oct 16 2019, 5:04 PM
Kizule moved this task from Backlog to Config - to process on the Wikimedia-Site-requests board.Nov 19 2019, 2:21 AM
gerritbot added a comment.Nov 26 2019, 4:23 PM

Change 553144 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] CommonSettings: Drop Scribunto special-case for HHVM, never reached

https://gerrit.wikimedia.org/r/553144

gerritbot added a comment.Nov 26 2019, 4:27 PM

Change 542184 merged by jenkins-bot:
[operations/mediawiki-config@master] Drop HHVMRequestInit, never called

https://gerrit.wikimedia.org/r/542184

gerritbot added a comment.Nov 26 2019, 4:34 PM

Change 553144 merged by jenkins-bot:
[operations/mediawiki-config@master] CommonSettings: Drop Scribunto special-case for HHVM, never reached

https://gerrit.wikimedia.org/r/553144

Stashbot added a comment.Nov 26 2019, 4:36 PM

Mentioned in SAL (#wikimedia-operations) [2019-11-26T16:36:27Z] <jforrester@deploy1001> Synchronized wmf-config/CommonSettings.php: Drop Scribunto special-case for HHVM, never reached T235142 (duration: 00m 52s)

Jdforrester-WMF updated the task description. (Show Details)Nov 26 2019, 4:42 PM
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Dec 5 2019, 12:27 PM

Change 554836 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[operations/mediawiki-config@master] profiler: Remove arclamp.php (was for HHVM)

https://gerrit.wikimedia.org/r/554836

gerritbot added a project: Patch-For-Review.Dec 5 2019, 12:27 PM
gerritbot added a comment.Dec 5 2019, 10:02 PM

Change 554836 merged by jenkins-bot:
[operations/mediawiki-config@master] profiler: Remove arclamp.php (was for HHVM)

https://gerrit.wikimedia.org/r/554836

Maintenance_bot removed a project: Patch-For-Review.Dec 5 2019, 10:10 PM
Jdforrester-WMF updated the task description. (Show Details)Dec 5 2019, 11:07 PM
Dzahn mentioned this in T237038: Archive operations/debs/hhvm repository.Jan 17 2020, 7:08 PM
gerritbot added a comment.Jan 17 2020, 7:43 PM

Change 565687 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] admin::ori: remove hhvm related commands

https://gerrit.wikimedia.org/r/565687

gerritbot added a project: Patch-For-Review.Jan 17 2020, 7:43 PM
gerritbot added a comment.Jan 17 2020, 7:49 PM

Change 565688 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] deployment-prep: remove install_hhvm from Hiera for mediawiki-parsoid10

https://gerrit.wikimedia.org/r/565688

gerritbot added a comment.Jan 17 2020, 8:10 PM

Change 565688 merged by Dzahn:
[operations/puppet@production] deployment-prep: remove install_hhvm from Hiera for mediawiki-parsoid10

https://gerrit.wikimedia.org/r/565688

gerritbot added a comment.Jan 17 2020, 9:01 PM

Change 565687 merged by Dzahn:
[operations/puppet@production] admin::ori: remove hhvm related commands

https://gerrit.wikimedia.org/r/565687

Maintenance_bot removed a project: Patch-For-Review.Jan 17 2020, 9:10 PM
Stashbot added a comment.Apr 16 2021, 7:11 PM

Mentioned in SAL (#wikimedia-releng) [2021-04-16T19:11:05Z] <Krinkle> Remove profile::mediawiki::install_hhvm: false Hiera config in Horizon for deployment-prep. This variable is no longer used. ref T235142

Aklapper added a project: Technical-Debt.Apr 24 2021, 1:08 PM
Krinkle closed this task as Resolved.Nov 18 2022, 1:43 AM
Krinkle claimed this task.
Krinkle added a project: Performance-Team.
gerritbot added a comment.Nov 18 2022, 1:55 AM

Change 858441 had a related patch set uploaded (by Krinkle; author: Krinkle):

[operations/mediawiki-config@master] build: Update to PHPUnit 9.5 and declare php requirement

https://gerrit.wikimedia.org/r/858441

gerritbot added a project: Patch-For-Review.Nov 18 2022, 1:55 AM
gerritbot added a comment.Nov 23 2022, 1:11 AM

Change 858441 merged by jenkins-bot:

[operations/mediawiki-config@master] build: Update to PHPUnit 9.5 and declare php requirement

https://gerrit.wikimedia.org/r/858441

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits