Page MenuHomePhabricator
Create Task
Maniphest T192167

Upgrade PHPUnit from 4/6 to 8
Closed, ResolvedPublic
Actions

Description

Once we drop support for HHVM and < PHP 7.2, we can drop support for PHPUnit 6, and deprecate our forwards/backwards-compat layer for PHPUnit 4.

This is blocked on: T192166: Drop HHVM support from MediaWiki

Progress estimate: https://codesearch.wmflabs.org/search/?q=PHPUnit_%7Cthis-%3EgetMock%5C(%7C%40expectExcep%7C-%3EsetExpectedException%7CPHPUnit4And6&i=nope&files=&repos=

Details

SubjectRepoBranchLines +/-
Don't silently discard exceptions in test suite setUp/tearDown methodsmediawiki/coremaster+58 -8
Remove MediaWikiIntegrationTestCase::assertTypemediawiki/coremaster+2 -21
Drop PHPUnit4And6Compat and PHPUnit6And8Compatmediawiki/coremaster+6 -148
tests: use explicit return type for setUp/tearDownmediawiki/extensions/WSOAuthmaster+15 -15
Upgrade to PHPUnit 8mediawiki/coremaster+12 -8
Kill hack for the PHPUnit migrationmediawiki/extensions/Scribuntomaster+1 -18
phpunit: delete MediaWikiTestResult and TestRunnermediawiki/coremaster+23 -92
Remove hack for PHPUnit's Stub interfacemediawiki/extensions/Echomaster+3 -15
Fix PHPUnit 8 warningsmediawiki/extensions/Wikibasemaster+24 -10
Remove phpunit/php-invoker from require-devmediawiki/coremaster+3 -1
Fix PHPUnit 8 warningsmediawiki/extensions/WikibaseLexememaster+7 -7
Fix PHPUnit 8 warningsmediawiki/extensions/WikibaseMediaInfomaster+1 -1
Fix PHPUnit 8 warningsmediawiki/extensions/Flowmaster+2 -2
Fix PHPUnit 8 warningsmediawiki/extensions/CirrusSearchmaster+15 -12
Fix PHPUnit 8 warningsmediawiki/extensions/WikibaseCirrusSearchmaster+1 -1
Overhaul TimeParser testsmediawiki/extensions/Wikibasemaster+53 -39
Hopefully fix the remaining PHPUnit 8 warningsmediawiki/extensions/Wikibasemaster+12 -12
Fix PHPUnit 8 warningsmediawiki/extensions/WikibaseCirrusSearchmaster+27 -27
Fix some more PHPUnit 8 warningsmediawiki/extensions/Wikibasemaster+38 -46
Fix PHPUnit 8 warningsmediawiki/extensions/WikibaseMediaInfomaster+5 -5
Fix PHPUnit 8 warningsmediawiki/extensions/CirrusSearchmaster+20 -16
Fix PHPUnit 8 warningmediawiki/extensions/AbuseFiltermaster+1 -1
Fix another PHPUnit 8 warningmediawiki/extensions/GeoDatamaster+2 -2
Fix PHPUnit 8 warningsmediawiki/extensions/EventLoggingmaster+6 -2
Fix PHPUnit 8 warningsmediawiki/extensions/FileImportermaster+14 -14
Fix some PHPUnit 8 warningsmediawiki/extensions/Wikibasemaster+73 -73
Fix PHPUnit 8 warningmediawiki/extensions/Citemaster+1 -1
Fix PHPUnit 8 warningsmediawiki/extensions/Flowmaster+1 -1
Fix PHPUnit 8 warningsmediawiki/extensions/Babelmaster+6 -6
Make tests pass with PHPUnit 8mediawiki/extensions/MobileFrontendmaster+10 -10
Use the right namespace for LanguageFactorymediawiki/extensions/Wikibasemaster+2 -2
assertEqualds() with delta is deprecatedmediawiki/extensions/GeoDatamaster+4 -4
PasswordFactoryTest: assertArraySubset() is deprecatedmediawiki/coremaster+3 -1
Make tests pass on PHPUnit 8mediawiki/extensions/PropertySuggestermaster+1 -1
Make tests pass on PHPUnit 8mediawiki/extensions/WikibaseLexememaster+9 -9
Preparation for PHPUnit 8 migrationmediawiki/extensions/Wikibasemaster+1 -1
Make tests pass on PHPUnit 8mediawiki/extensions/Wikidata.orgmaster+1 -1
Make tests pass on PHPUnit 8mediawiki/extensions/Scribuntomaster+18 -1
phpunit: Drop "debug-tests" command, no-op, now unused in Quibblemediawiki/coremaster+0 -7
Drop PHPUnit4 compatmediawiki/extensions/SemanticSiftermaster+1 -1
jjb: Switch over to images using Quibble version 0.0.40integration/configmaster+22 -22
dockerfiles: Create images for Quibble version 0.0.40integration/configmaster+54 -0
Release Quibble 0.0.40integration/quibblemaster+25 -3
phpunit: Drop --debug-tests command, killed off in PHPUnit 8integration/quibblemaster+3 -3
phpunit deprecations: Handle assertType() as wellmediawiki/tools/codesniffermaster+94 -18
Fix other PHPUnit 8 compat issuesmediawiki/extensions/Wikibasemaster+141 -141
Fix most PHPUnit 8 compat issues in DBless testsmediawiki/coremaster+19 -20
Fixes for PHPUnit 8 compat in DB suitemediawiki/coremaster+30 -27
Manual fix of the remaining assertInternalType & Co.mediawiki/coremaster+31 -14
Stop using assertContains with string haystackmediawiki/coremaster+284 -256
Deprecate and stop using assertType(OrValue)mediawiki/coremaster+37 -51
Autofix 94 PHPUnit 8 compat issuesmediawiki/coremaster+96 -96
Autofix some PHPUnit 7 compat issuesmediawiki/extensions/Wikibasemaster+108 -108
build: Bump mediawiki-codesniffer to 28.0.0 and make passmediawiki/extensions/CentralNoticewmf/1.35.0-wmf.10+16 -15
build: Bump mediawiki-codesniffer to 28.0.0 and make passmediawiki/extensions/CentralNoticewmf_deploy+16 -15
build: Bump mediawiki-codesniffer to 28.0.0 and make passmediawiki/extensions/CentralNoticemaster+16 -15
Fixes for PHPUnit 8 compatibilitymediawiki/coremaster+96 -42
Fixes for PHPUnit 7/8 compatibilitymediawiki/extensions/Wikibasemaster+2 -2
Fixes for PHPUnit 7 compatmediawiki/extensions/ActiveAbstractmaster+1 -1
Hack: back-compat for PHPUnit's Stub interfacemediawiki/extensions/Echomaster+15 -3
Upgrade PHPUnit to version 7mediawiki/coremaster+31 -26
phpunit: Remove 6And8Compat trait from base classesmediawiki/coremaster+1 -3
Suppress PHPUnit 8 warningsmediawiki/extensions/FileImportermaster+2 -0
Suppress PHPUnit 8 warningsmediawiki/extensions/WikibaseMediaInfomaster+6 -0
Fixes for PHPUnit 8 compatibilitymediawiki/extensions/CirrusSearchmaster+3 -4
Add PHPUnit6And8Compat traitmediawiki/coremaster+61 -1
Add a sniff for methods deprecated in PHPUnit 8mediawiki/tools/codesniffermaster+458 -0
phpunit: Add typehints for PHPUnit 8mediawiki/coremaster+22 -21
More backwards compatible changes for PHPUnitmediawiki/coremaster+24 -20
Remove PHPUnit4And6Compat from Test classesmediawiki/coremaster+0 -2
Backwards-compatible PHPUnit 8 preparationsmediawiki/coremaster+45 -44
Fix function signature for PHPUnit 8 compatibilitymediawiki/extensions/Translatemaster+2 -2
PHPUnit 8 compatibility fixesmediawiki/extensions/CirrusSearchmaster+5 -3
PHPUnit 8 compatible declarationsmediawiki/extensions/JsonConfigmaster+1 -1
Also require return type for setUpBeforeClass() and tearDownAfterClass()mediawiki/tools/codesniffermaster+167 -14
tests: Add explicit return type void to setUp() and tearDown()mediawiki/coremaster+288 -289
PHPUnit 8 compatibility that doesn't break b/cmediawiki/extensions/DonationInterfacemaster+95 -95
Kill last usages of PHPUnit4And6Compat with a temporary compat traitmediawiki/extensions/Wikibasemaster+28 -6
build: Bump mediawiki-codesniffer to 28.0.0mediawiki/extensions/PasswordlessLoginmaster+9 -7
tests: Add explicit return type void to setUp() and tearDown()mediawiki/extensions/PagedTiffHandlermaster+2 -2
tests: Add explicit return type void to setUp() and tearDown()mediawiki/extensions/WikibaseLexemeCirrusSearchmaster+1 -1
Drop PHPUnit4 compatmediawiki/extensions/TranslateSvgmaster+2 -1
tests: Fix setUp() signaturesmediawiki/extensions/OAuthmaster+3 -3
tests: Fix setUp()/tearDown() signaturesmediawiki/extensions/QuickSearchLookupmaster+2 -2
tests: Remove empty setUp()/tearDown()mediawiki/extensions/NumerAlphamaster+1 -9
tests: Remove empty setUp()/tearDown()mediawiki/extensions/WhosOnlinemaster+0 -8
tests: Fix setUp() that crept into a traitmediawiki/extensions/WikibaseCirrusSearchmaster+1 -1
tests: Fix signature of setUp() that have crept into a traitmediawiki/extensions/GlobalCssJsmaster+1 -1
tests: Stop using getMock()mediawiki/extensions/SimpleSAMLphpmaster+20 -6
tests: Stop using getMock()mediawiki/extensions/LDAPGroupsmaster+7 -5
Stop using getMock()mediawiki/extensions/Wikisourcemaster+1 -1
tests: getMock() is deprecatedmediawiki/extensions/LDAPGroupsmaster+8 -5
tests: createMock() is deprecatedmediawiki/extensions/Wikisourcemaster+1 -1
tests: getMock() is deprecatedmediawiki/coremaster+4 -4
tests: Stop using getMock()mediawiki/skins/MinervaNeuemaster+6 -18
tests: getMock() is deprecatedmediawiki/extensions/ArticleCreationWorkflowmaster+21 -18
tests: getMock() is deprecatedmediawiki/extensions/WikidataPageBannermaster+3 -3
tests: getMock() is deprecatedmediawiki/extensions/MobileFrontendmaster+5 -6
tests: getMock() is deprecatedmediawiki/extensions/MassMessagemaster+1 -1
tests: getMock() is deprecatedmediawiki/extensions/EventLoggingmaster+3 -1
tests: getMock() is deprecatedmediawiki/extensions/Lintermaster+1 -1
tests: getMock() is deprecatedmediawiki/extensions/ConfirmEditmaster+3 -2
tests: getMock() is deprecatedmediawiki/extensions/Thanksmaster+2 -1
tests: getMock() is deprecatedmediawiki/extensions/ActiveAbstractmaster+8 -8
tests: getMock() is deprecatedmediawiki/extensions/FileImportermaster+1 -1
Remove PHPUnit 4 bc stuffmediawiki/extensions/Flowmaster+5 -5
Clean up PHPUnit 4 bc stuffmediawiki/extensions/UserMergemaster+8 -8
Clean up some PHPUnit 4 bc stuffmediawiki/extensions/Thanksmaster+5 -5
Clean up PHPUnit 4 bcmediawiki/extensions/PropertySuggestermaster+5 -5
Remove PPHUnit 4 bc stuffmediawiki/extensions/ConfirmEditmaster+5 -5
Remove most PHPUnit4 bc stuffmediawiki/extensions/ArticlePlaceholdermaster+13 -14
tests: Nuke last usages of setExpectedException()mediawiki/coremaster+8 -9
Upgrade phpcs, remove PHPUnit 4 b/cmediawiki/extensions/OAuthmaster+17 -22
Remove PHPUnit 4 bc stuffmediawiki/extensions/MobileFrontendmaster+11 -11
Don't use PHPUnit 4 class namemediawiki/extensions/CirrusSearchmaster+2 -2
@expectedException is deprecatedmediawiki/extensions/ParserFunctionsmaster+2 -1
Fixes for PHPUnit 6 compatibilitymediawiki/extensions/WikimediaBadgesmaster+3 -3
tests: setExpectedException() is deprecatedmediawiki/extensions/PropertySuggestermaster+1 -1
tests: setExpectedException() is deprecatedmediawiki/extensions/ArticlePlaceholdermaster+1 -1
Add a sniff to ensure that setUp and tearDown have :void typehintsmediawiki/tools/codesniffermaster+317 -1
Add a plugin to ensure that setUp and tearDown have :void typehintsmediawiki/tools/phanmaster+369 -1
PHPUnit 6 compatibility fixesmediawiki/extensions/MassMessagemaster+3 -7
tests: setExpectedException() is deprecatedmediawiki/extensions/BounceHandlermaster+6 -6
tests: setExpectedException() is deprecatedmediawiki/extensions/EventLoggingmaster+1 -1
tests: setExpectedException() is deprecatedmediawiki/extensions/DonationInterfacemaster+1 -1
tests: setExpectedException() is deprecatedmediawiki/extensions/ContentTranslationmaster+1 -1
tests: setExpectedException() is deprecatedmediawiki/extensions/AbuseFiltermaster+6 -4
tests: setExpectedException() is deprecatedmediawiki/extensions/ExternalGuidancemaster+1 -1
Fixes for PHPUnit 6 compatibilitymediawiki/extensions/EntitySchemamaster+22 -39
Use PHPUnit 6 class namemediawiki/extensions/ArticlePlaceholdermaster+2 -2
Use PHPUnit 6 class namesmediawiki/extensions/Newslettermaster+3 -2
Drop PHPUnit 4 supportmediawiki/extensions/WikibaseLexemeCirrusSearchmaster+7 -16
Use PHPUnit 6 class namemediawiki/extensions/WikibaseLexemeCirrusSearchmaster+2 -1
Use PHPUnit 6 class namesmediawiki/extensions/Wikibasemaster+116 -97
Drop support for PHPUnit 4mediawiki/extensions/WikibaseQualityConstraintsmaster+34 -63
Use PHPUnit 6 class namemediawiki/extensions/WikibaseQualityConstraintsmaster+4 -4
Use PHPUnit 6 class namemediawiki/extensions/WikibaseMediaInfomaster+4 -4
Use PHPUnit 6 class namesmediawiki/extensions/WikibaseLexememaster+27 -21
Use PHPUnit 6 class namesmediawiki/extensions/PropertySuggestermaster+4 -4
Use PHPUnit 6 class namemediawiki/extensions/WikimediaEventsmaster+3 -4
Use PHPUnit 6 class namesmediawiki/extensions/Echomaster+9 -5
Use PHPUnit 6 class namesmediawiki/extensions/EventLoggingmaster+3 -2
Use PHPUnit 6 class namemediawiki/extensions/ReadingListsmaster+2 -3
Use PHPUnit 6 class namemediawiki/extensions/MobileFrontendmaster+2 -1
Use PHPUnit 6 class namesmediawiki/extensions/CentralAuthmaster+3 -2
Use PHPUnit class namesmediawiki/extensions/ActiveAbstractmaster+9 -5
Remove PHPUnit4 compatibilitymediawiki/extensions/WikibaseLexememaster+47 -163
Drop PHPUnit 4 supportmediawiki/extensions/WikibaseCirrusSearchmaster+2 -12
Kill the remaining usages of PHPUnit4And6Compat methodsmediawiki/extensions/WikibaseMediaInfomaster+27 -53
Kill the remaining usages of PHPUnit4And6Compat methodsmediawiki/coremaster+81 -61
Update tests to use PHPUnit 6 class namesmediawiki/coremaster+242 -171
Fixes for PHPUnit 6mediawiki/extensions/Popupsmaster+41 -26
Replace getMock with createMockmediawiki/coremaster+0 -0
Fixes for PHPUnit 6mediawiki/extensions/PageViewInfomaster+10 -6
Fixes for PHPUnit 6mediawiki/extensions/CommonsMetadatamaster+38 -25
Update tests for PHPUnit 6mediawiki/extensions/Cognatemaster+16 -18
Use PHPUnit 6 class namesmediawiki/extensions/DonationInterfacemaster+12 -5
Update to use PHPUnit 6 class namesmediawiki/extensions/Scribuntomaster+19 -13
Replace setExpectedException with two argsmediawiki/coremaster+240 -183
Replace setExpectedException with single argmediawiki/coremaster+55 -55
Drop PHPUnit4And6Compat traitmediawiki/extensions/Wikibasemaster+0 -567
Cleanup of old PHPUnit usage, part 3mediawiki/coremaster+50 -62
Cleanup of old PHPUnit usage, part 2mediawiki/coremaster+54 -67
Begin cleaning up PHPUnit 4 code from testsmediawiki/coremaster+38 -57
PHPUnit4And6Compat: drop forward-compat functionsmediawiki/coremaster+0 -49
tests: Require PHPUnit 6, drop PHPUnit 4 as an optionmediawiki/coremaster+6 -19
Remove PHPUnit 4 supportmediawiki/extensions/CirrusSearchmaster+5 -7
Remove PHPUnit 4 compatibilitymediawiki/extensions/FileImportermaster+52 -67
Remove PHPUnit 4 compatibilitymediawiki/extensions/GeoDatamaster+1 -1
Drop PHPUnit 4 compatibilitymediawiki/extensions/Kartographermaster+1 -3
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Jan 16 2020, 8:03 PM

Change 551885 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Preparation for PHPUnit 8 migration

https://gerrit.wikimedia.org/r/551885

gerritbot added a comment.Jan 17 2020, 10:22 AM

Change 565377 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make tests pass on PHPUnit 8

https://gerrit.wikimedia.org/r/565377

gerritbot added a comment.Jan 17 2020, 2:42 PM

Change 565580 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/PropertySuggester@master] Make tests pass on PHPUnit 8

https://gerrit.wikimedia.org/r/565580

gerritbot added a comment.Jan 17 2020, 3:07 PM

Change 565599 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] PasswordFactoryTest: assertArraySubset() is dprecated

https://gerrit.wikimedia.org/r/565599

gerritbot added a comment.Jan 17 2020, 4:20 PM

Change 565580 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Make tests pass on PHPUnit 8

https://gerrit.wikimedia.org/r/565580

MaxSem mentioned this in rEPS986292a08ad5: Make tests pass on PHPUnit 8.Jan 17 2020, 4:37 PM
gerritbot added a comment.Jan 17 2020, 4:38 PM

Change 565599 merged by jenkins-bot:
[mediawiki/core@master] PasswordFactoryTest: assertArraySubset() is deprecated

https://gerrit.wikimedia.org/r/565599

gerritbot added a comment.Jan 18 2020, 4:03 PM

Change 565735 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/GeoData@master] assertEqualds() with delta is deprecated

https://gerrit.wikimedia.org/r/565735

gerritbot added a comment.Jan 18 2020, 4:40 PM

Change 565735 merged by jenkins-bot:
[mediawiki/extensions/GeoData@master] assertEqualds() with delta is deprecated

https://gerrit.wikimedia.org/r/565735

gerritbot added a comment.Jan 18 2020, 6:57 PM

Change 565740 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/Wikibase@master] Use the right namespace for LanguageFactory

https://gerrit.wikimedia.org/r/565740

gerritbot added a comment.Jan 18 2020, 7:39 PM

Change 565740 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use the right namespace for LanguageFactory

https://gerrit.wikimedia.org/r/565740

gerritbot added a comment.Jan 19 2020, 7:23 PM

Change 565782 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/MobileFrontend@master] Make tests pass with PHPUnit 8

https://gerrit.wikimedia.org/r/565782

gerritbot added a comment.Jan 19 2020, 8:37 PM

Change 565785 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/Flow@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/565785

gerritbot added a comment.Jan 19 2020, 8:39 PM

Change 565786 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/Cite@master] Fix PHPUnit 8 warning

https://gerrit.wikimedia.org/r/565786

gerritbot added a comment.Jan 19 2020, 9:04 PM

Change 565782 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Make tests pass with PHPUnit 8

https://gerrit.wikimedia.org/r/565782

gerritbot added a comment.Jan 20 2020, 7:26 AM

Change 565831 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/Babel@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/565831

gerritbot added a comment.Jan 20 2020, 8:39 AM

Change 565831 merged by jenkins-bot:
[mediawiki/extensions/Babel@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/565831

gerritbot added a comment.Jan 20 2020, 8:49 AM

Change 565980 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/Wikibase@master] Fix some PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/565980

gerritbot added a comment.Jan 20 2020, 11:06 AM

Change 565785 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/565785

gerritbot added a comment.Jan 20 2020, 11:06 AM

Change 565786 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Fix PHPUnit 8 warning

https://gerrit.wikimedia.org/r/565786

gerritbot added a comment.Jan 20 2020, 11:30 AM

Change 565980 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix some PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/565980

gerritbot added a comment.Jan 20 2020, 1:53 PM

Change 566026 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/Wikibase@master] Fix some more PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566026

gerritbot added a comment.Jan 20 2020, 2:04 PM

Change 566030 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/FileImporter@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566030

gerritbot added a comment.Jan 20 2020, 2:09 PM

Change 566033 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/EventLogging@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566033

Sebastian_Berlin-WMSE unsubscribed.Jan 20 2020, 2:11 PM
gerritbot added a comment.Jan 20 2020, 3:29 PM

Change 566055 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/CirrusSearch@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566055

gerritbot added a comment.Jan 20 2020, 3:34 PM

Change 566057 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/AbuseFilter@master] Fix PHPUnit 8 warning

https://gerrit.wikimedia.org/r/566057

gerritbot added a comment.Jan 20 2020, 3:39 PM

Change 566059 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/GeoData@master] Fix another PHPUnit 8 warning

https://gerrit.wikimedia.org/r/566059

gerritbot added a comment.Jan 20 2020, 3:48 PM

Change 566061 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566061

gerritbot added a comment.Jan 20 2020, 4:01 PM

Change 566030 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566030

gerritbot added a comment.Jan 20 2020, 4:01 PM

Change 566033 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566033

MaxSem mentioned this in rEFLI3612fe9e1c76: Fix PHPUnit 8 warnings.Jan 20 2020, 4:03 PM
gerritbot added a comment.Jan 20 2020, 4:26 PM

Change 566057 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Fix PHPUnit 8 warning

https://gerrit.wikimedia.org/r/566057

gerritbot added a comment.Jan 20 2020, 4:26 PM

Change 566059 merged by jenkins-bot:
[mediawiki/extensions/GeoData@master] Fix another PHPUnit 8 warning

https://gerrit.wikimedia.org/r/566059

gerritbot added a comment.Jan 20 2020, 4:26 PM

Change 566055 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566055

gerritbot added a comment.Jan 20 2020, 4:36 PM

Change 566061 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566061

gerritbot added a comment.Jan 20 2020, 5:06 PM

Change 566026 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix some more PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566026

gerritbot added a comment.Jan 20 2020, 5:54 PM

Change 566078 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/Wikibase@master] Overhaul TimeParser tests

https://gerrit.wikimedia.org/r/566078

gerritbot added a comment.Jan 20 2020, 8:26 PM

Change 566088 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/WikibaseCirrusSearch@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566088

gerritbot added a comment.Jan 20 2020, 9:03 PM

Change 566094 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/Wikibase@master] Hopefully fix the remaining PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566094

gerritbot added a comment.Jan 20 2020, 9:16 PM

Change 566088 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566088

MaxSem mentioned this in rEWCS3fc9b94a43e5: Fix PHPUnit 8 warnings.Jan 20 2020, 9:46 PM
gerritbot added a comment.Jan 21 2020, 9:58 AM

Change 566094 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Hopefully fix the remaining PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566094

MaxSem mentioned this in T243296: Release a new version of WikibaseCodeSniffer.Jan 21 2020, 4:47 PM
MaxSem added a subtask: T243296: Release a new version of WikibaseCodeSniffer.
MaxSem added a comment.Jan 21 2020, 4:55 PM

Current status:

Daimona added a comment.Jan 21 2020, 5:13 PM
In T192167#5819857, @MaxSem wrote:

Sadly, there are other warnings in non-DB suites. In the unit tests suite:

11:38:12 1) CirrusSearch\HooksTest::testPrepareTitlesForLinksUpdate
11:38:12 The optional $canonicalize parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsCanonicalizing() instead.
11:38:12 2) CirrusSearch\SuggestScoringTest::testQualityScoreWithRandomValues
11:38:12 The optional $delta parameter of assertEquals() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertEqualsWithDelta() instead.

And then 144 more warnings in the integration-without-DB suite. Luckily, 128 of those will be fixed by r566078.

  • There are still some uses of deprecated stuff left across the codebase, we need to push mediawiki-codesniffer 29.0.0 to more extensions (why didn't Libraryupgrader do it?)

According to the LibUp interface, there are 44 repos on 28.0.0, and 8 repos on <=26.0.0 (these are probably stalled for PHP compatibility...). I've skimmed the log files for some of those, but cannot see anything weird. Apparently, LibUp tries to do the upgrade, fixes what's to be fixed, git commit, and then it bails out without any apparent reason. CC @Legoktm ?

gerritbot added a comment.Jan 21 2020, 5:45 PM

Change 566078 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Overhaul TimeParser tests

https://gerrit.wikimedia.org/r/566078

gerritbot added a comment.Jan 21 2020, 5:58 PM

Change 566325 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/CirrusSearch@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566325

gerritbot added a comment.Jan 21 2020, 5:59 PM

Change 566326 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/Flow@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566326

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.18; 2020-02-04); removed MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 21 2020, 6:00 PM
gerritbot added a comment.Jan 21 2020, 6:01 PM

Change 566328 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/WikibaseCirrusSearch@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566328

gerritbot added a comment.Jan 21 2020, 6:02 PM

Change 566329 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566329

gerritbot added a comment.Jan 21 2020, 6:12 PM

Change 566327 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/Wikibase@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566327

gerritbot added a comment.Jan 21 2020, 6:24 PM

Change 566328 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566328

gerritbot added a comment.Jan 21 2020, 6:24 PM

Change 566325 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566325

gerritbot added a comment.Jan 21 2020, 6:26 PM

Change 566326 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566326

Daimona mentioned this in rEWCSe195331e4b7a: Fix PHPUnit 8 warnings.Jan 21 2020, 6:27 PM
gerritbot added a comment.Jan 21 2020, 6:29 PM

Change 566333 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/WikibaseLexeme@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566333

gerritbot added a comment.Jan 21 2020, 6:41 PM

Change 566329 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566329

gerritbot added a comment.Jan 21 2020, 6:57 PM

Change 566333 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566333

Jdforrester-WMF mentioned this in T243324: PHPUnit: Drop enforceTimeLimit command and related settings, because we can't use php-invoker.Jan 21 2020, 7:05 PM
gerritbot added a comment.Jan 21 2020, 7:38 PM

Change 555752 merged by jenkins-bot:
[mediawiki/core@master] Remove phpunit/php-invoker from require-dev

https://gerrit.wikimedia.org/r/555752

Daimona added a comment.Jan 22 2020, 4:34 PM
In T192167#5819857, @MaxSem wrote:

Current status:

Quick update:

  1. Now the migration commit is really passing without warnings;
  2. We're still waiting for LibUp to complete its work, and for wikibase-codesniffer, and
  3. I believe we should finalize the upgrade as soon as (2.) is done. Chances are, for some repos PHPUnit will emit deprecation warnings (although it shouldn't fail hard). We should probably send a heads-up to wikitech-l about that, before upgrading.
gerritbot added a comment.Jan 22 2020, 5:19 PM

Change 566327 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix PHPUnit 8 warnings

https://gerrit.wikimedia.org/r/566327

Jdforrester-WMF added a comment.Jan 23 2020, 12:26 AM

I don't think it's necessary to wait for Wikibase's codesniffer fork; they'll catch up soon enough when it becomes pressing. Most repos are now on 29.x. Let's just do it?

MaxSem added a comment.Jan 23 2020, 5:59 AM

Yeah, time to pull the trigger.

Daimona added a comment.Jan 23 2020, 10:48 AM

Ha, I was being cautious, but I certainly don't oppose. As I said above, PHPUnit 8 won't fail hard for non-compliant repos. I can write down a couple of lines for wikitech-l as soon as the upgrade is complete.

In T192167#5825634, @MaxSem wrote:

Yeah, time to pull the trigger.

I've just taken the safety off.

gerritbot added a comment.Jan 23 2020, 11:19 AM

Change 552312 merged by jenkins-bot:
[mediawiki/core@master] Upgrade to PHPUnit 8

https://gerrit.wikimedia.org/r/552312

Ladsgroup awarded a token.Jan 23 2020, 1:50 PM
Jdforrester-WMF closed subtask T234597: Phase out PHPUnit expected exception annotations from tests as Resolved.Jan 23 2020, 3:43 PM
gerritbot added a comment.Jan 23 2020, 3:52 PM

Change 555913 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Remove hack for PHPUnit's Stub interface

https://gerrit.wikimedia.org/r/555913

Jdforrester-WMF closed this task as Resolved.Jan 23 2020, 4:17 PM
Jdforrester-WMF removed a subtask: T243296: Release a new version of WikibaseCodeSniffer.

Congratulations, all.

Daimona awarded a token.Jan 23 2020, 4:18 PM
gerritbot added a comment.Jan 23 2020, 4:21 PM

Change 566786 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/Scribunto@master] Kill hack for the PHPUnit migration

https://gerrit.wikimedia.org/r/566786

Jdforrester-WMF changed the status of subtask T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8 from Open to Stalled.Jan 23 2020, 4:28 PM
gerritbot added a comment.Jan 23 2020, 4:41 PM

Change 566786 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Kill hack for the PHPUnit migration

https://gerrit.wikimedia.org/r/566786

Daimona mentioned this in rELUA2e1306fa450e: Kill hack for the PHPUnit migration.Jan 23 2020, 5:09 PM
Daimona mentioned this in T243600: Migrate MediaWiki core (and thus extensions and skins) to PHPUnit 9.Jan 24 2020, 1:27 PM
Addshore changed the status of subtask T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8 from Stalled to Open.Feb 17 2020, 9:28 AM
Daimona mentioned this in T244095: assertArraySubset() will be removed in PHPUnit 9.Feb 19 2020, 3:49 PM
Michael changed the status of subtask T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8 from Open to Stalled.Jun 22 2020, 4:40 PM
Addshore changed the status of subtask T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8 from Stalled to Open.Jun 30 2020, 4:29 PM
Addshore closed subtask T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8 as Resolved.Jul 15 2020, 8:16 AM
Lucas_Werkmeister_WMDE added a subtask: T260915: Move DataValues away from “withered” PHPUnit 4.Aug 20 2020, 3:34 PM
gerritbot added a comment.Sep 28 2020, 8:04 AM

Change 630538 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/WSOAuth@master] tests: use explicit return type for setUp/tearDown

https://gerrit.wikimedia.org/r/630538

gerritbot added a comment.Sep 30 2020, 9:07 AM

Change 630538 merged by Hashar:
[mediawiki/extensions/WSOAuth@master] tests: use explicit return type for setUp/tearDown

https://gerrit.wikimedia.org/r/630538

gerritbot added a comment.Oct 16 2020, 7:40 PM

Change 546456 merged by jenkins-bot:
[mediawiki/core@master] Drop PHPUnit4And6Compat and PHPUnit6And8Compat

https://gerrit.wikimedia.org/r/546456

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.14; 2020-10-20).Oct 16 2020, 8:00 PM
WMDE-leszek closed subtask T260915: Move DataValues away from “withered” PHPUnit 4 as Resolved.Oct 29 2020, 8:00 AM
gerritbot added a comment.Dec 17 2020, 6:44 PM

Change 650224 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/core@master] Remove MediaWikiIntegrationTestCase::assertType

https://gerrit.wikimedia.org/r/650224

gerritbot added a comment.Dec 18 2020, 8:26 PM

Change 650224 merged by jenkins-bot:
[mediawiki/core@master] Remove MediaWikiIntegrationTestCase::assertType

https://gerrit.wikimedia.org/r/650224

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.25; 2021-01-05); removed MW-1.36-notes (1.36.0-wmf.14; 2020-10-20).Dec 18 2020, 9:00 PM
gerritbot added a comment.Dec 23 2020, 5:53 PM

Change 651807 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Don't silently discard exceptions in test suite setUp/tearDown methods

https://gerrit.wikimedia.org/r/651807

gerritbot added a comment.Jan 5 2021, 2:46 AM

Change 651807 merged by jenkins-bot:
[mediawiki/core@master] Don't silently discard exceptions in test suite setUp/tearDown methods

https://gerrit.wikimedia.org/r/651807

Mainframe98 mentioned this in T302540: Missing PHP extension in MW core's composer.json.Feb 26 2022, 11:33 AM
Daimona mentioned this in rELDR53784980a2ac: tests: Stop using getMock().May 25 2023, 6:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits