Page MenuHomePhabricator
Create Task
Maniphest T231270

Failing build process: Variadic params with type constraints are not supported in non-Hack files
Closed, ResolvedPublic
Actions

Description

Currently the build process for the TwnMainPage extension is failing,

23:21:37 Fatal error: Parameter $components is variadic and has a type constraint (array); variadic params with type constraints are not supported in non-Hack files in /workspace/src/vendor/phpunit/phpunit-mock-objects/src/Framework/MockObject/Generator.php(290)(f20f14cd5fcea3c462c1b8717778808f) : eval()'d code on line 429

Some information about why this is happening,

  1. https://phabricator.wikimedia.org/T192166#4475526
  2. https://github.com/facebook/hhvm/issues/6954

This is currently blocking: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TwnMainPage/+/531831

Details

SubjectRepoBranchLines +/-
Fix failing build for TwnMainPage on HHVMmediawiki/extensions/TwnMainPagemaster+39 -19
Customize query in gerrit

Related Objects

Event Timeline

abi_ created this task.Aug 27 2019, 7:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2019, 7:15 AM
abi_ renamed this task from Fix failing build process for TwnMainPage extension to Failing build process: Variadic params with type constraints are not supported in non-Hack files.Aug 27 2019, 7:24 AM
abi_ triaged this task as High priority.
abi_ updated the task description. (Show Details)
gerritbot added a comment.Aug 27 2019, 7:36 AM

Change 532546 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/TwnMainPage@master] Fix failing build for TwnMainPage on HHVM

https://gerrit.wikimedia.org/r/532546

gerritbot added a project: Patch-For-Review.Aug 27 2019, 7:36 AM
abi_ moved this task from Backlog to In Review on the Language-Team (Language-2019-July-September) board.Aug 27 2019, 7:42 AM
gerritbot added a comment.Aug 27 2019, 10:03 AM

Change 532546 merged by jenkins-bot:
[mediawiki/extensions/TwnMainPage@master] Fix failing build for TwnMainPage on HHVM

https://gerrit.wikimedia.org/r/532546

Nikerabbit mentioned this in T231289: Stop running HHVM tests for TwnMainPage.Aug 27 2019, 10:14 AM
Daimona subscribed.Aug 29 2019, 7:45 PM

For future reference, see T228695#5450847

abi_ closed this task as Resolved.Aug 30 2019, 4:17 AM
abi_ moved this task from In Review to Done on the Language-Team (Language-2019-July-September) board.

Thanks @Daimona. Will keep this in mind. For this extension, we are no longer running these tests on HHVM during the CI process.

Resolving this task.

• Petar.petkovic removed a project: Patch-For-Review.Sep 5 2019, 8:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits