Page MenuHomePhabricator

Show popup again after it has been closed
Open, Needs TriagePublicFeature

Description

When the popup has been displayed it disappear is there a possibility to display it again.,...??

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2019, 3:34 PM
Sebastian_Berlin-WMSE changed the subtype of this task from "Task" to "Feature Request".Dec 9 2019, 3:43 PM

There's currently no way of showing the popup again. I think it could be tricky to find a good way to add a button that is at the same time not in the way of other GUI components and makes it clear what it does. An alternative could be to not have the popup disappear automatically if the user interacts with it (click, mouse over etc.)

Sebastian_Berlin-WMSE renamed this task from Show poup again after it has closed to Show poup again after it has been closed.Dec 9 2019, 3:44 PM

Thanks or maybe if possible access it from the version list....

My slow brain reacts when the popup has disappeared and would like to look at it again ;-)
Lesson learned is if you see be prepared to read it ;-)

Aklapper renamed this task from Show poup again after it has been closed to Show popup again after it has been closed.Dec 9 2019, 3:58 PM
Nirmos added a subscriber: Nirmos.EditedDec 16 2019, 11:30 AM

@Sebastian_Berlin-WMSE It's possible to make the script add a portlet link to the toolbox, and have that link .show() the dialog again. The portlet link is added when the dialog closes (both when the user closes it as well as from the setTimeout). This guarantees that there will always be a dialog to show when clicking this link. It also guarantees that the portlet link is only shown after the user has made an edit.
Proposed diff: https://sv.wikipedia.org/w/index.php?oldid=46879235&diff=46881200
If you think that this is a good idea, I can implement this.

Looks mostly good. A few things:

  1. Adding and removing the portlet link seems like odd behaviour to me. If nothing else it shifts the toolbar around. I'd have the link added at load and just not do anything if the popup is visible.
  2. If you show the popup after it's been hidden it won't go away by itself. This is reasonable, but it means that the user needs to click the "More" button in order to get the "Close" button. I'd add the "Close" button in the non-expanded view.
  3. You don't need to use find() in close(). $( '#gadget-articleQuality a' ) gets you the link.