Maniphest T242068

Linter does not detect link-in-link when wikilink is wrapped in italics
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jonesey95
	Jan 7 2020, 5:57 AM

Description

This one is easier to see than to explain:

https://en.wikipedia.org/w/index.php?title=User:Jonesey95/sandbox3&oldid=934562159

In the first example, a plain wikilink is placed inside a URL link. It is correctly flagged by Linter as a link-in-link error.

In the second example, a wikilink wrapped in italic formatting is placed inside a URL link. It is not flagged by Linter as a link-in-link error, but it should be.

Details

	Subject	Repo	Branch	Lines +/-
	Bump wikimedia/parsoid to 0.13.0-a25	mediawiki/vendor	master	+755 -237
	Add lint for Parsoid wikilinks in extlinks with italic or bold	mediawiki/services/parsoid	master	+40 -14

Customize query in gerrit

Related Objects

Mentioned In: T267282: VisualEditor fails to load when page contains an image inside an external link: imgWrapper is undefined
T261951: Links-in-link scenarios break template about-grouping in some scenaros.

Event Timeline

Jonesey95 created this task.Jan 7 2020, 5:57 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2020, 5:57 AM

Jonesey95 renamed this task from Linter does not detect link-in-link when link is wrapped in italics to Linter does not detect link-in-link when wikilink is wrapped in italics.Jan 7 2020, 5:58 AM

Legoktm added a project: Parsoid.Jan 21 2020, 1:30 AM

ssastry edited projects, added Parsoid-Linter; removed Parsoid.Jan 21 2020, 6:06 PM

Izno moved this task from Backlog to Parsoid on the MediaWiki-extensions-Linter board.Feb 18 2020, 3:05 PM

Aklapper edited projects, added Parsoid; removed Parsoid-Linter.Feb 29 2020, 5:13 PM

ssastry moved this task from Needs Triage to Linting on the Parsoid board.Feb 29 2020, 6:04 PM

ssastry triaged this task as Medium priority.Mar 8 2020, 1:00 AM

NicoV mentioned this in T261951: Links-in-link scenarios break template about-grouping in some scenaros..Sep 8 2020, 6:59 PM

If you want more examples of errors missed by Linter, you can compare on frwiki between what Linter finds and what WPCleaner finds.

Thanks! we'll fix it.

Izno mentioned this in T267282: VisualEditor fails to load when page contains an image inside an external link: imgWrapper is undefined.Nov 23 2020, 6:38 PM

Sbailey claimed this task.Jan 27 2021, 6:40 PM

Change 660920 had a related patch set uploaded (by Sbailey; owner: Sbailey):
[mediawiki/services/parsoid@master] Add lint for Parsoid wikilinks in extlinks with italic or bold

https://gerrit.wikimedia.org/r/660920

gerritbot added a project: Patch-For-Review.Feb 1 2021, 8:55 PM

Change 660920 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Add lint for Parsoid wikilinks in extlinks with italic or bold

https://gerrit.wikimedia.org/r/660920

Maintenance_bot removed a project: Patch-For-Review.Feb 2 2021, 11:11 PM

Sbailey closed this task as Resolved.Feb 4 2021, 8:14 PM

Change 666213 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a25

https://gerrit.wikimedia.org/r/666213

gerritbot added a project: Patch-For-Review.Feb 22 2021, 9:50 PM

Change 666213 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a25