Maniphest T242822

Reply added in the wrong place in case of list gap in the discussion
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Jan 15 2020, 3:28 AM

Tags

Referenced Files

	F31512929: image.png
	Jan 15 2020, 3:28 AM

	F31512925: image.png
	Jan 15 2020, 3:28 AM

	F31512927: image.png
	Jan 15 2020, 3:28 AM

Subscribers

Description

Consider a discussion page like this (https://en.wikipedia.beta.wmflabs.org/wiki/Talk:List_gap):

== Blah ==
These comments demonstrate [[wikipedia:MOS:LISTGAP|list gap]]. ~~~~
: Blah. ~~~~
:: Blah blah. ~~~~

:: I broke it! ~~~~

image.png (1×2 px, 435 KB)

Trying to reply to the top-level comment should add the reply at the very bottom. Instead, it adds the reply at the gap:

image.png (1×2 px, 436 KB)

image.png (1×2 px, 456 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Pick reply insertion point based on parser tree, not DOM tree	mediawiki/extensions/DiscussionTools	master	+440 -279

Customize query in gerrit

Event Timeline

matmarex created this task.Jan 15 2020, 3:28 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2020, 3:28 AM

Patch-For-Review https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/564854

Change 564854 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Pick reply insertion point based on parser tree, not DOM tree

https://gerrit.wikimedia.org/r/564854

matmarex added a project: VisualEditor (Current work).Jan 25 2020, 8:24 AM

matmarex removed a project: Patch-For-Review.

matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.

Jdforrester-WMF added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 26 2020, 1:15 AM

matmarex added a project: Editing QA.Jan 29 2020, 9:25 PM

JTannerWMF edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed VisualEditor (Current work).Feb 4 2020, 11:14 PM

JTannerWMF moved this task from Needs Discussion / Investigation to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.

JTannerWMF moved this task from Inbox to High Priority on the Editing QA board.Feb 5 2020, 3:05 AM

Ryasmeen edited projects, added Verified; removed Editing QA.Feb 7 2020, 6:45 PM

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.

ppelberg closed this task as Resolved.Feb 15 2020, 2:05 AM