CloseWikis table `closedwikis` lacks a primary key
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DannyS712
	Jan 31 2020, 5:48 AM

Description

Current table

CREATE TABLE /*$wgDBprefix*/closedwikis (
	cw_wiki varchar(255) NOT NULL,
	cw_reason mediumblob NOT NULL,
	cw_timestamp binary(14) NOT NULL,
	cw_by tinyblob NOT NULL
) /*$wgDBTableOptions*/;
CREATE UNIQUE INDEX cw_wiki ON closedwikis (cw_wiki);

The unique index should be converted to a primary key.
There appear to be no direct references to the index itself: https://codesearch.wmflabs.org/search/?q=cw_wiki%5B%5Es%5D&i=nope&files=&repos=

Details

	Subject	Repo	Branch	Lines +/-
	Convert `closedwikis.cw_wiki` from unique index to primary key	mediawiki/extensions/CloseWikis	master	+13 -2

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	LSobanski	T17441 Some tables lack unique or primary keys, may allow confusing duplicate data
Resolved	DannyS712	T243986 CloseWikis table `closedwikis` lacks a primary key
		· · ·

Event Timeline

DannyS712 created this task.Jan 31 2020, 5:48 AM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptJan 31 2020, 5:48 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Jan 31 2020, 5:53 AM

MarcoAurelio subscribed.Jan 31 2020, 10:41 PM

DannyS712 edited projects, added MediaWiki-extensions-CloseWikis; removed MediaWiki-extensions-Other.Feb 22 2020, 4:52 AM

Reedy moved this task from Unsorted to Cleanup on the Schema-change board.Feb 23 2020, 3:06 PM

Change 600519 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CloseWikis@master] Convert closedwikis.cw_wiki from unique index to primary key

https://gerrit.wikimedia.org/r/600519

gerritbot added a project: Patch-For-Review.May 31 2020, 12:27 AM

DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.May 31 2020, 12:32 AM

Change 600519 merged by jenkins-bot:

[mediawiki/extensions/CloseWikis@master] Convert `closedwikis.cw_wiki` from unique index to primary key

https://gerrit.wikimedia.org/r/600519

Umherirrender closed this task as Resolved.Jul 27 2022, 11:36 PM

Umherirrender removed a project: Patch-For-Review.