Page MenuHomePhabricator

Special:Preferences: Custom .mw-editfont-*(monospace|serif) class results in page reflow
Closed, ResolvedPublic

Description

Current CSS reduces input widget's height when “Treat signature as wikitext” toggle is selected

Event Timeline

Esanders triaged this task as Low priority.EditedJun 15 2020, 11:17 AM

It looks like line-height is ignored by text inputs, so we'd either have to not size the correct font size, or use a fixed height.

The height is also a problem in ActionFieldLayouts:

image.png (72×389 px, 4 KB)

Change 605563 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Fix height of OOUI inputs with mw-editfont-*

https://gerrit.wikimedia.org/r/605563

Change 605563 merged by jenkins-bot:
[mediawiki/core@master] Fix height of OOUI inputs with mw-editfont-*

https://gerrit.wikimedia.org/r/605563

Change 605563 merged by jenkins-bot:
[mediawiki/core@master] Fix height of OOUI inputs with mw-editfont-*

https://gerrit.wikimedia.org/r/605563

@Esanders @Volker_E is this now resolved?

matmarex subscribed.

Looks resolved to me.

Untitled.gif (255×1 px, 35 KB)

Change 605563 merged by jenkins-bot:
[mediawiki/core@master] Fix height of OOUI inputs with mw-editfont-*

https://gerrit.wikimedia.org/r/605563

@Esanders @Volker_E is this now resolved?

Note, that height setting in px for input has since been changed to min-height for accessibility reasons. And changing font size setting from px to relative unit is further discussed in parent task T245476 and is throwing errors in recent stylelint-config-wikimedia.