Show disallowed message for AbuseFilter with disallow action but without warn action in CX card
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Xiplus
	Feb 26 2020, 1:47 PM

Description

If disallowed message is set but no warning message in AbuseFilter. Show the disallowed message in CX card.

Admin can set system message of disallow action on AbuseFilter now. The message doesn't show in CX card. It should be shown as AbuseFilter with warn action.
Actual result: https://commons.wikimedia.org/wiki/File:CX_AbuseFilter_disallowed_card_zhwiki.png
Excepted result: https://commons.wikimedia.org/wiki/File:CX_card_for_AbuseFilter_with_warning_message_and_disallow_action_on_zhwiki.png (I set the AbuseFilter with warn action to show the message in CX card.)

Related Objects
Search...

Status	Assigned	Task
Resolved	Amire80	T95655 CX Phase 2 deployment issues (tracking)
Open	None	T96003 Publishing and saving errors (tracking)
Open	None	T246215 Show disallowed message for AbuseFilter with disallow action but without warn action in CX card

Event Timeline

Xiplus created this task.Feb 26 2020, 1:47 PM

Restricted Application added subscribers: Stang, Aklapper. · View Herald TranscriptFeb 26 2020, 1:47 PM

Proposed code changes:
AbuseFilterCheck.php#129: Set $val['disallow']['messageHtml'] from $val['disallow']['parameters'].
mw.cx.TranslationController.js#405: Use validation.disallow.messageHtml if validation.warn.messageHtml is not available.