Page MenuHomePhabricator
Create Task
Maniphest T246873

New edit summaries sometimes don't mention all languages
Closed, ResolvedPublicBUG REPORT
Actions

Description

While auditing my bot's changes, I noticed some new edit summaries don't mention all languages.

Examples:

In these edits, my bot removed a duplicate alias in the language but it isn't mentioned.
The common thing could be that there is always at least one other alias left in the same language.

Details

SubjectRepoBranchLines +/-
Fix buggy logic on building change op result of aliasesmediawiki/extensions/Wikibasemaster+29 -21
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
OpenNoneT220696 [Story] Create better edit summaries for wbeditentity API endpoint
ResolvedBUG REPORTLadsgroupT246873 New edit summaries sometimes don't mention all languages
· · ·

Event Timeline

matej_suchanek created this task.Mar 4 2020, 9:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 4 2020, 9:26 AM
Addshore added a project: Wikidata-Campsite.Mar 4 2020, 9:28 AM
Lydia_Pintscher triaged this task as High priority.Mar 4 2020, 10:44 AM
Lydia_Pintscher raised the priority of this task from High to Needs Triage.
Lydia_Pintscher triaged this task as High priority.
Lydia_Pintscher moved this task from Incoming to Unconnected Stories on the Wikidata-Campsite board.
Ladsgroup claimed this task.Mar 9 2020, 5:51 AM
Ladsgroup edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Ladsgroup subscribed.

This basically happens only if you remove aliases but still there are some aliases left in that language. The system just doesn't understand a change has happened:

image.png (194×1 px, 37 KB)

Funnily enough, this is not the case when you add an alias (keep in mind, we don't have concept of changed alias, it's basically one alias removed and one added).

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMar 9 2020, 5:51 AM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Mar 9 2020, 6:15 AM
Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.
gerritbot added a comment.Mar 9 2020, 6:50 AM

Change 578170 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Fix buggy logic on building change op result of aliases

https://gerrit.wikimedia.org/r/578170

gerritbot added a project: Patch-For-Review.Mar 9 2020, 6:50 AM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 9 2020, 7:08 AM
gerritbot added a comment.Mar 11 2020, 8:28 AM

Change 578170 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix buggy logic on building change op result of aliases

https://gerrit.wikimedia.org/r/578170

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 11 2020, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 11 2020, 9:10 AM
Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 11 2020, 11:20 AM
Lydia_Pintscher subscribed.Mar 13 2020, 5:42 PM

Tested it on test Wikidata. It's not working there yet but I assume that's because it is not deployed there yet. Tried to test it on beta Wikidata but that doesn't keep me logged in on mobile for some reason and when not logged in the caching is broken and I can't see my changes reflected in the page. Next try after deployment on test.

Lydia_Pintscher closed this task as Resolved.Mar 20 2020, 9:56 AM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Seems to be working fine now \o/

Maintenance_bot moved this task from In progress to Done on the User-Ladsgroup board.Mar 20 2020, 10:15 AM
matej_suchanek awarded a token.Mar 23 2020, 10:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL