Page MenuHomePhabricator

class@anonymous
Closed, DuplicatePublicPRODUCTION ERROR

Description

Error message
Cache key contains characters that are not allowed: `Q3207_1123751361_⧼lang⧽_label`
Impact

There's order of hundreds of these in group0 and group1. This is enough that is makes me, as train conductor, worried about promoting the train to group2. I'm not going to block the train because of this, but if it happens a lot in group2, I'll have to roll back. Urgent attention would be welcome, if only tell me it's nothing to worry about.

Notes

mediawiki verion 1.35.0-wmf.22
commons.wikimedia.org

Details

Request ID
XmDkfApAIC4AAHRriJYAAABD
Request URL
/wiki/Category:Aude?uselang=%E2%A7%BCLang%E2%A7%BD
Stack Trace
#0 /srv/mediawiki/php-1.35.0-wmf.22/extensions/Wikibase/lib/includes/SimpleCacheWithBagOStuff.php(266): Wikibase\Lib\SimpleCacheWithBagOStuff->invalidArgument(string)
#1 /srv/mediawiki/php-1.35.0-wmf.22/extensions/Wikibase/lib/includes/SimpleCacheWithBagOStuff.php(71): Wikibase\Lib\SimpleCacheWithBagOStuff->assertKeyIsValid(string)
#2 /srv/mediawiki/php-1.35.0-wmf.22/extensions/Wikibase/lib/includes/StatsdRecordingSimpleCache.php(59): Wikibase\Lib\SimpleCacheWithBagOStuff->get(string, string)
#3 /srv/mediawiki/php-1.35.0-wmf.22/extensions/Wikibase/lib/includes/Store/CachingFallbackLabelDescriptionLookup.php(121): Wikibase\Lib\StatsdRecordingSimpleCache->get(string, string)
#4 /srv/mediawiki/php-1.35.0-wmf.22/extensions/Wikibase/lib/includes/Store/CachingFallbackLabelDescriptionLookup.php(107): Wikibase\Lib\Store\CachingFallbackLabelDescriptionLookup->getTerm(Wikibase\DataModel\Entity\ItemId, string, string)
#5 /srv/mediawiki/php-1.35.0-wmf.22/extensions/Wikibase/client/includes/Usage/UsageTrackingLanguageFallbackLabelDescriptionLookup.php(71): Wikibase\Lib\Store\CachingFallbackLabelDescriptionLookup->getLabel(Wikibase\DataModel\Entity\ItemId)
#6 /srv/mediawiki/php-1.35.0-wmf.22/extensions/Wikibase/client/includes/DataAccess/Scribunto/WikibaseLanguageDependentLuaBindings.php(60): Wikibase\Client\Usage\UsageTrackingLanguageFallbackLabelDescriptionLookup->getLabel(Wikibase\DataModel\Entity\ItemId)
#7 /srv/mediawiki/php-1.35.0-wmf.22/extensions/Wikibase/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibrary.php(605): Wikibase\Client\DataAccess\Scribunto\WikibaseLanguageDependentLuaBindings->getLabel(string)
#8 /srv/mediawiki/php-1.35.0-wmf.22/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxCallback.php(26): Wikibase\Client\DataAccess\Scribunto\Scribunto_LuaWikibaseLibrary->getLabel(string)
#9 [internal function]: Scribunto_LuaSandboxCallback->__call(string, array)
#10 /srv/mediawiki/php-1.35.0-wmf.22/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxInterpreter.php(113): LuaSandboxFunction->call(LuaSandboxFunction)
#11 /srv/mediawiki/php-1.35.0-wmf.22/extensions/Scribunto/includes/engines/LuaCommon/LuaEngine.php(291): Scribunto_LuaSandboxInterpreter->callFunction(LuaSandboxFunction, LuaSandboxFunction)
#12 /srv/mediawiki/php-1.35.0-wmf.22/extensions/Scribunto/includes/engines/LuaCommon/LuaModule.php(69): Scribunto_LuaEngine->executeFunctionChunk(LuaSandboxFunction, PPTemplateFrame_Hash)
#13 /srv/mediawiki/php-1.35.0-wmf.22/extensions/Scribunto/includes/common/Hooks.php(128): Scribunto_LuaModule->invoke(string, PPTemplateFrame_Hash)
#14 /srv/mediawiki/php-1.35.0-wmf.22/includes/parser/Parser.php(3604): ScribuntoHooks::invokeHook(Parser, PPTemplateFrame_Hash, array)
#15 /srv/mediawiki/php-1.35.0-wmf.22/includes/parser/Parser.php(3308): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#16 /srv/mediawiki/php-1.35.0-wmf.22/includes/parser/PPFrame_Hash.php(253): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#17 /srv/mediawiki/php-1.35.0-wmf.22/includes/parser/Parser.php(3486): PPFrame_Hash->expand(PPNode_Hash_Tree)
#18 /srv/mediawiki/php-1.35.0-wmf.22/includes/parser/PPFrame_Hash.php(253): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#19 /srv/mediawiki/php-1.35.0-wmf.22/includes/parser/PPTemplateFrame_Hash.php(89): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#20 /srv/mediawiki/php-1.35.0-wmf.22/includes/parser/Parser.php(3483): PPTemplateFrame_Hash->cachedExpand(string, PPNode_Hash_Tree)
#21 /srv/mediawiki/php-1.35.0-wmf.22/includes/parser/PPFrame_Hash.php(253): Parser->braceSubstitution(array, PPFrame_Hash)
#22 /srv/mediawiki/php-1.35.0-wmf.22/includes/parser/Parser.php(3149): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#23 /srv/mediawiki/php-1.35.0-wmf.22/includes/parser/Parser.php(1483): Parser->replaceVariables(string)
#24 /srv/mediawiki/php-1.35.0-wmf.22/includes/parser/Parser.php(599): Parser->internalParse(string)
#25 /srv/mediawiki/php-1.35.0-wmf.22/includes/content/WikitextContent.php(368): Parser->parse(string, Title, ParserOptions, boolean, boolean, integer)
#26 /srv/mediawiki/php-1.35.0-wmf.22/includes/content/AbstractContent.php(565): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#27 /srv/mediawiki/php-1.35.0-wmf.22/includes/Revision/RenderedRevision.php(267): AbstractContent->getParserOutput(Title, integer, ParserOptions, boolean)
#28 /srv/mediawiki/php-1.35.0-wmf.22/includes/Revision/RenderedRevision.php(236): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#29 /srv/mediawiki/php-1.35.0-wmf.22/includes/Revision/RevisionRenderer.php(215): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string)
#30 /srv/mediawiki/php-1.35.0-wmf.22/includes/Revision/RevisionRenderer.php(152): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#31 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#32 /srv/mediawiki/php-1.35.0-wmf.22/includes/Revision/RenderedRevision.php(198): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#33 /srv/mediawiki/php-1.35.0-wmf.22/includes/poolcounter/PoolWorkArticleView.php(196): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#34 /srv/mediawiki/php-1.35.0-wmf.22/includes/poolcounter/PoolCounterWork.php(125): PoolWorkArticleView->doWork()
#35 /srv/mediawiki/php-1.35.0-wmf.22/includes/page/Article.php(809): PoolCounterWork->execute()
#36 /srv/mediawiki/php-1.35.0-wmf.22/includes/page/CategoryPage.php(66): Article->view()
#37 /srv/mediawiki/php-1.35.0-wmf.22/includes/actions/ViewAction.php(63): CategoryPage->view()
#38 /srv/mediawiki/php-1.35.0-wmf.22/includes/MediaWiki.php(519): ViewAction->show()
#39 /srv/mediawiki/php-1.35.0-wmf.22/includes/MediaWiki.php(305): MediaWiki->performAction(CategoryTreeCategoryPage, Title)
#40 /srv/mediawiki/php-1.35.0-wmf.22/includes/MediaWiki.php(972): MediaWiki->performRequest()
#41 /srv/mediawiki/php-1.35.0-wmf.22/includes/MediaWiki.php(535): MediaWiki->main()
#42 /srv/mediawiki/php-1.35.0-wmf.22/index.php(47): MediaWiki->run()
#43 /srv/mediawiki/w/index.php(3): require(string)
#44 {main}

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
LarsWirzenius triaged this task as Unbreak Now! priority.Mar 5 2020, 11:49 AM

Marking as UBN due to risk to train.

Tarrow subscribed.

I'll be looking at this today

After discussion on IRC it seems likely this probably, maybe, won't happen more often if we promote train to group2. Leaving as a train blocker, will promote go group2 and remove as train blocker later if things go well.

Group2 has been running 1.35.0-wmf.22 for almost an hour and there's been no explosion of these errors, so I'm removing it as a train blocker.

LarsWirzenius lowered the priority of this task from Unbreak Now! to Needs Triage.Mar 5 2020, 2:55 PM

This is T245295 (or, well, ish; the specific cause is passing through the uselang param even when it's set to qqx), and has been an issue for a few weeks now. Shall we merge?

I think this can be merged into T245295.

In my opinion this ticket shows a symptom of at least 3 separate problems:

  • T245295 : Production logging of this is broken / unclear because of the error class that is thrown
  • T245396: The Wikibase implementation of a SimpleCache backed by a BagOStuff doesn't take advantage of the methods provided by BagOStuff to reduce the incidence of attempts to use bad keys
  • T247057: A Wikibase caching lookup is wrongly trying to do lookups for languages that are not valid Term Languages