Page MenuHomePhabricator

Keyboard focus order is not logical for the "Find and Replace" screen.
Closed, DeclinedPublicBUG REPORT

Description

Steps to Reproduce:

  1. Navigate to VisualEditor
  2. Navigate to Page Options
  3. Navigate till "Find And Replace" and hit enter
  4. Observe the keyboard focus order.

Actual Results:
Keyboard focus order is not logical for the "Find and Replace" screen .
After opening the "Find and Replace" screen, keyboard focus moves in given order : "Find edit box" ->"Replace edit box" ->"Replace" button ->"Replace All" button ->"Done"->"Previous button" ->"Next button"->"Match Case"->"Regular Expression " button and all buttons after that .

Expected Results:
Keyboard focus order must be "Find edit box" ->"Replace edit box" -> "Previous button" ->"Next button"->"Match Case"->"Regular Expression " button and all buttons after that then "Replace" button ->"Replace All" button ->"Done"

Event Timeline

Change 577684 had a related patch set uploaded (by Akinwale-microsoft; owner: Akinwale-microsoft):
[VisualEditor/VisualEditor@master] Updating Find and Replace dialog to have a more logical tab order

https://gerrit.wikimedia.org/r/577684

I'm not fully convinced about the approach here, pls clarify further. For an AT user, it might not be clear that there are more options to come. So far so clear.
For a keyboard user those extra tabs would make their interaction worse.

JTannerWMF subscribed.

We will differ to @Volker_E 's clarifying question here.

Change 577684 abandoned by Akinwale-microsoft:
Updating Find and Replace dialog to have a more logical tab order

https://gerrit.wikimedia.org/r/577684