Maniphest T247434

Scroll to section doesn't work for subsections in collapsed section
Closed, ResolvedPublicBUG REPORT
Actions

Description

How many times were you able to reproduce it?

Always

Steps to reproduce

Open enwiki > Coffin Stone
Tap "Bibliography" in the table of contents
Observe the article scroll position
Close and re-open the article to re-repro (works fine the second time)

Expected results

Bibliography header is at the top of the screen

Actual results

Bibliography header is off screen

Notes

Works after the second try, it's likely due to section hiding

Details

	Subject	Repo	Branch	Lines +/-
	Update prepareForScrollToSection to be async	mediawiki/services/mobileapps	master	+85 -21

Customize query in gerrit

Event Timeline

JoeWalsh created this task.Mar 11 2020, 6:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2020, 6:25 PM

LGoto triaged this task as Medium priority.Mar 12 2020, 7:03 PM

LGoto moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v6.6-Penguin-On-A-Sled board.

JoeWalsh claimed this task.Mar 13 2020, 11:25 AM

JoeWalsh moved this task from Ready for Development to Doing on the iOS-app-v6.6-Penguin-On-A-Sled board.

JoeWalsh moved this task from Doing to Needs Code Review on the iOS-app-v6.6-Penguin-On-A-Sled board.Mar 13 2020, 12:06 PM

Change 579537 had a related patch set uploaded (by Joewalsh; owner: Joewalsh):
[mediawiki/services/mobileapps@master] Update prepareForScrollToSection to be async

https://gerrit.wikimedia.org/r/579537

gerritbot added a project: Patch-For-Review.Mar 13 2020, 12:07 PM

JoeWalsh added projects: Page Content Service, Product-Infrastructure-Team-Backlog-Deprecated (Kanban).Mar 13 2020, 12:07 PM

JoeWalsh moved this task from To Do to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

Change 579537 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Update prepareForScrollToSection to be async

https://gerrit.wikimedia.org/r/579537

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2020, 5:10 PM

Tsevener moved this task from Needs Code Review to Waiting for Build on the iOS-app-v6.6-Penguin-On-A-Sled board.Mar 13 2020, 8:09 PM

Tsevener moved this task from Waiting for Build to Needs Code Review on the iOS-app-v6.6-Penguin-On-A-Sled board.

JoeWalsh moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Mar 16 2020, 2:32 PM

JoeWalsh moved this task from Needs Code Review to Needs Design Review on the iOS-app-v6.6-Penguin-On-A-Sled board.Mar 16 2020, 6:34 PM

LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Mar 16 2020, 6:46 PM

• bearND moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Mar 16 2020, 8:06 PM

I'm still seeing the old behavior on 6.6.0 (1729)

Unfortunately not working on 1733 for me.

@cmadeo I'm not able to repro using the repro steps on 1733. If you go into the app settings and select "Clear cached data" and then re-load the article are you still able to repro? And if so, is it the same article as in the repro steps or a different one? Thanks!

JoeWalsh moved this task from Ready for Development to Blocked or Waiting on the iOS-app-v6.6-Penguin-On-A-Sled board.Mar 27 2020, 6:51 PM

@JoeWalsh sorry! Working now for me! Thanks!

@cmadeo no problem, thanks for reporting! Was it clearing the cache that fixed it? There might be an issue on our end with files staying in the cache too long if it was still broken.

@JoeWalsh actually didn't even need to clear the cache, just trying it again today worked

Looks good after clearing the cache on 6.6.0 (1733)

• bearND closed this task as Resolved.Apr 2 2020, 6:16 PM

Scroll to section doesn't work for subsections in collapsed sectionClosed, ResolvedPublicBUG REPORTActions