Page MenuHomePhabricator
Create Task
Maniphest T248036

Remove Revision::getParentLengths
Closed, ResolvedPublic
Actions

Description

Hard deprecated in 1.35, no remaining uses

Details

SubjectRepoBranchLines +/-
Remove multiple unused deprecated Revision methodsmediawiki/coremaster+6 -257
Remove use of deprecated Revision::getParentLengthsmediawiki/extensions/GlobalContribsmaster+3 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 changed the task status from Open to Stalled.Mar 18 2020, 10:55 PM
DannyS712 triaged this task as Medium priority.
DannyS712 created this task.
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

Cannot be removed until 1.36

DannyS712 mentioned this in T247143: Remove the Revision class [1.37].Mar 18 2020, 10:56 PM
DannyS712 added a parent task: T247143: Remove the Revision class [1.37].
gerritbot added a comment.Mar 18 2020, 10:57 PM

Change 581120 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalContribs@master] Remove use of deprecated Revision::getParentLengths

https://gerrit.wikimedia.org/r/581120

gerritbot added a project: Patch-For-Review.Mar 18 2020, 10:57 PM
gerritbot added a comment.Mar 18 2020, 11:34 PM

Change 581120 merged by jenkins-bot:
[mediawiki/extensions/GlobalContribs@master] Remove use of deprecated Revision::getParentLengths

https://gerrit.wikimedia.org/r/581120

DannyS712 removed a project: Patch-For-Review.Mar 18 2020, 11:45 PM
DannyS712 updated the task description. (Show Details)
DannyS712 updated the task description. (Show Details)Mar 25 2020, 1:59 AM
DannyS712 moved this task from Next to Later on the User-DannyS712 board.Apr 13 2020, 9:13 PM
DannyS712 edited projects, added MediaWiki-Core-Revision-backend; removed MediaWiki-General.Apr 27 2020, 6:09 AM
DannyS712 changed the task status from Stalled to Open.Jul 14 2020, 9:51 AM
DannyS712 removed a parent task: T245331: Remove core fallbacks to global $wgUser [1.36].Nov 30 2020, 10:49 PM
DannyS712 moved this task from 2020 | MW 1.35 to Not yet on the Technical-Debt (Deprecation process) board.Dec 18 2020, 2:19 AM
gerritbot added a comment.Dec 29 2020, 2:28 PM

Change 652405 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/core@master] Remove Revision::getParentLengths()

https://gerrit.wikimedia.org/r/652405

gerritbot added a project: Patch-For-Review.Dec 29 2020, 2:28 PM
taavi subscribed.Dec 29 2020, 2:45 PM
gerritbot added a comment.Dec 29 2020, 8:49 PM

Change 652405 abandoned by Majavah:
[mediawiki/core@master] Remove multiple unused deprecated Revision methods

Reason:
not yet ready, whole class is going to be removed in 1.37

https://gerrit.wikimedia.org/r/652405

DannyS712 changed the task status from Open to Stalled.Dec 29 2020, 9:00 PM
DannyS712 removed a project: Patch-For-Review.

Reflect decision to wait until 1.37 for Revision removals

DannyS712 closed this task as Resolved.Jun 10 2021, 10:53 PM

This task was filed when I was not expecting to be able to remove the whole Revision class, sorry for the confusion. Resolving now that the entire class has been removed as part of T247143, see rMW983984d5d4a4: EPIC: Remove the Revision class entirely.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL